From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B3961C84BC for ; Tue, 7 Jul 2026 14:01:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783432892; cv=none; b=GkMVfgwgwAF4zlOcwz9KXpGKwr8QK3CHYfnuRH+DvWDyosjVscIS36Wnk7oZ1YSjCghr/Zv1GHMsDr1XO5cZG/nTzNznhibyf5N+y8nJi+NOOUVB8Kt1fib8rCghtQCulgyseq9fa+OM7ija2LYGOGKjq9QMOuBoLYRZnAy+Pls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783432892; c=relaxed/simple; bh=k3p/LVhY6XieXSUYhvqXUVhPUxXPhzCecfn9ETy2ZfU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Yap171p4hY/xjyzQTLEG6sTqt3hFdnE/NMqVue5zxylGo59g/+qDUSk9xYXWJEu2F2X/eh4wmSuNUupHTSUau0sxX9zJO063F3CeOE9pggQT2p/TUP+NllrUcqUnzWjGbCwo9WxrAUND+6g531ujHuMT7e9h722Om7l7yq+3iog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WUWThvoB; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WUWThvoB" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-845e47133c9so442584b3a.0 for ; Tue, 07 Jul 2026 07:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783432890; x=1784037690; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1ph26z8kK868uOu08qfxJac8BJOh6HBGTI2padbyuTk=; b=WUWThvoBUsYnh4FGPEUThyMRq6JfELOa/egcneUe06QMXRGMK/riwhn9H4lQUlgDMx UjrDH/b/VqTFbzmfx9D8ItClmxZMVO46Wfweepub7aALaPHojudiA2EpZkbdXs4gg2hD Cn86vjayK2Hin04hJZcFxdSp5RhxJdPchYaNFGrelxZTeYYaCacOaH0RkqwFAgd3GYt5 kV1im5Pe7HwiXy6VlbSYzHjWfnjTV5EGiN6rAo5wr8hrVeM9yvJuQkOMVfyXcfgRFKC/ NanLH5z7A55j/rvs0J9iWm1XnRBQKx1MEdcC3qqL7Nxu8LlBiwbQFTXZbMmA8MqQwoP5 Ehpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783432890; x=1784037690; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1ph26z8kK868uOu08qfxJac8BJOh6HBGTI2padbyuTk=; b=owKMR7ETJbfUPM2jb9Ws3QIVFXF2VNKE0Go3wSUTRHmOQkjOgJuu1GtOB3cbfNmELk qeWqhCACjZ1O1EN4NU4lWDIJCYDfuKUmvtwqjNg7h4yNUODsc9uxw2h1UJGFgrZh2rcj ygAnHNbRYPbul93lqTpaRkv5GiD5SsaYGZU2MLaKEM/SERDOdbN9ZOQOC43pJpwPG3X0 v4erwnekZAkc+b3wD1T257CTCNwNoBCXgYxbuUbIdIT0sf2nosXxtKoFsyIpw+ZAwLQO sgrtvFAeDC7F+9TVmFrCYUWI9B2Bul4vMYlq2mqZn64k7DQT3VvOazx9N2SC9ZAHxQGg Iaag== X-Forwarded-Encrypted: i=1; AHgh+Ro2DYYLeUc/I2X/G6qSZr4zTdy9zMGIbK7ls+BF4VhlB6IEeI7tya6MMDaI1TS8MRFTgUNeWa18wfMZhtI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxqg3NXPSjSOuNRAeUFhYv65OvhIuOESRurGmyLfzL3x4lsXqFg kW5sEI116Jh1umrzhAMqG5Uji5/XtXNEvKwdb+H2eusuSm3s7mLWQnKShoRnCqGwE7I= X-Gm-Gg: AfdE7ckdR+5qCRd/L2kqbrFsPTdeBw+STpxcu7k6rm7d7XwZIh7MA48QQ8mw1OTPnRF qMFC6Zc99ikk87FR0qX/GSBPkAlBfea2hHvB8ekZjXy7KkExfUrM3gv2h6HcjCifY25zbWMwoCv jklah5TeTJ/2MXmWgQvVSRzThgYzwiEo0xrLfRDEbxrYXC0oUY/H/bG3wn4SHlcxZ/rp8EaHTct k67t3Bf2HfOr+OU/3bxEgXafk/ElMC2BNdZfHvLrk5uyhuHxCvOhfHx2795uXlzjjqX2RL0lgHZ QJN37gbQQ7YRgzpO75xYVflQjIVecIWKNniNvUiBiGx3QgQHA5UQktX/IVqndyVuZ0j1Z1TSFlB K41wXxRs+WmOSv9dRTpsWVVttOCa6cxKEHwSaMhdHs66wH4hgHQ2v5ARCiL9gG8JFwd7Jk9Nauy 7OJlWl X-Received: by 2002:a05:6a20:914e:b0:3bf:a517:cdcd with SMTP id adf61e73a8af0-3c09b0140a3mr3677488637.12.1783432889904; Tue, 07 Jul 2026 07:01:29 -0700 (PDT) Received: from beelink.. ([186.22.57.86]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b6596681fsm9900909c88.8.2026.07.07.07.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 07:01:25 -0700 (PDT) From: Aldo Ariel Panzardo To: linux-xfs@vger.kernel.org, Carlos Maiolino Cc: "Darrick J . Wong" , linux-kernel@vger.kernel.org, Aldo Ariel Panzardo Subject: [PATCH] xfs: reject remote xattr entries with an out-of-range value length Date: Tue, 7 Jul 2026 11:01:18 -0300 Message-ID: <20260707140118.3217585-1-qwe.aldo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xfs_attr3_leaf_verify_entry() validates a remote attribute entry's name but never bounds its on-disk value length (xfs_attr_leaf_name_remote. valuelen, a __be32). A crafted leaf with valuelen = 0x80000000 passes the verifier and the CRC. That length is later assigned into the signed int args->rmtvaluelen (xfs_attr3_leaf_getvalue), becoming negative, which slips past the signed -ERANGE check in xfs_attr_copy_value(); a getxattr() with a small buffer then memcpy()s a full remote block into the small kvalue buffer (xfs_attr_rmtval_copyout) -- a heap out-of-bounds write with attacker-controlled content, from an unprivileged getxattr(2) on a mounted crafted image. Reject remote entries whose value length exceeds XFS_XATTR_SIZE_MAX in the leaf verifier, so the malicious block is rejected at read time. Fixes: c84760659dcf ("xfs: check attribute leaf block structure") Signed-off-by: Aldo Ariel Panzardo --- fs/xfs/libxfs/xfs_attr_leaf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c index 86c5c09a5db4..f1769289f908 100644 --- a/fs/xfs/libxfs/xfs_attr_leaf.c +++ b/fs/xfs/libxfs/xfs_attr_leaf.c @@ -339,6 +339,8 @@ xfs_attr3_leaf_verify_entry( if (!(ent->flags & XFS_ATTR_INCOMPLETE) && rentry->valueblk == 0) return __this_address; + if (be32_to_cpu(rentry->valuelen) > XFS_XATTR_SIZE_MAX) + return __this_address; } if (name_end > buf_end) -- 2.43.0