From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C67B379C47 for ; Tue, 7 Jul 2026 15:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783436719; cv=none; b=Azt0piWWyk4FkSVv5Yp/Fprds8HR7PNarxjRWoJW5dCrgMBVwhbT07C8bloIWZOwL49ghfEZlIhN8HZV4UvJab/Y2Q1tZzWHKsDwvsurOwimDpJrgBG0Cz6A1Pxni2YJVHXeOOfrrrZYUWpQSbBmqR6SJ8S3FzYwZg+NMBj2e7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783436719; c=relaxed/simple; bh=wCwdT+MCVwlDfg5F3ZYmVPpwSAOE6JBBtrXsacrrEBQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZKMT+JeRue6C6crmyInt0sMEgZqFO9sQodAPixeTAuk6xKAsuI34L4koXpM9vsg1U7VhqH0cKmJ7Zc2fyrIPRBv+LHCOAA5BJqcx0zjJ/xqUNpOQ8ogmcy3i96tRc33dWzlXR1DPxl5AGlGsV+mI80D69WHyxlXZMrM3+9RUJxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CggbbK2H; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CggbbK2H" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cc73e322dbso27604545ad.1 for ; Tue, 07 Jul 2026 08:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783436716; x=1784041516; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=JGVhoJBTQ+C/shIBMcaZxxiUzHSDCbdKbDb/tDZozNo=; b=CggbbK2HTbDo8jrwbwfsDoSSwWsRut6t/BVszgjjuHwZvGHKz6mt7KXvPFUHxIlLWC NX4Ll4YQqKImu8NKfWIY8pY4zGjtwDrcPA39oPMdh7ToNvmWgUfFUTi0R1kZC5Hhc/kM Qv03YXXcSwwwJxRSvB+jMklfdepsUbxrJTEROTDd47ytOb9Vc7L9KEN7AxjdSn6RAUVX szGmcRk/DUl+mBmzIYQ+XQCJ+nPRVhQppcl/J/cP6q+XYkkTkjwI6+mZk9hqDgeCHmHs V4HhLBEoA+xr2AHpMobHCTHfAsXxrP+vk6bQMyUw34jQ7uJgudZPwaw0ZBLaNJBS7YGR YxbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783436716; x=1784041516; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JGVhoJBTQ+C/shIBMcaZxxiUzHSDCbdKbDb/tDZozNo=; b=U9kBFLM0E56N6p1V55Sqr16fyzPL3Iym5VI3yBqcgNLSLBKaipPazNJXEJs9vfINlO pLDL8IFx5OdrUYNSbM8bPXAweF55KGez4/oDourhEQ0dqbfmkfHVhWfMcaAUhtX9Sx6j +TKYcfCbtpVZpn2jm70qHH+uQsfoFoh7BvnJgawOL4lSAJ4Tcmu7BPcQzrrlTBlmlQXX HYfZcjghxCkpRKMDbvI+SQQdMd+MDru2zNtg2Q6rzuXZOD6RUwZYJyGLUvucfT3lSmEV fdQRoj5kiJTMaeuWbJ6Nb3/XWgNkfztbPehFZ/2w2bfL/Kky6ge7ios2zgxxvnBAOuRI VW/A== X-Forwarded-Encrypted: i=1; AHgh+RrU9Y1PiAfebYcQ8frI7wh8RkJ/bOQHR4B39nyXk6xqg3O37xIVCPcF7oWlVymYqlhiSe+2U001jnaNZDg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+b+5JwTEZ5tbwpCVxeZwCR/+rQVbNLSAsg6ncz02JEHetORdj RTmuZctImkKNTIoFQrLAxGzdoBDNqsnUilny4x/DRVek5afLL9JiUEKs X-Gm-Gg: AfdE7clC6El8d0Na0n3+hs1c+qnGAZnjVLeC/6IEQ+2UTqYs0VTBNpmKusgVqrGQM1n TTqmF/i2TFHTFZ50TMNufQGJPVfju1leNONGeaEPxrFYflm7t/NQHiohIW3MaYnq4P0ykS9tTt+ zjsIMxg+ZdX1S2XTBfUx7u2VYE/BUX5GI6XXHopQYa+t3mNCfqhcj1nyo4DRkvYuoZI22lAzPdW hY9jynzFB9W5KECjpkKxt71EwckJr7oMsyI9CDr+0qLqMpgzc0vO/4Zy+PmEs413sPsISKu39HN QJenZ0PwEFe4KKwnbPJyyCP87HUN6627xI+ku9T5+SKTcBGl0ngSC6zl7UtCWkkkaSWoVnnwsRg EtmRq3Cwg4qaGn51YxDoxvwsVCHe7zI7jqYmVYqntw+g5sJ9fDklgXOzSsSbaNA/qKs4f6eAeJ8 0GnCu9raVGdJIoRgX5YWWFjSdjWsPQBDwTbP3aNKSXxRk= X-Received: by 2002:a17:902:ef44:b0:2c9:cf62:6f61 with SMTP id d9443c01a7336-2ccbe616252mr55602255ad.17.1783436715990; Tue, 07 Jul 2026 08:05:15 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:239e:a31b:1d0d:374f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d3bc42sm13598865ad.63.2026.07.07.08.05.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 08:05:15 -0700 (PDT) From: Ruoyu Wang To: p.zabel@pengutronix.de, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] drm/imx/ipuv3: Check CRTC state before freeing Date: Tue, 7 Jul 2026 23:05:08 +0800 Message-ID: <20260707150508.2267884-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit imx_drm_crtc_reset() destroys the current CRTC state only when crtc->state is non-NULL, but it always converts crtc->state to struct imx_crtc_state and passes the result to kfree(). When reset is called without an existing state, container_of(NULL, ...) does not produce NULL. Keep the imx state free in the same crtc->state guard as the helper state destruction. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 8ed5dcf966dd ("drm/imx: Use __drm_atomic_helper_crtc_reset") Signed-off-by: Ruoyu Wang --- drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c index 1405e50ee56b5..e4f0c91dc7610 100644 --- a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c +++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c @@ -111,10 +111,10 @@ static void imx_drm_crtc_reset(struct drm_crtc *crtc) { struct imx_crtc_state *state; - if (crtc->state) + if (crtc->state) { __drm_atomic_helper_crtc_destroy_state(crtc->state); - - kfree(to_imx_crtc_state(crtc->state)); + kfree(to_imx_crtc_state(crtc->state)); + } crtc->state = NULL; state = kzalloc_obj(*state); -- 2.51.0