From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5C8E379C2F for ; Tue, 7 Jul 2026 15:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783436792; cv=none; b=XycqS7QXC0H54Vht5j0f9T1FTPq7sfqyefoO87qgnHwcgUACdJ2q5saffanHfY92RIRbDeECWQ/QYpNkMOXZgay7TUJnm3LuF6esm9HE5Cajr/rAlZmMhHlKXUJzg4oTMiK1Kb0q3erOQ6eQQYPwun6GjJwD1sXyUD7pLafsJIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783436792; c=relaxed/simple; bh=mF1Q8h8f8ja7oxsETzW0K9C2viuSjP/6sJUlaEJEzUM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=W9SF44b+98GzjZkwRo6q6CLSwXlF5zfeT/+TWlfzc9J7EXnnp2N5P/xsdweXksv9TYuREMEXxyPfXRhPvEjK8WOk6aBC3xwQjnVimZUJ8acF/ual6suB6qfWgCbmrjYsHex77JiXZYKl09intrrmGffjTOs7qgWceHSDnzjR1zQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mGbdwmO1; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mGbdwmO1" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-845ea8924a2so4309289b3a.1 for ; Tue, 07 Jul 2026 08:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783436791; x=1784041591; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ClN3kpbhRJMWpIGpPfBJEIxCJ6EOBpj1rMef7MXHqEc=; b=mGbdwmO1bdXLYYXnL4qBM+muPQcImeAv1gohVnwA5EFvxt2Oh/ctYNko3ekxY9USLd 5gU0E9LuA0E9e+eQ2Ga4c8oA8fDKekY/hpwdBB+EG5NkoHuFA0zGy68ON+im/Gj7cHGD YDvO1z++YMrVx0QdTB7MDMFN94mmrexVLhTua4+QNffybElGBDQ+uypxEd3fdDnI4IfE f2WScnddD0pMyf3Ufrw72qh8IMDK6WwR1LTMGJGrUQShHiACs6hlxzoXY8/78xOcPKp0 Wb63BAhMkVgtSpF8vOlTQ8ySaSY44r4TiEItqvba1p4uYIEhoWzoXX+nveywViC8zLdN DDTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783436791; x=1784041591; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ClN3kpbhRJMWpIGpPfBJEIxCJ6EOBpj1rMef7MXHqEc=; b=bzryY7O3hOnCKe5JOiv4uDHvihiFeu4nHChtK2nIN24TdPH8S7ohd1X34tTvJdhUG0 8WzcLwimmqRpWIEfq9l3ja/PXFmD1DKTHmzsoYUXXqFtPPS1akbEX/Npg2q3vqHYdsBX 2YCQ5SeewfTTPTW5ucYC7EKBRGjYnQesnFzfucMhVdJXQQQI7oeUFeUrGwqr/LrsDbGi s+rlv3oY6Xw9c/CQszKIzwVcyuVvqwFwJ5vdt4rs4IOI2F7eO5o9DsTVWtNLBlFoz9CQ hNFPDxm8nge4DZrwZko6nZ3Izn3vyJwdCGBetEGXI+2SiCISL8+fZbkl85MPQDeW+3lD Po0w== X-Forwarded-Encrypted: i=1; AHgh+RoLEeYTm5t9rgLQqkvIg5PJqbA4M6zz2bObMtJueyMc1e0mk64UhAlhQQqHDytUuwxT9EZikQo5IawLtok=@vger.kernel.org X-Gm-Message-State: AOJu0Ywd4thQRcV+CJoG6njuApCEQzkE5vexK1oGZy6tnoS1DbnI9zfw QsRq3+n7WmRQYLlUDFe4PNY//NVuTjk7qBPpEEjwOT4X9VMJBy1sWgtY X-Gm-Gg: AfdE7cmoQnXRYMzzRZKIl3WmS/RcKMeJMWnK0krwMkrBu7TU8jVl83R9j0seSJU36z3 0aPgNSehY+zgrr5dLlC1FmSb+WcS0GdeZ491Fln6xp4qNenRFjqjmp8TuNt/56ioe+v7EL0Pm2B yeweHA4WPjbXK+dKlGTgD8bMj0JdWZxC9PFHHNzqr5+GLx934PjuEER14YTBwrGL3S5dI7N2KEj ryZ6v5uSfZht/JkzVt8B9Ft1SfGiPHgpsI45/+tadkn/iuNqBlF57wPX3L8+IifVd0tNCGzyq7D Sfvo+6BEn5jNyWGFoLwYlmDH9UXwd1qr6Ia+axO8mi/a92w/j29cxK40zK6U6HYF/clLE5xHyjZ I147z71eI8mzApPBihwSaGteP6dpgRoxIx0asu+Sf9QEqdiy3WvkBFXFcwXsvytWTo//CXvOhmJ vdsI+smwgWn9Ycy0SSZ5whl0GZ/BO15tQ2 X-Received: by 2002:a05:6a00:138c:b0:847:888f:9b16 with SMTP id d2e1a72fcca58-84826c25b6dmr5534631b3a.18.1783436791037; Tue, 07 Jul 2026 08:06:31 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:239e:a31b:1d0d:374f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6d76106sm5618994b3a.40.2026.07.07.08.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 08:06:30 -0700 (PDT) From: Ruoyu Wang To: vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org Cc: stanimir.varbanov@linaro.org, hverkuil@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] media: venus: Drop session events without an instance Date: Tue, 7 Jul 2026 23:06:24 +0800 Message-ID: <20260707150624.2278561-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hfi_process_msg_packet() intentionally allows HFI_MSG_EVENT_NOTIFY packets without a matching session instance because HFI_EVENT_SYS_ERROR is a system event and has no session attached. That exception currently applies to every event-notify packet. If the firmware reports a late or otherwise invalid session event after to_instance() fails, hfi_event_notify() can dispatch it to session-only handlers such as event_seq_changed() or event_release_buffer_ref(), which dereference inst. Only system errors are valid without a session instance. Drop other event notifications before the session event handlers can dereference a NULL inst. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 09c2845e8fe4 ("[media] media: venus: hfi: add Host Firmware Interface (HFI)") Signed-off-by: Ruoyu Wang --- drivers/media/platform/qcom/venus/hfi_msgs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c b/drivers/media/platform/qcom/venus/hfi_msgs.c index 47b99d5b5af73..3135c1024fb1f 100644 --- a/drivers/media/platform/qcom/venus/hfi_msgs.c +++ b/drivers/media/platform/qcom/venus/hfi_msgs.c @@ -230,6 +230,9 @@ static void hfi_event_notify(struct venus_core *core, struct venus_inst *inst, if (!packet) return; + if (!inst && pkt->event_id != HFI_EVENT_SYS_ERROR) + return; + switch (pkt->event_id) { case HFI_EVENT_SYS_ERROR: event_sys_error(core, EVT_SYS_ERROR, pkt); -- 2.51.0