From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED39342B328 for ; Tue, 7 Jul 2026 16:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440074; cv=none; b=MfPhE1xABeBYLQ7I1CabywJBAV9ekF94cBA4cVzFomFZg3Ri6A3Ed8A2l7F1AhUTlYY2PiWHTIpYTvnoJGgB3Ls6nfbiyKrf/84bggsra5VhldyocgTMpG9HT523FJY6UV9eiy5vBpBXO77yVrEpy2pPJEoyjM+s5QNqSWojNrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440074; c=relaxed/simple; bh=f+JX6iChBmsd5rzGamlrD+Pmwf0e9Nv2moeL5RjGoTk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CqeqWmRRD9aBCWpadss2eyXlPwzQg7mFqOP4hQ+O1jcfBaNAubCpKfl68bvWitxvWz1nWtlQ5KAvt4yMqfXkBDazGTdfcu/5jgUadNSs760IgW2hRzPZREBsludmZA4K8sJBWlS7ypgUCoFF5kPm8VnTlEI4SJmv9qTcgzlwj/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G3Q2CJzr; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G3Q2CJzr" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-51c0006ea8eso25157921cf.1 for ; Tue, 07 Jul 2026 09:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783440071; x=1784044871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/PPs4NT4cwHfM8BPThtIIIxetUqnZ0DOvkOSnLEJlWo=; b=G3Q2CJzrL4FnO/4a79FgdfzcDZpQVryMZ+Pormj/PZ9T8WeZqHL8ggx1wPfx6EGbKI wSUBflWHp6m2kdVc9Hz7Gk3YDXkryFrqnV2GYtiqESWXbzELx1w3/pAzkN3gPZTLc/0p EZus+jjctOBfUFRRNXfT9SjmdTQQIs3lyqnV422l2EWD+b4GNWBFN4YS/AVsLHVolBW1 xsvmXpOeTk6NTblXwGWA0fnostuJEgd5LSgOz2qNB30b5bgL5Ak5b/Kvd/0BH3Fc3mPP zx3GhHmLLiLLNIPqZhX+E2i/dWfItTiNMNu7/zBvEDsd6gy4Vst7jE4sYuFH4YTPNc+U tKcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783440071; x=1784044871; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/PPs4NT4cwHfM8BPThtIIIxetUqnZ0DOvkOSnLEJlWo=; b=ZiO10un9rYeetdOir0lW79jqfGW2/PF8vy5Hsbg+nAKMiIfATj3al1/u5ZjV8+nW+V JHW75qt97Bfhkx+93V7K7zpoG19lL6WHz3xeKLO7Xx2Oc+EC1MGdiHZW2hjDLP5Nut/G 1y0FNFPYjauIWzP8/g3sYCvPvgL1Bfo+g63ln3NI0xs1X2rxfLp23rOgSQRigdHnqzXG bu69lP2Sh9K1Uw8ofErVYEwq25rIecfTMjFSwuXX6+Gr3RYu4vmLJsZwS3gf6pvwtPg3 Ju32biL53Cnh0918b3XEscto7nMg+bVeKDIoA6MRl2e5Y4vcUZJ+qXnORdEzmKCVYBcD jL6Q== X-Forwarded-Encrypted: i=1; AHgh+RqjUKrMISKo6sTn9A99aoBf/gEpT2oE7k6faD1BSCyAW1CJLAFnBj95bu7JgxDgvm+X7zKqTvHr46A/tBw=@vger.kernel.org X-Gm-Message-State: AOJu0YwdDiUHgaBdqKEKggy4UAyoWdX0G3fx5NqkaCmIcrDKTHiKZslx nkwgZhWSnTuUOTwIP3tGM5EUehnghYDNQMmsw0V10W6vBeOQFsXuxrym X-Gm-Gg: AfdE7cnIWymR9LDl5u+NiV7+suYyRKWygnZlg43Q1smsehyjzTygYkr1fpaU6pWHS7J tJa4xgO9DV0eVIzRTFUkWgFaFHkRbpS8I11TCneNKsYGJo+RnBmzMi8mBaibrM3qQXZI/RTZrIR XgdHtwo+RP/LxdFZzZ5ySITcAVcc4jimjiywPqtB+WvEiOq+OrwVq5U2EHxLTgbgUTE4l414UPV mAyCQUAwh0pJqubAqUAcfcz40upQdq5ifUvCBQSwFCSH97N1vpMfZLEsFs0aQgYDDBoFDroOB38 AqVNYVSPVF58LVLpDDNIFcUkgIYEcX7dkJZee0JmqB4ZOsItB/iEyYBDdQKVyMRd7vn8/j3eD2d wYzuEAwkJncxKZtjRD50RHOAjlKyUv69KhOfAV5+jpKLC+0tCUbOgTPTwT6bwTJxC06xzsjlJ6I 17T9TSBg8gxOfURmKiu1ILHQzrf5wK1aqtaryw2QVZx2NvpAab+clgbMUSW6iUvLArZSmPlc0TT cxVmFbFJ8bvFSKoEl+BpEUGnA== X-Received: by 2002:ac8:7fc9:0:b0:51c:981:94a6 with SMTP id d75a77b69052e-51c747d0696mr60451471cf.23.1783440069849; Tue, 07 Jul 2026 09:01:09 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c42038c4bsm114733861cf.31.2026.07.07.09.01.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 09:01:08 -0700 (PDT) From: Yuho Choi To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] gpio: mvebu: Fix optional clock enable handling Date: Tue, 7 Jul 2026 12:00:30 -0400 Message-ID: <20260707160030.385137-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mvebu_gpio_probe() ignores clk_prepare_enable() failures and has no matching disable path for later probe failures. Use devm_clk_get_optional_enabled() so clock lookup and enable failures are reported, and so devres disables the clock on cleanup. Reject PWM setup when the optional clock is absent. Fixes: de88747f514a ("gpio: mvebu: Add clk support to prevent lockup") Signed-off-by: Yuho Choi --- drivers/gpio/gpio-mvebu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index c030d1f00abc..c63cdaa78ac1 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -1152,10 +1152,10 @@ static int mvebu_gpio_probe(struct platform_device *pdev) return id; } - mvchip->clk = devm_clk_get(&pdev->dev, NULL); + mvchip->clk = devm_clk_get_optional_enabled(&pdev->dev, NULL); /* Not all SoCs require a clock.*/ - if (!IS_ERR(mvchip->clk)) - clk_prepare_enable(mvchip->clk); + if (IS_ERR(mvchip->clk)) + return PTR_ERR(mvchip->clk); mvchip->soc_variant = soc_variant; mvchip->chip.label = dev_name(&pdev->dev); -- 2.43.0