From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24810438493 for ; Tue, 7 Jul 2026 17:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783444564; cv=none; b=e7zHVyXdn4tVTBNIht8yh6tXWHzDykikdZL8sOgTTaKNw4i0P08oCnLhB4M9wp4TAvSBlzf/nov8bHF9DBPWVqTitpHEnrZx6KuJY3eIBefIjpY/9IEb5nvlxQjp8PtLZ5p5ssKoR8ajZ0I8zlnkcyoqKMv8cflRe0JPuiEY8nE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783444564; c=relaxed/simple; bh=q26UTZln7vxpVLQUpB2k7H9kOQSzRK3kvbnGt02k2yk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ghTzXhC+GTrkuZdZqM4fnWf+aMe6Y36OJNLIulPyyJbKegUZplmc9aBhHcTZPqsGup9yH1W/+iVLhGKFszHCRSyKA4KO5I2Oqh86sXWXxEFM+3hGn8YVy4jpFP0wfZNDXp14xxKSnGy0kGlQhT+5VnjQvA5IJGhOQPnxME+d2ZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hrNZ0Krn; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hrNZ0Krn" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-8478cc93299so4981806b3a.2 for ; Tue, 07 Jul 2026 10:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783444562; x=1784049362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=neaNKTc1iKEb7KTL27Z88clko1muflEHCUKBETav0TM=; b=hrNZ0KrnKJjuGIv301tCmJnhw5uvLo5jxU2yl/LWaGzYETvmtTyUCC9DDxNurc0EW9 oqE8FtvfkMP/4ukxtuChiiAvd3L18TxngrZ7WwXXKP2s7VXpbfAGF54sJq6p1TdjN+12 eshFymlL0UkezooHdUxLQi1vEdMxkpa0zQmBImfbJT5cXKNgBPQ/ka4i1spGfh2Zyi8G tr3Q6P8SE3T2cNHi/UOmre0U1NcsiZdW/r8JJNsA2lt/7uTsJXNLJscRnhdGck3Jq70w W8yClDh3MLmrkVCDZ72UyuXHWRCyGfE5zwSlPTVI5C0RiJIv/47/YtrFDzxsqXdhCimI zC7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783444562; x=1784049362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=neaNKTc1iKEb7KTL27Z88clko1muflEHCUKBETav0TM=; b=rC2T2IDLFPTe2tHGfwscTR7uAqOrqTFLA7QHmTrujR88CV4OQJYslpQgHDSn7O7Lqd Ogleg5lowN9S9mhc15lUGnB71MLpqo2phYGm09klZad0Den/rxJqgPtuPHktisxhNfUJ gxNSuwMK0FWJnYLwZ0ppSejUblNETTI9mlHVuV7UW8ENhayO5ufPN+cI1Mey3Sx0RrTc jDYWwwVt+ACgpHcWNXL6OuvmBBIH9L9Jk+dhBOFI7MbYUiz/otv5Y+Po6M9nnpFqzdmq gQubur5D924sLV1zhqQxC4D6FerYMJjEkEKgKPZMLBHIVBiCAIPYH6I3SJ3Ogo96lol1 ccBA== X-Forwarded-Encrypted: i=1; AHgh+RoMQGL4KCoCHQWPwNHlP9WcEHwYgK9CC95O2slLi0ZjCtrj35WSpTwHnWaFMi2q/sUujt421gAWlBI398o=@vger.kernel.org X-Gm-Message-State: AOJu0YxyhdvF+gDRmYgHmFs1l0FxOeOY0up425poNGTVV80UmWitviOp T0mjqVSR4gh+VD8Sx3E60zqKOPz8GmH7bcRMg0BTG7K+5PtKb4P2DeZQqGvTSXeD X-Gm-Gg: AfdE7cl7u8Uen1YLaj8/AMWv0wNmmsU9LNg5QORDbXvSrKSWlTu2Foh+1KCYENQ/5mp kuhohDun1T1JCEekFUp2JLx6yLBclXmdZK3RUsuV4aVMesyzVECwPNVYXc9NCrV3vy39uhsNY0R 6EmlXEB4qivxKRuf0W+W0Y3s+MpSnin6+2AS792Wn6P7B2GwPwbX7Z/q5AdXBCb0g6oWLzeE1vz HDemaJ7TBvC1n6d5qtxi4bCyRhL6tGiuENFZNp5ANYMGK8km6Gk4dRx9jxt8eBks9/1pMtzXzA4 kWqfl6ZvEAgndDs/BDZxnEfk+ornOLa0zxpV6zaynslcLIPE7LITiaCdhfjH2adUo/efdYYytbJ Kj68F+YcKZlg+CMdqngNGHFIcYrouV3NDG/sh8akfAWb87gx3rC1cbjur4nR8t535C8PJxS5X7f 7aUEg5NpCMQr3L X-Received: by 2002:a05:6a00:e14:b0:847:84b9:f3f1 with SMTP id d2e1a72fcca58-84826c9f53emr5525867b3a.27.1783444562455; Tue, 07 Jul 2026 10:16:02 -0700 (PDT) Received: from mincom1 ([175.235.236.90]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6b5e566sm5784602b3a.3.2026.07.07.10.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 10:16:02 -0700 (PDT) From: Jihong Min To: Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" , Antoine Tenart , Christian Marangi , Richard van Schagen , Benjamin Larsson , Mieczyslaw Nalewaj , Aleksander Jan Bajkowski , Jihong Min Subject: [PATCH v2 2/5] crypto: eip93: reject HMAC requests before setkey Date: Wed, 8 Jul 2026 02:15:34 +0900 Message-ID: <20260707171537.467608-3-hurryman2212@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260707171537.467608-1-hurryman2212@gmail.com> References: <20260707171537.467608-1-hurryman2212@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit HMAC requests need the precomputed ipad/opad state installed by setkey(). Using an HMAC tfm before setkey() initializes the request with an all-zero ipad and produces invalid hardware input. Reject those requests during hash init so the failure is explicit. Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support") Originally-by: Mieczyslaw Nalewaj Assisted-by: Codex:gpt-5.5 Signed-off-by: Jihong Min --- drivers/crypto/inside-secure/eip93/eip93-hash.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/inside-secure/eip93/eip93-hash.c b/drivers/crypto/inside-secure/eip93/eip93-hash.c index 63bb6c4670cb..060e90c5eaa7 100644 --- a/drivers/crypto/inside-secure/eip93/eip93-hash.c +++ b/drivers/crypto/inside-secure/eip93/eip93-hash.c @@ -300,6 +300,9 @@ static int eip93_hash_init(struct ahash_request *req) struct eip93_hash_ctx *ctx = crypto_ahash_ctx(ahash); struct sa_state *sa_state = &rctx->sa_state; + if (IS_HMAC(ctx->flags) && !memchr_inv(ctx->ipad, 0, SHA256_BLOCK_SIZE)) + return -EINVAL; + memset(sa_state->state_byte_cnt, 0, sizeof(u32) * 2); eip93_hash_init_sa_state_digest(ctx->flags & EIP93_HASH_MASK, sa_state->state_i_digest); -- 2.53.0