From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D75142087C for ; Tue, 7 Jul 2026 23:06:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783465617; cv=none; b=MSyc1zouEMhHJ44nUR9EZVrIu5705zzGC9FWhzv2RpB4WDuptx6mHcamclvE6c7gyRFRAToZxoASi95CzTWh32/kBw3MNmtmC+OmLKtu5Ccpm5/dN4/PIWa2MGCwUPudqnrOeuJdPaKoa5v5Gh99oQIGV1QnLXr7Xy9eLKAwVYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783465617; c=relaxed/simple; bh=L0GHR1v0x7MZET0vZVeu0l8qSN1ZfLoaTOTElTljsIg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JZn/Ufj7zG6MhIrAEboJKx43cTy9lu0wzXXpbDd0hQEqEG/kzko8Z/e5dtwz8yT9jCyU/Mp8hQhoPm2fbbhZed8E0wSqg2iMHG8evB1KNy0DGER5ROe5Il7fnQOwC+XvBB1L8il8RkuX22eEZdhhH9jY0kIbpUtzZyAdQhG/B1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jqtOGQQl; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jqtOGQQl" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-92e5b048375so898885a.1 for ; Tue, 07 Jul 2026 16:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783465615; x=1784070415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=qruhWsJOVl9ibFqHy2pCue9Gd7ufg67PRI0LZgtMksI=; b=jqtOGQQlE6pYJHhFoxEXjvUZxTGHyPNXVLwsOZprgpcNRpomEsHVbHwTuKPJV8PnDs B7Wh2cvgh1kJgPdhs7hScpxOSnvrYe1L/3+rR2YSmZsFVFAZTw2YvbTl+i4snzLstTkw htHpPO/Ccz0thy3jLsutk6zG6yD3igCrFhrl8uEYxtfUVuKNT3vKswgj1dWYmeoBeD93 laVe9qbpqVm7LH8XTqDxGeVEblYPjWLvhTvNLGjTxbRbGkyzEFCxK/9mByYcEGrlXMlP b29va6ZH7Fwwln2HC4uly001R61xdOxMHGXYhXmuzs1ipJ17hiwiiHle12m3qnTOFFzJ SPig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783465615; x=1784070415; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qruhWsJOVl9ibFqHy2pCue9Gd7ufg67PRI0LZgtMksI=; b=cgMdmdKZFctONhXRHGz2wp6CFRF2myzDAlvEEypo8d9Trz8umLSW0mDBA0bsruXZN0 rP0gPOSv9KVaSJvGI9hvVbQIwtNcaJ5YR2Vb5i12q1kQU6XwJr6eVaoSytvNfJtoYIcs zs+AaciUqwOjZZ2Nc3tETLb0ePBHO3KLZzMn1PEkMNOUOu5ybc4g7l+7dyTqHKjHL528 GkRT9pp6lsD3N7PE/lBJO6zanTnBa49bHJe+Q9TATYqkBDGMVWGSHRu6cxIwTRQrlVq5 C14K5/xxRZYQZ3s0y+ha/5GaLD09cYMA2St+hbVDMjEiffJjC9iipI7q/mBgAX2nT0uT AmXA== X-Forwarded-Encrypted: i=1; AHgh+Rr2+lU+eakTsIcaXRrV6Hu+OvAopGsglZcSkwGr15dFlbB/ZR7lzSRNGS+1twYoVH8+rM5+26OR7FGTrno=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9KC8MiOWJEO/QP6Eu78obx9cXRKJ+MBkWGXhvtLGJAG6ql1wn abLHKWH7/Nfu83Kr5IbNtilCou9sGGQkkvg7FSf6SX3F3JSIxbBakHyDuqKHRe0I X-Gm-Gg: AfdE7cnQQ8xUtVqIYmI9mQhU5H5YyFm5FczViGyhplxZUBAb0175+BCwwn3uHr9o32r MQsfSwd8hI4FPzouHIMpBc/xQa/UHlHUKOdPCF4fQahPV1JHCLLfruXRWlYEK1+g+LSPaQ4TvDm T323WI70UDA/8iciQ5OMGTlS6Q7Y4hrrIsoMwxaj6Xlkjbxe118VVTGMDeM9YdDbJ35u9LUvOW5 CEI70HTLipvcyVIu/f8kmdiC0B3K9QU5jRtlQ/XtHj4vo78NfwjUXajaKdRxvcfi0uyYfLOfA77 KtpjcWz1C08AbdBiWQRCwaoeWm0p5NQMM5eLnlmn1+UoMPrukPj+2PF7NUSNWZ7hQS1xiIAcqBL raG3lRI7X0KZrXdbP59x/3jqiBB+vZyhESQFOKnBbynIbj/zMG8wV1Bn0aajhPea1j+O8bRmoTh 4jgIy551Ra1CATO2TcR+3keyB+QlE8cK9lLekmbBbHFprAvfkvtJyWqsPgQdnyWNmjVJWyl3U4K K1mvd4Nnw== X-Received: by 2002:a05:620a:2720:b0:92e:7d53:8e8d with SMTP id af79cd13be357-92ebb4f3500mr804914585a.27.1783465614937; Tue, 07 Jul 2026 16:06:54 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92e90b804dasm1269924285a.1.2026.07.07.16.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 16:06:53 -0700 (PDT) From: Rosen Penev To: linux-gpio@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Andrew Lunn , Ralph Sennhauser , Thierry Reding , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] gpio: mvebu: use devm_clk_get_optional_enabled() Date: Tue, 7 Jul 2026 16:06:51 -0700 Message-ID: <20260707230651.1138887-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The clock is obtained without doing any sort of cleanup on remove or anywhere else. Use the proper function to handle this. When it fails with -EPROBE_DEFER for example, return so that it can be handled. When the clock is not found, it's NULL and not a PTR_ERR. Handle that as well. Fixes: 757642f9a584e ("gpio: mvebu: Add limited PWM support") Signed-off-by: Rosen Penev --- drivers/gpio/gpio-mvebu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 329275d6518c..cdf7eb46ae5f 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -833,8 +833,8 @@ static int mvebu_pwm_probe(struct platform_device *pdev, offset = 0; } - if (IS_ERR(mvchip->clk)) - return PTR_ERR(mvchip->clk); + if (!mvchip->clk) + return -ENODEV; chip = devm_pwmchip_alloc(dev, mvchip->chip.ngpio, sizeof(*mvpwm)); if (IS_ERR(chip)) @@ -1194,10 +1194,10 @@ static int mvebu_gpio_probe(struct platform_device *pdev) return id; } - mvchip->clk = devm_clk_get(&pdev->dev, NULL); /* Not all SoCs require a clock.*/ - if (!IS_ERR(mvchip->clk)) - clk_prepare_enable(mvchip->clk); + mvchip->clk = devm_clk_get_optional_enabled(&pdev->dev, NULL); + if (IS_ERR(mvchip->clk)) + return PTR_ERR(mvchip->clk); mvchip->soc_variant = soc_variant; mvchip->chip.label = dev_name(&pdev->dev); -- 2.55.0