From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B09BD36DA0D for ; Tue, 7 Jul 2026 23:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783466865; cv=none; b=JpE+/OSh5/LSV7DPklizlJAXtUf/yKZQI1pNuDO5S4bP9K+jNOunG8va9wq5WXaZTMKrkmXH5bC05xVwCS21tHdsHpgGvHZavuaMuaNAVoXj/jPbygmgWnS9As8L+bzZjHkH0zpu04T3q5Va8x6X5mviJwMQRutjlqygQNwYnsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783466865; c=relaxed/simple; bh=AuPR1uwOLUSQFwjcJJ4K3th8KBDVPHrpowVtJO4Vpg0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AjHpklfD2Mg71oCJJp2Vsq1F+EFwDwcMIhzPd/5xHCljizysrlWWgrVB9grX4fBJlGMC5Ltqhv5Klr3R7iFOk8wz82TwAXsjAHRCUyB0+NagQ1v7rN6kikzra7nx2pRM3w0rFuEPhMKDQXs4zx/yculQWCaWKddNP5CcmKi3r2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Iv7PKR7N; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Iv7PKR7N" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-381891a9525so105602a91.3 for ; Tue, 07 Jul 2026 16:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783466864; x=1784071664; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0MuI3fNAXQLRgr1KIzV4kPib8genOMI7jMqph3Gw2/g=; b=Iv7PKR7NsfOsUcpeRAhd5u1kTKKmaEoBAakNdoUkh4awB1nb4BJI0/jjax/DUCzOO2 xMpg3rDxWLq2ExAYLCGkABuMuv3SeLUpFm6xUkG6QA4Hn1N3OaBGWXl6FujP+jmk0SBO PBZGAS3UUe0HIkoWUXdBFJwgfz0LQV7c8UWzAtzyHFaL3fLcPBQkJH746LGZXzTbgzlP 0aLmpfBmHqRkfqcKE9o7RkcwU+fCYxrMqfvqsQADH0/JcehTNk3SVpua76PMJe763pyH c+iXM0pKBMiFqQ/Zzu7bWRb3g8KnMFylW5CcpX7e4XEXEXKK1y7vaabPrhDZ5866lccH u5AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783466864; x=1784071664; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0MuI3fNAXQLRgr1KIzV4kPib8genOMI7jMqph3Gw2/g=; b=s7La2Z0Zwy9EvjP4ph/rO6mr658jlynDPlftmJsza55SAI1fiQgCyNrzhtVx2+KvXp 1ZIUUoFV9qflXcCtaSdBy4IMUXBYCYeaXx0f4G2fzuW7KxiMah2/HaEJcoLobGZ0iQxS zodBFFX8PAg/6D6VJ3U/G48mV8JXWDIBRJnmY9VXHm2XDJoPspDIoYQenglCAWaqujy6 bBkcMZSDJ6C6OIHlWk8eE8r3JzD8Gr8p7Ns+K+7dK9SNtruY1Rs0LF2pkkASG5dhcaNa iI/ljNSBlmieSBtSYuEdK4Tbyg1um+mqAob8pcX1/p6FF3w1/KyqKWAU6v4tUmxLCkvA 00Wg== X-Forwarded-Encrypted: i=1; AHgh+RoJNyip0G+xbu2WSjXWj+vMoPN/QbSKiay0dvOB+U21ekExccBkWMBwQPfNJ0pqfISPsuRE+hc8Y1x+h8I=@vger.kernel.org X-Gm-Message-State: AOJu0YwdEwD8gVyg8vLcQSCBRxREyhVXSQ7bXiDcRydfJyY0traEEgv6 PFgIh5iGTUDghPS+6EA06byk9ktAflk6yhEjdrU8qrdfUJZ+Fnhov07tGgEONb7t X-Gm-Gg: AfdE7claBLYp51Ooy4WHGi5tVSjKfRaWgYPT/Jg/KNSWNqe4AUFPLrnZioi7zAnvm2H HygAV1TJReKGx0R9Oonqcn6AZ/Cae5FmHTQLAf4k9Mt+nkTk08mzdERRAW/r1EtyKjrTxr5rma8 TZ3eXFagamrajfrIbMhR7IMTMNS7tAALtO8I788mj0o8FfeWwpxP1GYurebuAdTBWrKnKuhIIdv mvg+XYfi0DA2FkmjM1KXykERztQBHDw8L47hW9mvCSfwj3LqYcgTh6zzC/4aqkZmELQgZOpIWFS bKWwPC/FEOm7m/bTud64mGBQW1EB74+3e/0xbq2keaSQcuHqge+sNo78Ow6zHL53zro1jHIoaIp eOxXUBql1Mj4CGi83O2Uj6s9azGFCxq7Sgjtswowwbva3pHY9sccsWUUvuQrY4iVmtDeuCHd6Fc tVEQCUXq54TLOemCD4y40Dnn7ab916BhE2lWLFLKV97hMG/+VI5+8yt45hzwEwWK78DYbbgKWMp pYczo/0mQ== X-Received: by 2002:a17:90b:1809:b0:37f:9ce1:7366 with SMTP id 98e67ed59e1d1-389412059eamr1985a91.28.1783466864063; Tue, 07 Jul 2026 16:27:44 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d20a2f2fsm1847392a91.13.2026.07.07.16.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 16:27:43 -0700 (PDT) From: Rosen Penev To: linux-gpio@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Arnd Bergmann , Jason Cooper , Thomas Petazzoni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] gpio: mvebu: validate ngpios before use Date: Tue, 7 Jul 2026 16:27:42 -0700 Message-ID: <20260707232742.1235008-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If ngpios is read as 0 from device tree, it is passed via irq_alloc_domain_generic_chips() as irqs_per_chip, which leads to a division by zero in DIV_ROUND_UP(d->revmap_size, irqs_per_chip). Reject ngpios == 0 early. Fixes: fefe7b0923459 ("gpio: introduce gpio-mvebu driver for Marvell SoCs") Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/gpio/gpio-mvebu.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 39c1a13e1b65..c7cbfbfb4800 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -1175,6 +1175,11 @@ static int mvebu_gpio_probe(struct platform_device *pdev) return -ENODEV; } + if (!ngpios) { + dev_err(&pdev->dev, "ngpios must be greater than 0\n"); + return -EINVAL; + } + id = of_alias_get_id(pdev->dev.of_node, "gpio"); if (id < 0) { dev_err(&pdev->dev, "Couldn't get OF id\n"); -- 2.55.0