From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013067.outbound.protection.outlook.com [40.93.201.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 458603A63FB for ; Wed, 8 Jul 2026 00:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.67 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783472279; cv=fail; b=qBzlnrQk48nwqGKz3Zjo2/9L5uPfpzKQCV7OR1giFTF6iBQvhdIbgDZAvD+wQjPdorNYt4C6NptvMcIT6kggf5rtkxHsYu2d9mAc2Lh/Mlm8R3fWDr4ynGMM/p6ecicbeLLDq6zj2jmWLdM5SqBugON9IThFVDAOdfhOYKApO5Q= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783472279; c=relaxed/simple; bh=IMx49223S/WLbqHliskKeDtweAxSzvUT4JYJ+VzO2r8=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=j2y1ZPdLYuAZQyLdxg7M8IgMd4ohckJIGKFhr6FtyOYguEFwGxWYFee7FfHnbFLu20XHmbUXNzuQ4ZCKs1DJIvRyZBHz5r/jlrzqUAPhqCP6AeRUjmIQ9bfzaZFFk5F1AGsFCPRhwbvaxDvtdHxCY5+j2KoVUEqQMAvUdfcV6rA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=l3n5s2yS; arc=fail smtp.client-ip=40.93.201.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="l3n5s2yS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ep6uEoZ3JzxHzoQTNw8WYxAPg+hn0bRqNAFCyYggkIVJoHXUZkzhLT9/EG1xMde+8ODi6JpXwhqdJ702CkZY8/5sCSrv02+aQZ9xCNdFKSmcN0jAiFAOtCOuViGxz352zJTAmATPhKIotGp3yWAQ16F+3rAYpa5XmCvsDdJr/IdD0MnVk9UQAFEA7bPaEYk5LupSELCqJSa5muPx6yXkDXY/qAaqve0MeKoz6ZKXMY0IWKChSC3gO0+HzV4FlW/1el5eP+RlqjkcqlsjQp91wogeObbvh8Zehu9bLsmu5c8e5KsvudxlBX1wuq2aX9q3QjPeBwY0G5hDzu10JD7N8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=23m56iZn1MB9t0Y4oD8PA1MUIfkQs2vORVV3sD6ibmk=; b=shuutqmtRqFY2GrItLJy7bnOAYQKTn85ETUSN5jq63y9DVLiS32ZCdyLD66Lywu67gnJy+cNKkWY5gjOtaVBboAsvvqBtGWfHy8+ueuX4FIKW0VUl7+c2z5M/LExHmXHugOf34zNL2C1fI7k1+1ZlqYnywHffi5w+La4wseXCNrioul8ZTkUsxzDIw15FB7jFSTTUXRhneKaXzU8n5T4i9LP04SanwtPdUOoPqluUkgxDxj0NaDee82vV2rtNqY4A2uTPH2e8jl0wDAW8IJvvGqx+W23MhJPIPswAlyrQWhLTncWH+xmd+u0Oan8+zKwg7QFiPN9L4brcTFKvMZc/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=23m56iZn1MB9t0Y4oD8PA1MUIfkQs2vORVV3sD6ibmk=; b=l3n5s2ySkEKETjGy+FApFgBjb0KfhErEfVs+xnDKuXTDA33u5p09UZHgUdqvM/sqSiObEz+7NDAgXnOLxvBzaTBMcPViIjhTvy11cdUfJP5TbgvmpQYEmHqZJPhtXcgVpD9SzXcKNYBfGynQ2hVt7kdj5fz57GDspTJcYsGW5AdC6nf5CoN1LthHTQQsGi4DVu/OvfpLNgyRehZoYzvJP4w5TruclgnlTh12SyoMlRcU3EOsBInKYYZ2Ug/WuRZPb4qghAb5r5scKIcn26AT9U3xvTyLlgcNvJV/wxRK2AigcCd2uZkZ7xh5tYpjrj9CtFdJf3SDwecQDCvSGZizRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by SA3PR12MB9178.namprd12.prod.outlook.com (2603:10b6:806:396::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Wed, 8 Jul 2026 00:57:48 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8%5]) with mapi id 15.21.0181.009; Wed, 8 Jul 2026 00:57:48 +0000 From: John Hubbard To: Andrew Morton Cc: Alistair Popple , Balbir Singh , David Hildenbrand , Zi Yan , LKML , linux-mm@kvack.org, John Hubbard , Sourab Gupta Subject: [PATCH v2] mm/gup: fix GUP-fast fallback for NULL-mapping order-0 folios Date: Tue, 7 Jul 2026 17:57:45 -0700 Message-ID: <20260708005745.164928-1-jhubbard@nvidia.com> X-Mailer: git-send-email 2.55.0 X-NVConfidentiality: public Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR03CA0270.namprd03.prod.outlook.com (2603:10b6:a03:3a0::35) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|SA3PR12MB9178:EE_ X-MS-Office365-Filtering-Correlation-Id: c9a1d3f0-0a06-49d5-0fe3-08dedc8beda8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|366016|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: FaBtUXVQORKBvOe8tZ+PBsJwv9KGR5OX0X5fbs+ABM2zqljAc9KWTzucsRvrVhleq6MKBd7BgDO2VEJkE+3A4qSUbpI2JMGfhC3Cl2/ltKL5HtWNNoLIPrM53fiA7qMJD8HUSyYzmQfZoI4Cn0dNK6Xuz92RCItToTEIrMMe8zXUxwg8oYfAfPZEoap6CHQEh2aSYelIdtX3gCjWV2Zm64dnRxdX7Qbb58e6aARUqj3ZWmLSwG3W7Q9aYL44mTK0qwrpiY1KhpEBDoVn0/Hp0/WQgRZ7+izLM3qt4Jp0NEdYcOtKYKlr1BHYtEg2+t6lKLn6z7mBhf2/NIghpnDwoq3BS+DrM+JNb8pl5/JS/fQ+SAWsEesYNe0zkqGtk/UGVmpgav5bepU0+55z1DLDcT0HjD4FBqSW7AlDtb5z45Z4J8/2UTbuxxtjiZuoQBAsFxVw7HYUJWN3BsYr9yv1Iw619//oj5rINseW5vaeHH0SMUYAndixHkPtp0RhEnizU0+Ua7KOCm5nvnbIrwDfD3UTV+LKd0/yM7Tr2ZjTWOc8UPbx3pZFYCDneF9SjA1ik9lX8LmlUOzvmwvV27oYJbGJdVZ4xY88O1rmvD5kXNXC+/Fhm15QJbrNXCSioBY4zTrdH2FYY/g0z0jfrw1bk0okbobunuNpKNOI1mGh+Vc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(18002099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O7D9IVU6v75Y8ZbOLNwpwo2sJ7FGYXUEj5WtqHEVCbEbpk3+8TptiFXN9/Pw?= =?us-ascii?Q?8BlNYGb6WQt4iVixdLF3x3H/uSpTTdGIeHfpyP50IApbTkCLOTCQ+UKHjP9E?= =?us-ascii?Q?TQCwY3hndVoubJUFZsKRURg73Q9wXZEGejxaqsRoOp8Vg8BsS66lZQmA9sTT?= =?us-ascii?Q?27BtVftRjiwUVwyRUIAnNlM1W1QwLb56rMpbX+Yj5vDIdQiY4adO3iGS15SG?= =?us-ascii?Q?MWgkMkPAtAIwoAVD1m530hsUBgfYbbMwZimOMRfIZVZ8pu+LY639saGcgIo5?= =?us-ascii?Q?1d0/0IB23Cpfv0os8YZ2KEaSkWOUmb52Yt2s+ef9mcuSRyxcQhfmKPJ7zYlw?= =?us-ascii?Q?2ouyUmNGJ0cjpVTlaorb9w+4KQew9eKbEAsq4jfGAy1iisTO1qCge4Mthhnx?= =?us-ascii?Q?xGeWLBVbSBxZ+oKh2bcsV3jnHN3Gcy0Ywx7HJWQlP2Dnv+sHuEZlROqUizM5?= =?us-ascii?Q?UMIVFaEmja6+Bu7OhqIePPj/cVgyszD6CMnpwDuz4njuQfS0/L9Tn6hO4MCn?= =?us-ascii?Q?cyGx9SA1ln3aum7gz7S655AsjICoCpOgCCfXH2yJlNIs8Qd7Vby/2/qEC1Ku?= =?us-ascii?Q?XR+upSZiEdnuyxukJQMePS8uPknHPxxgB0u60ItAle0vjSxW8KPOs3rueoR0?= =?us-ascii?Q?4JlJDpAP2pLNM5x8m+oYpIK4FrVTWANEIDFxdKgGjNRlj/BhRzngVt8il0o3?= =?us-ascii?Q?brkcIJ1GfgZ8uTtJows1w8bof3x/u/vU2CVk4NXaHiv2r7hBOzqyMZ0fSSKe?= =?us-ascii?Q?FwXx2upuWbAuXmBMyUS1kvvXntblN/dl5mfBWef8SidRi5+wDDR9wcjiMB70?= =?us-ascii?Q?tgWRCbyLXFglF/qwSD5jaQK8ObvH4Y/wnY37Sh+5Aah/w/gBGTCa+PdoUlTB?= =?us-ascii?Q?k5nHJw0WD/F7s9XiCiXRmfyGh8r7ssPVr1uBMYY3xpUHCqC16ij1hrOJkyPe?= =?us-ascii?Q?SFRsEs7g7NPAUNBXtOj4v1ITV3vuVB0Byr1qDUelOmuvfKoxBSfqwzG5MmvF?= =?us-ascii?Q?Cuom7YJ1N4TM6g5ASsFPhoZZKvGd9v/9dtvJ1RXRD47JddaOZV7rnP/d8qev?= =?us-ascii?Q?1KWoO/LQtOMuyw0PRqlDMH+LQ66R5BcdCIKh/ANAfOX9qAmhg7Sy7dKpvufQ?= =?us-ascii?Q?sLBWRbFRAe/NE8KEhNns/RNwBt9k24B38lE+SA3cyFoo651G/VOZvgenR2z4?= =?us-ascii?Q?YJvNrw/1slT4vG02eQM4y16bidUALLghBvNIfLa/K60/cXEcFSG1McQxBYcA?= =?us-ascii?Q?Jgm6yZYOmheFFYu9xHDqqDVYy3g6wATfxsFu9GDvdQKhYgh5QAL5wouupr6l?= =?us-ascii?Q?JxYYA4tT/jwZO86B9uFHLa3ZkL+OJDGcgij6iclTLfHvKOfC6c+gsl45ho6X?= =?us-ascii?Q?Xraq1xngQ3Jj6Fv6oujnet7ZgDJt9g3NVx2VSWEQ6G8b7U2NYpazBlWN7n9c?= =?us-ascii?Q?MUfezUb5CqpzZUxuz53pCIK3d3ZHUKMqKNH+YkXg7TOEZYjGtOgPIzF/c6pc?= =?us-ascii?Q?zXPtCvvTsvuyyqE7jkxpYlmO9MCoQqQMb3L4uFHNTzC3V4LjKER5wRTZoslk?= =?us-ascii?Q?w9zWt2gY11qs4ArfYJ+U55R6TadNmn3LeZq9D2gwKhn41vHvEesW9kybFA8j?= =?us-ascii?Q?teeaMxChPvGTw3u5Y+U3MTdXkmVA+iGFoNhUpGQC34M2HRB4bH9+DW7WRq5B?= =?us-ascii?Q?qUK1xxrnoEAHu9uI7Oto3tT4zRFvod8T7EJfu/iO+qg61JuANJEy4WVMYtsj?= =?us-ascii?Q?3b60GABkKg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9a1d3f0-0a06-49d5-0fe3-08dedc8beda8 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2026 00:57:48.0664 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ebE5ajHaQkBvxLOMIq62I8gZ+G7bPQIX33A78koGZOmeEAvNx5ow+bLD9wg2f92HMah6BwWYmhgyz9HNXABQDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9178 Since commit f002882ca369 ("mm: merge folio_is_secretmem() and folio_fast_pin_allowed() into gup_fast_folio_allowed()"), gup_fast_folio_allowed() falls back to the slow path for any order-0 folio with a NULL mapping when CONFIG_SECRETMEM=y. This causes a performance regression for drivers that allocate pages with alloc_page() and insert them into VMAs via vm_insert_page(). These pages legitimately have a NULL folio->mapping, but they cannot be secretmem pages. Secretmem pages are always added to the secretmem inode's page cache via filemap_add_folio(), which sets folio->mapping to the inode's i_mapping. A folio with a NULL mapping can never be a secretmem folio. The NULL-mapping check was intended to handle truncated file-backed pages (a reject_file_backed concern), not secretmem detection. When only check_secretmem is true (and reject_file_backed is false), a NULL mapping is sufficient to prove the folio is not secretmem, so the fast path can proceed. Tested-by: Sourab Gupta Fixes: f002882ca369 ("mm: merge folio_is_secretmem() and folio_fast_pin_allowed() into gup_fast_folio_allowed()") Acked-by: David Hildenbrand (Arm) Signed-off-by: John Hubbard --- Resending as requested [1], with David's Acked-by added. Rebased onto the latest master. No code changes since v1. [1] https://lore.kernel.org/all/20260409014647.397515-1-jhubbard@nvidia.com/ thanks, John Hubbard mm/gup.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 0692119b7904..99902c15703b 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2784,12 +2784,17 @@ static bool gup_fast_folio_allowed(struct folio *folio, unsigned int flags) mapping = READ_ONCE(folio->mapping); /* - * The mapping may have been truncated, in any case we cannot determine - * if this mapping is safe - fall back to slow path to determine how to - * proceed. + * If the mapping is NULL (truncated, or never set), we cannot + * determine whether the folio is file-backed, so a long-term writable + * pin must fall back to the slow path. + * + * Otherwise, a NULL mapping proves this is not a secretmem folio + * (secretmem folios always have a valid mapping to the secretmem + * inode's address_space), so in that case, we can continue with the + * fast path. */ if (!mapping) - return false; + return !reject_file_backed; /* Anonymous folios pose no problem. */ mapping_flags = (unsigned long)mapping & FOLIO_MAPPING_FLAGS; -- 2.55.0