From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 012A23FA5EF for ; Wed, 8 Jul 2026 08:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783497688; cv=none; b=MPwPyol91kwKcjtAyZE4nqyZqo6LcKfRgu9cMIxngo4zAl2SWrvSm1Als2MQcpakqRY0uT6aal0drcOkbum1hg8a0SSNEIfI++p+0H46ZIeEsx5OCq7wwv+hSF+BkvidJUh5rR2g1FMciSqcSuHXPokIkcHHyM2NtSDp31keAgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783497688; c=relaxed/simple; bh=oCj/Y9HazWtdC/Gpu4wu+TTA3spncCFeU6du1BuqbCo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eSmAw4rjro4x1RPMXn0peHT9jqOtY/V7yscbTF+ChHGmqvFN6pS8HIj3yVTwhLXCanEYAH42DXLc5WR7WIwrHY9Ic8UDH0mgfPMARJvos6htxyrkJbX3JPh7fS2Zv4pBk6peMY5Z+6OiaHOD3XcqpjBZFrhv+9YF/OqDRQEnq2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l3tTvL6E; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l3tTvL6E" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2cca0c5799eso3236725ad.0 for ; Wed, 08 Jul 2026 01:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783497682; x=1784102482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GSvkn80MrAt5cl0VSMEKjTET3Rwq+Bm6+Heg6Nd7va8=; b=l3tTvL6Ew9fXFGZiEGOiOiFH9HXiF1a6wpuhOSs7SVGkuJkFylApkAEbCSerykxtht 22UlDsU6OJ969omVjvdffUJa5pfEvBiOMX9DspFdheHfMSFVZ8kHCdelOFScxilxsd7K GtfUqJtndJnmRao/03T7BviaZMkpkQYV0m1hlprTL2rFdMkqinlEMsx4mcquP7hzQ4kw 335/e/Hixa66KHBRaJkcZeUDKNm6wzUA2dkCP2W2OdZsk78+X8Y9cYeTyu/AsS+8egWa dEtnGoj4M/EoSLvHSu1ZJEyRGMBdB9+cDiqU8ytAd42iY2T2cOZ0e+/1A2p52TsPqnob zn/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783497682; x=1784102482; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GSvkn80MrAt5cl0VSMEKjTET3Rwq+Bm6+Heg6Nd7va8=; b=X+KAVjIKO7fSd/2NE0Jfi/3H2Ty3HjeQhZCOZ4jMb76AxLeG78qtuPXvw/L9RGlq61 jpMtxuiJH59iV/K9eUbek5fyru61RRYiUuWFZ19kxX9oGITWbj7qSc0+pfOaDjXrUMeN /beCtN3fdjNtidEps+fR3FHO2vIbTe5z/P2VeGrtFd4EkW1JMK0EhXm13iYT1IIBT5Qu mY5nI37jlFQki+hgxSkAMSfesdpt4W6K9ymQZEQwUGPMNfTIXeza1Mq5aJZRU3ewtUsD 4vHW8tCsYdT2Jl+mAvPQobQ/Bpw66zIiyMpNz9p4yWjArfl3sPxCsja/7P1YBrJKnYS5 x8Gg== X-Forwarded-Encrypted: i=1; AHgh+Rpyw/edO5hQDF0pZubha9Uxg2VgpNewCln+lef9GTzZf2jw1TPmvTOQor+2Pr84w9ETm3Six2Aridi/784=@vger.kernel.org X-Gm-Message-State: AOJu0YxKsKPql80Fh+b2TVbzAGc9rW+q0109qyxVp6aiaptgqKowGUJt LaRlEDEBNMIUWS5u6ngBRSpZCftheXbKs0oxBuSGFdYRhR+oCtNKJU5K X-Gm-Gg: AfdE7cnZG1JdoHUBA9Q6v9mdT4mjAjdFuGAK+55AwmQn97yfYxJ9lYMCgXq9cfOYrZI +fFMNiv8dwgMTysHCsFTvEvQa2DcLAqPW6YUKxPdBMnhgT6LIsYqqLDnPqyKMHchfZpedOUIOd2 9MQxu70VAHbhLyZT0VFPb3qI8J6iuU9C0j7JFDpiUWWy7F/IKOYs42YU3iSHhg1kO5ZdMVunRXl cKRcu+k1uGgaBuQFkQ4RsUFUKdQav2SyG512GgHHva1bNbxdv7ZfVagrTFvdbv7JWRLQX0MCeRs 6/emocB1J5tW1RZT2yIhVhTGjK+UPa+b9RAE1svJA0uBctp+oKfn8kLIv0nIV3qW+s9b7V/k0Cp Ul25r6J70P18qzAbn2IOTdylCxw+LI6vKXpqYFw8LG0PAFs11FhMf7/LGrnTQwu4nAmOnTkh+Nr wIdlUY+/8ew3Pkzg== X-Received: by 2002:a17:903:1247:b0:2c9:c952:6e9 with SMTP id d9443c01a7336-2ccea373186mr15894145ad.2.1783497681729; Wed, 08 Jul 2026 01:01:21 -0700 (PDT) Received: from lgs.. ([152.32.214.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bf77e4sm23942245ad.22.2026.07.08.01.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 01:01:21 -0700 (PDT) From: Guangshuo Li To: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] mm/damon/sysfs-schemes: fix tried_regions setup failure cleanup Date: Wed, 8 Jul 2026 16:01:07 +0800 Message-ID: <20260708080107.727043-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damon_sysfs_scheme_add_dirs() sets up the tried_regions directory after the stats directory has already been created. If damon_sysfs_scheme_set_tried_regions() fails, scheme->tried_regions has not been assigned. The error path nevertheless jumps to put_tried_regions_out and dereferences scheme->tried_regions while trying to put its kobject. This can dereference uninitialized memory because struct damon_sysfs_scheme is allocated with kmalloc-style allocation and scheme->tried_regions is only assigned after tried_regions setup succeeds. On tried_regions setup failure, start cleanup from the last successfully created directory, stats, instead of trying to put tried_regions. Fixes: 5181b75f438d ("mm/damon/sysfs-schemes: implement schemes/tried_regions directory") Signed-off-by: Guangshuo Li --- mm/damon/sysfs-schemes.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 329cfd0bbe9f..0668a0e53971 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -2516,12 +2516,12 @@ static int damon_sysfs_scheme_add_dirs(struct damon_sysfs_scheme *scheme) goto put_filters_watermarks_quotas_access_pattern_out; err = damon_sysfs_scheme_set_tried_regions(scheme); if (err) - goto put_tried_regions_out; + goto put_stats_out; return 0; -put_tried_regions_out: - kobject_put(&scheme->tried_regions->kobj); - scheme->tried_regions = NULL; +put_stats_out: + kobject_put(&scheme->stats->kobj); + scheme->stats = NULL; put_filters_watermarks_quotas_access_pattern_out: kobject_put(&scheme->ops_filters->kobj); scheme->ops_filters = NULL; -- 2.43.0