From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54CE83AB260 for ; Wed, 8 Jul 2026 08:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783498515; cv=none; b=pS0wfHzMCdD8c935izMlkuikfBaOHkRAxjFjNtyeqLQHMkdG4X40GgUgzSJrM0q4RLwjO7haajxU0f8P9wSwv5UYhvjogjLhnllq79vzeNg0x28wzD7PA9ARW35TaYCduHuuQ4xGvVsMs3joDFebvewmwZ5RP/pNKnxj2oEeH4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783498515; c=relaxed/simple; bh=QT/YXc4UscEkkb5ySweowNL87VXojGz26TAgU6hu5mw=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=aH+qRsOmjccQ9r0pO4QbOaM1u0Pcw63avoTJG7ekfkpYuyO4jZ6y6MP9XvLIuCxna0NrgMlflIQp4MPY2K7MUVCXAIzpWcw5IkkFGibOr+TQLNila+XpUvpwIk5QQZqMRO/T4X5lkW+AjH2WrljleUOO1rZDc21L2gBaIwvBqNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nFdgSAhg; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nFdgSAhg" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-37e0a189b0bso331057a91.1 for ; Wed, 08 Jul 2026 01:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783498514; x=1784103314; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZbH82DynMh5IRVn3HwwkYgwIRHz/+MBq3cLHIEXoxR4=; b=nFdgSAhgvgzqlRa76+BboD5yPudJZBXuc/DzoMV+p9zeVcPjf17ITACiPqUa3yfqDE VSvJF1oAttCoVtuvTTE9ZWMlRMBBi2qPTfUSnSiAZpoUCk6UvQh8AToyQXd+VpA6KP3r eDC1ggOlMPJQPL70SFXekcSJQyg6bjOO4WfNwnJiN6sSatJojL1hSZKK9OcK+xpoH9Un 7Gd6vd70PKgkzw8SA4ptD6cYUj22PTAcPn2a7yiJ72YpiqEZK85+oqpSxVC1mCW4/7GP WYYbQc7PYNmFCrFBaC8zru2qEKj7qYPtXeFVRn9aYxapyvvb7+nCpbCmAIpag3fML5hS eAHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783498514; x=1784103314; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ZbH82DynMh5IRVn3HwwkYgwIRHz/+MBq3cLHIEXoxR4=; b=M6L4dnb1luZF7zDTYLtI+GmoMl/wVJu8fdOsDtWoMl+4Jfr7XUC6EfB1/dlCy7CIgk RestxA4fZzggaYqI5EkC2nyUagep/n49kJNzCMttmXxtTQfiIo9hi3PvwrKa84q3HZsl iH7uPByQk+vtF/Mtl3yWkzzmrccC4V2HTgrHh0FIEr67qeO4s7sNwDUWE71JSZqUvXaN 46wZdcScUdFFvMbTWLMYwCJmcD/l64hR+cok3VaPKMEDDY1oqKfB2s9RnF6BHqdU9nsw U22AJ7g1rlACVpBkZm6+BnffHcgY5rbzMp0uuSFSrzTQeYR2T0/wLziWLR4GWR/Z2rgj JEPQ== X-Forwarded-Encrypted: i=1; AHgh+RqtryIoAuBvz9ub8uhlkfa7I2V9Qs+B8/YBB6Y3TJo9hSiopnaohzMlxwqUU00zJ2uKVlETLx+k/vtn7CM=@vger.kernel.org X-Gm-Message-State: AOJu0YzlXrmh5DT9ichcBY5lTd2TSIz5JVgUI1xBSzPc2W8qqjbVV1CA L5J6M9bAlD4w7BXFk//ad3ct+jVT+Q3RYltq9p3fvTZHtk/oPWi5Aq2oYLG2rXtAxrA= X-Gm-Gg: AfdE7ck5OpPUM5TMkX5BnlYRnkZw+JD2zO2vhXqzviR2arIiBqL8XYse2BMGIS9PF6m rZpDLElzK1XrwtRiX3WpgyQyrIxEx3SV0u42N5QdC7Y8ltcL45HVPXNqDXp3ePmRkvHYdRV873R qjeCLL6HkWnTdsb5iDb2cff3guzB4qFiQLkIebgtU7Wa/rnjDIGuVj6ZekKj7k2WczX8kUiwdA2 s2CvjnFafnbnv3QdAxwUsiLkqvYdwf3G4jPt70hb0OlQXLuoKmlzxTlQmZ9dNceAxLGxyuNHfgo 7kDc4vq5UI02Nc+Fm1wlB9cuQ+Swd3GguJxqKQYjzQSr+m1A3k+Zmkb/h0Z+u5YSOxMDI6ZDum7 DJ7gto4zvaFa8FFdR4VqINIgeIiEBes/oNHOSctnUOaWR9/5YeWkWlkV9jZC1IqCbH7kORCQ= X-Received: by 2002:a17:90b:4c:b0:37c:8628:f79e with SMTP id 98e67ed59e1d1-38940248a3dmr1509053a91.16.1783498513676; Wed, 08 Jul 2026 01:15:13 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d20a361asm2337241a91.15.2026.07.08.01.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 01:15:13 -0700 (PDT) From: Guangshuo Li To: Vinod Koul , Neil Armstrong , Johan Hovold , Guangshuo Li , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] phy: ti: omap-usb2: fix OF node leak at probe Date: Wed, 8 Jul 2026 16:12:54 +0800 Message-ID: <20260708081254.734892-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit omap_usb2_probe() parses the ctrl-module phandle and then looks up the corresponding platform device. of_parse_phandle() returns a device node with a reference that must be dropped by the caller. The driver currently keeps the device reference taken by of_find_device_by_node() until unbind, but never drops the temporary OF node reference taken by of_parse_phandle(). Drop the OF node reference after of_find_device_by_node() has consumed the node. This covers both the successful lookup path and the Fixes: 9955a7835bf3 ("phy: omap-usb2: use *syscon* framework API to power on/off the PHY") Signed-off-by: Guangshuo Li --- drivers/phy/ti/phy-omap-usb2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c index 1eb252604441..660df3181e4f 100644 --- a/drivers/phy/ti/phy-omap-usb2.c +++ b/drivers/phy/ti/phy-omap-usb2.c @@ -426,6 +426,7 @@ static int omap_usb2_probe(struct platform_device *pdev) } control_pdev = of_find_device_by_node(control_node); + of_node_put(control_node); if (!control_pdev) { dev_err(&pdev->dev, "Failed to get control device\n"); return -EINVAL; -- 2.43.0