From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90E683FE37D for ; Wed, 8 Jul 2026 08:23:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783499026; cv=none; b=A6S3MUspAGHIOW1HKWXHoZq7zTbsylnfyyMuCLwi/ykMF8OGt0JtXwHGMmNwj9OZyGaH4+awx/x8LdIVwotzhH9nX+IGUGqXpWndQNokXfSlj4qwuNVtkpN2W2sQjNFBhG0e3b6zeH3q6o3OoOb1gR1PJrD9IM7GzfwaxgcJRFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783499026; c=relaxed/simple; bh=Lsk0fOLk1eyE5SihkMKKiqajCEV6JI85T8euvwt54Ag=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aralooLXuXsuDE8juqQTPJrd0U5rIwFFni8K6LZkIDrYJNk+AWE6faaasyywJZJ2UAJfFmm9Fp4Mcj+//4PKcmtN06UzmnaNWyUsDZUGt/enuyqW0MmF35oZ0m1RQgAVeUr5q615Y+U8px1xfpzLuM0xl6Liw5WygMH8+Ua2lgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pObqCcvu; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pObqCcvu" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2c9bd2f8bf7so22125855ad.1 for ; Wed, 08 Jul 2026 01:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783499022; x=1784103822; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Oj+IWbXCEzvVQDJhz01Zf8btAR2Gtnyq7S/lgxw2k+g=; b=pObqCcvuxsE/tY0fr/FA1TkOQuAn6rb5EElOHXewYwSrGSLvvBBZoH2202hRJUAiLl sIm3K4Yunwu1n1I+GGsfh2JiSS+BcnVbfR1PeMxGwZy0KrmRjxCcqcrqgj+Y6ZrcWyqH NG4pXpqQWBwj7kAJvmGEZUklrHiUcPAZPYRGcsHgd6WOPWubcJzwoselZ6NeoxrjISbX IcrJg4E4PHjTmN5ljTsslWfHkY/wYx+5gftokmOFt1G6c1oW/rwNRbcUVA9LWxBoxjIQ gYxjVrNCjbBdCLl5JJNsexGGq38KnTcGLmGRT1IIHWEHUP7fz7Y/aOE6p5WFzPHOl4ci eZ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783499022; x=1784103822; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Oj+IWbXCEzvVQDJhz01Zf8btAR2Gtnyq7S/lgxw2k+g=; b=X0lMJcu1ytp+75W/JmCQkK7B2HmweGlzMIiUiSwcnEtykpLb8XYBSuTQtEIs/ehsUu sPrR2Cpb46ctpoy6W2EyvUsAZomk1xEvVRbSedeqJDI37GJbMy8QIDPUaH/Ph5oW9U+5 lCNO1RQNekBJADAMLROZfLN2NRcWdPc0HypHVcxmcHLe1xz1FQJwF2MERX5VleMqnNT5 uq6ZWfQAA9n/P27V4RTI2mkPr9BO7liIVzjY5zktQGxDPmlR7/0BM2sfeaxKJS6+uBKC 5sy0bcOOOisKuBOkyviqdEeN59IeBo1czxwvKkIgpf5IblhYfcFryzUectIQjkxT7ska B3zw== X-Forwarded-Encrypted: i=1; AHgh+RpvPVgIvE618oMR7nRr1Jpz9AAF8GRV5CXv9o36nopB/LpobvApIKn5/18U1YKpXCAUu61R693yRHxjpWE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1Lg8NO6oIZr9/Pnacie5wvVVCHJqDElswOgR7vr8hwmMyIU5K Gr+R2uwACXVdoHsC+Q4nsSSSm8OhCDjaq1uzonchanlqCrEiBULvM/6j X-Gm-Gg: AfdE7cnbzh1TVJX+HEX082oRKzGIYmPB3F+AmQnUYyLP1EWBa9BXWjaMcv6hjKv9vOD kmZTeol45zgJYDGqzETulU3FRWLLbZPBtkcv1WLJh/TB+70QTsIxoqX9g/ozOSuUzgxItKCdHJC w6TPuz1W5u9kofY6Lr3G7qOwl/RkrHf5rzFXnlEp9OQv/pLInfdUStDM5U11rp8T/h+2ACGPTQU 0EXWqsNlVD5jr4j/bgVU/jqdxIipBZ9+1v+2r0SN+mj0XzzYlB5a2aQ4IyebmAyLrq46qeATAky pEUdGSgEmxnUku+rhiWroTxy6J+H3WrA+riOK10FKMdhmRWQyDV+7f6Lj7NQHqZcf3HKt6eEVLP YnBRU55ZoXiBr/G9qMQ1lY03MRs587zndGNfNccUwNPg4s0gm7u26BrSv4X5H+4kQPcsCwhNDKN Fqsw== X-Received: by 2002:a17:902:e84f:b0:2c9:d277:2cdb with SMTP id d9443c01a7336-2cce9fafe09mr14458155ad.9.1783499022504; Wed, 08 Jul 2026 01:23:42 -0700 (PDT) Received: from lgs.. ([118.193.39.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d5bdf5sm23985195ad.73.2026.07.08.01.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 01:23:41 -0700 (PDT) From: Guangshuo Li To: James Morse , Ben Horgan , Reinette Chatre , Fenghua Yu , Catalin Marinas , Shaopeng Tan , Zeng Heng , linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] arm_mpam: guard MBWU state before adding it to garbage Date: Wed, 8 Jul 2026 16:23:23 +0800 Message-ID: <20260708082323.736350-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __destroy_component_cfg() adds each RIS mbwu_state object to the MPAM garbage list when destroying component configuration. However, mbwu_state is allocated per RIS and only for RISes with MBWU monitors. A component can therefore have comp->cfg allocated while some RISes still have ris->mbwu_state set to NULL. Passing a NULL mbwu_state to add_to_garbage() dereferences the NULL pointer inside the macro. Skip RISes that do not have an mbwu_state object before adding them to the garbage list. Fixes: 41e8a14950e1 ("arm_mpam: Track bandwidth counter state for power management") Signed-off-by: Guangshuo Li --- drivers/resctrl/mpam_devices.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c index b69f99488111..59225694255f 100644 --- a/drivers/resctrl/mpam_devices.c +++ b/drivers/resctrl/mpam_devices.c @@ -2606,8 +2606,10 @@ static void __destroy_component_cfg(struct mpam_component *comp) msc = vmsc->msc; if (mpam_mon_sel_lock(msc)) { - list_for_each_entry(ris, &vmsc->ris, vmsc_list) - add_to_garbage(ris->mbwu_state); + list_for_each_entry(ris, &vmsc->ris, vmsc_list) { + if (ris->mbwu_state) + add_to_garbage(ris->mbwu_state); + } mpam_mon_sel_unlock(msc); } } -- 2.43.0