From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58BCF1FBC8C for ; Wed, 8 Jul 2026 09:06:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783501563; cv=none; b=ic12rsC2rRYFxLoSAYd3MAcs6H9eWqhdx8Fmc21iVx3y8KTkn5TRZuVYwvY1BfprPObOkQzZdb3Fl2y5P0H2wN4V0OI78vwRAoDcDsJpPKOZ7TxnDntc+OTz6chORnwAFfHMb//RhQEHvmyIkuASPBhvm+B9ELqNdnoEj5QtKws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783501563; c=relaxed/simple; bh=e2AEx3Zy3Vi9LVwg/sozX1GxUiADsRLGbTvWqih+8tw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KtxRns6RY2r+cThAzHjxRxhjqpUHwtHL4M/wu2cUFCvsisJrU/iqeGvpMfoUk5oS+1G9sVDAFn0Tt/DSRSEpyGieQxzHD3q141fZ2tBmrlPHxEff34yzZnZPatWzVIqCR+yrKmy2aSiEQ7pkKT6SAXN8tHg+yJXp1zJs/f8qPoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cgs2RCDw; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cgs2RCDw" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ca70925c25so6253145ad.1 for ; Wed, 08 Jul 2026 02:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783501562; x=1784106362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ePld7oM6qnWsI6gvufVO8q/95rU2M76WU3t0KmkgKhs=; b=Cgs2RCDwUouLJKWAIelbJNTReYknOsPJl4HJvmNms08ZUG120vgA89lHSomssdUnDR iMfx5eoYidcY+HCoU8+Wl9Y7UcmmtS46cFpD+JlfUaBebwYUOsuIB/AjBHpcuTZrCKoT eecjCBKAT9uBVXqJaJP6bO0P1W/NgOvjEQLPLrxJzjbgSUko6+qKJPBsk4uTt6rSrGAq cKPAOxmCHhIsDKOSnRWhfh56DwdfNOYWU85WJM3ozD9CdKh/2v/hwNwhJbF8OrDqEpUh z6ZBUuHA4jS4oKqKqM0bEbpqwat/FzSeIho/3N3LbOYHYo8b0jkqN1e7M3sNGDcX4vOi GEAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783501562; x=1784106362; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ePld7oM6qnWsI6gvufVO8q/95rU2M76WU3t0KmkgKhs=; b=Y01qoEdlm8Vdb3S63657fpTwyJuVlC7KyO/EzgymiTHdV1O7f4axEBu0JFpCmbJi6v gNKnrePepL7iVH4z3VzjJYC8vszl93+lkBwQJDqw51/ISICMKU8yXDPxJtElLt4x3NAd dRolJzZKPlFPN3GW0NmrfBLKlF5zQaeYM7oYpqr/C+eP/dyAULDBZKwjdTW8bBkSnRvO kHTUEuXEq2y+Iq//KfY2SBFuWjfg0XAmc5CUdXCjAOL/+7ES7yc5kBoJMO0I3BEe6YZe 6lVrjT1cdcOzI5SQeXfVyW2XAWRo4BgvmojdYnn4CB2Wiw/VzK2eL0hhnp/aRdebtms8 AU/A== X-Forwarded-Encrypted: i=1; AHgh+Rq7t/R72/7Gg/ZbCGBMgdZ9H6ijF7ZaKb7olq65mqP4QDYtUrxRX1JkgC9FtG8HsqIsZtjvOkUjQ6HPQvY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4Y7VqR7q4B/DSitPsyp39UzMOJ8/MBJO8UrCRdT1WQJ39Vxkl Hr3zSImrhyN3qSF07sYgYn73alX2u6eySXTcpEowBvZ5LQYPdxfss3J2 X-Gm-Gg: AfdE7cmn5vJYuYZZlCQ0OEFoDI6rzhgMgtCMbrvIFtqFLNgfo8zJ2doXgdRNfaYm9Pt 8DJOg7ElR2JBJrfYobQeN2JWQdOTdMva0aTNM0vwx3fTArw7/AyzNmeGbsQwcw2f9urc1OE6OlL 1rU7UsTaN53hfy7vyZC1uccGdy//ptdeEsRt8mqwLi14CmcTsCde13lnLBm/IvR8UvdO5nKa/mc HZqiGai/4zDeeAQ2eaRM44MlbvW56mD0W9xloD0khN+sQD0MV8J0brtE+rJcxbX4yGw8NFoknYG +ONiEMRn7KvZW8XHd0KSQVJdh0VQ8NkdD5G9BFpjjiAbt2stUh7kUr2pBweAlup/iuqy/4Xk3CJ KARL9KWNvOAS6Hrx9EHQ2qgbklLs/qawtr0WUpJskb1DI6QYVhH1juFl0/VlkvPdN+Dw1NYOjFK 4vyjuWq42lpA== X-Received: by 2002:a17:902:fc8e:b0:2c9:97a9:2098 with SMTP id d9443c01a7336-2ccea3a3ddbmr19175285ad.44.1783501561549; Wed, 08 Jul 2026 02:06:01 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb9a3sm24834395ad.13.2026.07.08.02.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 02:06:01 -0700 (PDT) From: Guangshuo Li To: Mika Westerberg , Andy Shevchenko , Nirujogi Pratap , Bin Du , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] i2c: designware: amdisp: balance genpd on probe failure Date: Wed, 8 Jul 2026 17:05:52 +0800 Message-ID: <20260708090552.739789-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The change referenced by the Fixes tag avoids a runtime PM resume during probe by powering the ISP domain directly with dev_pm_genpd_resume() before calling i2c_dw_probe(). Runtime PM is enabled only after i2c_dw_probe() has succeeded. However, the i2c_dw_probe() failure path still uses the old runtime PM cleanup path. At that point pm_runtime_enable() has not been called yet, so pm_runtime_disable() is not paired with any enable. The failure path also skips the dev_pm_genpd_suspend() needed to balance the direct dev_pm_genpd_resume() call. Suspend the genpd on the i2c_dw_probe() failure path instead of disabling runtime PM. This keeps the direct genpd resume/suspend pairing symmetric on both success and failure paths. Fixes: e2f1ada8e089 ("i2c: designware: amdisp: Fix resume-probe race condition issue") Signed-off-by: Guangshuo Li --- drivers/i2c/busses/i2c-designware-amdisp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-amdisp.c b/drivers/i2c/busses/i2c-designware-amdisp.c index 9f0ec0fae6f2..724cb05e21c8 100644 --- a/drivers/i2c/busses/i2c-designware-amdisp.c +++ b/drivers/i2c/busses/i2c-designware-amdisp.c @@ -81,7 +81,7 @@ static int amd_isp_dw_i2c_plat_probe(struct platform_device *pdev) ret = i2c_dw_probe(isp_i2c_dev); if (ret) { dev_err_probe(&pdev->dev, ret, "i2c_dw_probe failed\n"); - goto error_release_rpm; + goto error_suspend_genpd; } dev_pm_genpd_suspend(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); @@ -89,8 +89,8 @@ static int amd_isp_dw_i2c_plat_probe(struct platform_device *pdev) return 0; -error_release_rpm: - amd_isp_dw_i2c_plat_pm_cleanup(isp_i2c_dev); +error_suspend_genpd: + dev_pm_genpd_suspend(&pdev->dev); return ret; } -- 2.43.0