From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09DDA31F983 for ; Wed, 8 Jul 2026 09:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783504508; cv=none; b=afVuXMVzI23qIpkmCeIIX5TwpQfHiF7nhHdHeeNEoBFSDsmsiibMNF9WKcfUhELLxTR/kKYqJYsY+ZHswxWnjpDpONIKpX4XsnlRCil6jXVdSp7hTbpeCnv0FmfpIsGVpvZapOG8aiVufUsLYHXSc0nSp+GA+8MvIOclAv25iw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783504508; c=relaxed/simple; bh=KielJ8Do6FmcMys6V7ITutZj6HmUGFdwmlvbCq9I0z0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jKzh+xZyDI3hq3EGAxJ7CB22j8ShrccVNiRiQLj31svLfEz2qomQIVEdJfiyjAvNtSpmjZquSzE5wudzAT4dwMmt/3Fd2IHDlpjcdMixl30nxRgMgBAAylHHeQFwP+5pq2iS/LnFt8tRBwLxbtDGvZO56YZ6oYREQCZnH9GXGDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gCFzEmTi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bWutgNsF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gCFzEmTi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bWutgNsF" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66888xg92083250 for ; Wed, 8 Jul 2026 09:55:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=b5CFcTSvyTJIGcqPesdkFer5wgVsdpvvSq1 HRnCCug4=; b=gCFzEmTiqyoZcqelq1j9vWPMLCpYXgkFmXbvJq+YwnSnq9tYkde EeUX3Nh177/borQR8qUJ1a/MY7HfvpKbL48rvfDWPhplItEcJ9obG2flkK9WsC6F 7FPBZ/Wq7fzbOHH3XunNZvbcqUyFAt0tIRil39ZqTWTxDSanPKeRbH7ZuOeABH7j BNnX/03SzVUb9QjY8li5HbOc/IxaGRKLuVbElwfuPsxmEOoO+bjFGSjqkXy6evpK ohKb3HaoWfv1t/ZyDpeadP7h64KHX1S7YzVwqPC6th3dBtwlT2UivzHRhiDeRQmE H1hMlJIuLCpooherSEN1fMl0dHrb2CCyg2w== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9gqw8yfg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 09:55:05 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1d7886cdso9897281cf.1 for ; Wed, 08 Jul 2026 02:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783504504; x=1784109304; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=b5CFcTSvyTJIGcqPesdkFer5wgVsdpvvSq1HRnCCug4=; b=bWutgNsF+rtnu1jcfVoB+LIrD7S7V7aikfyXCujKIQ3zSmVtUG9MrA1nyrEtX0l9jx K4Th7BFDgJq6bLcsDcmyqZ921cN6/oOOY6rHiNhsgpt1P2AOAytyf4kg5IfRRaNueWAX +H5thBo5UP4gtZ94clrDa9W3hYUy7DLWge0+KNCUOJoIncpJD+mjex311yGjgG07hRgU XVNhlkNb4aZJt085EL3yzjgBsYASfnV4XygMEp9vzmAy4g/9XjgblbNg4pTpZvgKGiX7 e9r/ylufgVNBrQwjOiS6RrJytoftEusNWxmjFoYGm4FysOOYGTFDAhzv69iHc/VIr9tZ 1LqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783504504; x=1784109304; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b5CFcTSvyTJIGcqPesdkFer5wgVsdpvvSq1HRnCCug4=; b=O6IVN8+dTy+nGWiqACAnoURNNMSqspJ2QhHjvfrNOJciQwlrlktFdXyOodshB3acjZ bPSVoTNWNaSzTpxUkZERY4+QGMjhEridKfMgnpS6GPYz18Ss9rv1ex9ZlMXPfH0ywb+l Uq6Y80TDctoBk/GaISt9dNcOZztFqrsur6rcKMVmNhhKuwsIJ8zExjG8aYkSLg69mDk0 dovgufdiz6wHxLTHgYg8/jG2zOBhAp75kfDQcXNY4ohI12LqVfuNWFbxHYLcj9CjhwsN hysc8xPSUJt8pl1k558w8R7ONdj3/Jy0O0y0qu0kOextAGLEASrEJfUw+2KacjXhcHeI XPJA== X-Gm-Message-State: AOJu0YylzxrGlkCIvmYl60dJxXRZFNKeJDJP3ldZfNoroCshoST4ogyu nlr8ynRsoQPinAJoF42SqPf4BoxsZZoxwFmmvo92Y9Zhbrk+UvuoBYKuZmULfkV3EIk6SVLlgCG ZmTGTvJvWiYkrKYnyaAAbRwQ4qJi15TmlbQIYlxnX7ySUvCOV0eSkso/RByIvvCFFmkQ= X-Gm-Gg: AfdE7cn/8389Zs1rYKyj+eGjX7hs+tqd6MycAz7AUHNfBZUoyY5WvK+Z7x775RHx2tB o2rI/2QopIsIQ41EwhvUE++NfGefBQ36GulCGkyKERCQssKegql3OTF3g/YDTUZ8MD5if9onqdw uDJpgJu0Jif3Q/FeQ3PvyYpi9lDVio2IBisWSSeKALU263IzBidA7pSOGFY2niQiu3FHv1gV6Cs MVYuwEnIPN5Pd/yUDjvT2g9aeMlG0144uppdZQX2jvBRIGSx4y0OqVSlgh/XmDrWrcN+1sFjv5t URcCkI2Nt1UPdNY9YreGaaHvOokkqEGxLdpSo+4LndF7gWktozApm2z8mVgNzrNlCmhlerWNFh/ dpJDlUfbLmO8dLfflVFhEna6YnHlKI7AZjmAMhA== X-Received: by 2002:a05:622a:28b:b0:51c:100f:f91e with SMTP id d75a77b69052e-51c8b409e16mr19480981cf.72.1783504504294; Wed, 08 Jul 2026 02:55:04 -0700 (PDT) X-Received: by 2002:a05:622a:28b:b0:51c:100f:f91e with SMTP id d75a77b69052e-51c8b409e16mr19480731cf.72.1783504503907; Wed, 08 Jul 2026 02:55:03 -0700 (PDT) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:6d02:5f1c:554:8e46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e582d4f7sm43946795e9.2.2026.07.08.02.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 02:55:02 -0700 (PDT) From: Bartosz Golaszewski To: Shuah Khan , Guenter Roeck , Albert Esteve , Kees Cook , Alessandro Carminati , Andrew Morton , Brendan Higgins , David Gow , Rae Moar Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski , stable@vger.kernel.org Subject: [PATCH v2] bug: fix warning suppressions with kunit built as module Date: Wed, 8 Jul 2026 11:54:58 +0200 Message-ID: <20260708095459.12111-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDA5NCBTYWx0ZWRfX1bBDHqXBZj6J sOLitbxn1ovs4owxa8MsrYh4n9ZDYpAWRXXA73DOIiq1TdEFEnTPJQamuKLTIN+T7hG8QMLow1j hcEsBGaDgKirz3UsqbajZYtJs26XPe+kNHysDyX3tasP1VlpjzVzBAuynVl3YTSm7E8+s9T059s 8GJ5ntS78EUSw/vMVpzaME5mnRgNeD4fMZ3ey2gtilUYdA0usBSiy/pdxbzgN1fn71oNvYaVXAZ kHg7fMtfiSaLBLEIH1mppSTlGYMmiIRDSINoH8Mp3FtRfQTtEJQSCOQVE8VdXqj5P7hesrknVKX Tpv0PUELMW08TVo0u+jd6Erddy3ebaa9UmzAEwPlx2dl51rJ+9tlhffTZRyIHQ2htD1zzwXXv+y 07ISST64ZzQEtYu0DCrGhadIONW5NMHSh2eaJtw/Oxxzywh8QT9qixjNF0l6tLPTrnqUjy/xAnB aSgd+P4c8LtFIXpHtEw== X-Proofpoint-GUID: CN9_ulLpslB5WXpPkU0TMUQxzqBVw8xp X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDA5NCBTYWx0ZWRfX2Px9rx+AjkJX CWkeO37E9j97JMATIvivIqUUESIDKW2l4SFDMJhkzuMYJbM79XZc6TNtSgVJRWBO4O9+M76utMG DqaJTOZBGHxZtQlIBCs749X1EkPESSc= X-Proofpoint-ORIG-GUID: CN9_ulLpslB5WXpPkU0TMUQxzqBVw8xp X-Authority-Analysis: v=2.4 cv=Wf88rUhX c=1 sm=1 tr=0 ts=6a4e1e79 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=20KFwNOVAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=c6gkZtNT5E4R2uqjZHUA:9 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_01,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 bulkscore=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080094 CONFIG_KUNIT is a tristate symbol but the warning suppression code in lib/bug.c is only built if it's built-in due to it using a plain #ifdef, rendering warning suppressions broken for kunit build as loadable module. kunit_is_suppressed_warning() already has a stub for when kunit is disabled so drop that guard entirely. Suggested-by: Albert Esteve Cc: stable@vger.kernel.org Fixes: 85347718ab0d ("bug/kunit: Core support for suppressing warning backtraces") Signed-off-by: Bartosz Golaszewski --- Changes in v2: - drop the guard entirely instead of switching to IS_ENABLED() lib/bug.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/bug.c b/lib/bug.c index 292420f45811..7c1c2c27f58e 100644 --- a/lib/bug.c +++ b/lib/bug.c @@ -219,14 +219,12 @@ static enum bug_trap_type __report_bug(struct bug_entry *bug, unsigned long buga no_cut = bug->flags & BUGFLAG_NO_CUT_HERE; has_args = bug->flags & BUGFLAG_ARGS; -#ifdef CONFIG_KUNIT /* * Before the once logic so suppressed warnings do not consume * the single-fire budget of WARN_ON_ONCE(). */ if (warning && kunit_is_suppressed_warning(true)) return BUG_TRAP_TYPE_WARN; -#endif disable_trace_on_warning(); -- 2.47.3