From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF778392C4C for ; Wed, 8 Jul 2026 10:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783505630; cv=none; b=SWlJhb4/WZ8d7lXlcb/lrO7ZcsQntTNrWxfEGfAEIW6nB7Q6E7l9PQ1cQ6Eu9rs86rRIfPvx/9wSE8tytCocrvC5P5FM+EW3/UKDMusrBidcWPokbUlAMKz0jdW7F6ywAk8TS23W5bn8oTIt3nU5TBcICo7z+jKjTaFpL/Pt0YA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783505630; c=relaxed/simple; bh=fPsMTWcB4QH1amVD5019DZv7UOAXGmrLlZijcW3E5CA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=koqqd2l6zDgzdd20aklWVk/1Vguu6Us+eWSOakuWXwAhowClAMjJFym+KV1OUfgizm2Bg4xCZ3Kn2HQZB6SqAaDHPlziM69fLHZta+arumZ34dVuK0cG+Yr8ttdbVHCFSdjOia+c7y6+H98tsvzjaU88tsx0vECb+IGfiOZBjao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IrlEVJdm; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IrlEVJdm" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493bab44440so2922045e9.0 for ; Wed, 08 Jul 2026 03:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783505627; x=1784110427; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QTSLyDYUqKwuc6ZFj/fF/ZTPe91RSvx+oh/5nIT4BLE=; b=IrlEVJdmOMMfS808iC75fnjiYJa+iMb6MfQNouuxjc0y3qn6l5oYAvTDGO04clSlX7 GBlRPIAVAnMVhtBX/oUG1Ayt/OQVy9wN0dUbQXsW9jb78poPzKmZYZDrsD6jF6TkXzbc Hpx5PoaABJc+UU3CycENeMijJwg/aZUbgqgCfFcDVFHBmeSjrl8F5tuSV8M5RgD6B5Vx F0BPsAnRaQHWnv18cope6+KnLysDV8jdvrtAol+qWqCq89u/fr/2HOKxSSn+QF4QnQ/9 HOFsEjHB4NckOQ0IsCBg9ip8frxZDMf+Zl3PsXwIM4ZFqOi4bt6vB4rW38FFxlLxSBH8 oQaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783505627; x=1784110427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QTSLyDYUqKwuc6ZFj/fF/ZTPe91RSvx+oh/5nIT4BLE=; b=jKJTIo4nprBOT+Ih66H2b0wWxaAbuWjrrw0ebNg/2MMMHB59EisnuoHYFdTcfHhnCb mVwEjMJDRQpDPicwN3JIEUmGD7PNs/HjCratMXY5TwFgx94ucocJFo3UYnmxMcpVuTI2 jqmv9vk1T/VadfjE8XvAMwFDVPiPr0kBuVycIye14x3SJv7b4a4c6iq0sV5CV1mn1ZCW fjlHh4EFfhBQkn/UtiiKengghCGXEI39DG5D4OciQiqofF+sDjPG14cC2L65LAnfQ+OL rPOgETB/HuLJ34e10wKvjqaBqfrMdtaW6iOe9PiSzQuVYEYlgISWJucL2iEMBCLh+JVe NkUQ== X-Forwarded-Encrypted: i=1; AHgh+RpBFpYXq0XvxoGgFhfuW4vYY6j2J2BZxKPxZtMWPaNo2xQoV6mAch7ZyOj5hsl57GqzPouXLXla08GKkfM=@vger.kernel.org X-Gm-Message-State: AOJu0YyxKD0+XCBfnxTgxu0dcS9SrxnbZ3/HTWc0rSQzlqgkXhzMWpZW sGouqvajUgJDiVsaNYT5ACIrLADvf3gl6e9lpwlibDWSsiTpjPVUuCLx X-Gm-Gg: AfdE7clyjpidru6dxbe9pyU6s6mfq0mJv502eMIW+Q04sSZe1sP4LtT9wLVL+wqz9uE QzpR4hUALWBFtNnTSOB1V1p7o70uy0A6jqijg2aXTEt9vx3iDKtQl2oMUZ3WdkGaWuq9Lucz3DQ jjVoEq1ghX0Lt/wnSkGJJ6edJESD6tQW9LRvkHH+MvpTV78FOrFm2Km+6XMM7V7fJerVvb0+69F YqPLqrKzHfIjY94qeY/6xKyHVlJ3QZJ2pm5J8hrLlP8cQD/LMFb8QoBGpbTGh5hVoctJKRSgeOl fTTuz9hFPqiXxdDAFRyoPeMT7FnCRdlKFL9lMNrbEuGtPnLD2OlB3htp2kGizK4rxrTGWCLYmiC ceuz4TmNo3+tpcnHWMpJAyFc6oawPCwTMUMNvCRlYVr7O17S5KGkhXE2ikEZgeJI5+pJ08vkqdQ 8T/ntP34tQydnLVeHQCCw= X-Received: by 2002:a05:600c:4692:b0:493:e2c3:af25 with SMTP id 5b1f17b1804b1-493e6393963mr19702045e9.12.1783505627166; Wed, 08 Jul 2026 03:13:47 -0700 (PDT) Received: from yocto.. ([195.72.110.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e0faee30sm108987515e9.10.2026.07.08.03.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 03:13:46 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fygo.io, magiclinan@didiglobal.com, xiao@kernel.org, axboe@kernel.dk, vverma@digitalocean.com, john.g.garry@oracle.com, martin.petersen@oracle.com, abd.masalkhi@gatech.edu, linux-kernel@vger.kernel.org Cc: linux-raid@vger.kernel.org, Abd-Alrhman Masalkhi , sashiko-bot Subject: [PATCH v3 1/7] md/raid10: fix r10bio leak in raid10_write_request() error paths Date: Wed, 8 Jul 2026 10:13:35 +0000 Message-ID: <20260708101341.473750-2-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260708101341.473750-1-abd.masalkhi@gmail.com> References: <20260708101341.473750-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When raid10_write_request() fails because REQ_NOWAIT is set, the allocated r10_bio is not freed before returning, resulting in a memory leak. Free r10_bio before returning from the REQ_NOWAIT error paths. Fixes: c9aa889b035f ("md: raid10 add nowait support") Reported-by: sashiko-bot Closes: https://lore.kernel.org/linux-raid/20260613184042.BCEC01F000E9@smtp.kernel.org/ Signed-off-by: Abd-Alrhman Masalkhi --- Changes in v3: - No changes. - Link to v2: https://lore.kernel.org/linux-raid/20260628142420.1051027-2-abd.masalkhi@gmail.com/ Changes in v2: - No changes. - Link to v1: https://lore.kernel.org/linux-raid/20260623072456.333437-2-abd.masalkhi@gmail.com/ --- drivers/md/raid10.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 0a3cfdd3f5df..bd322eccdc3f 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1365,6 +1365,7 @@ static bool raid10_write_request(struct mddev *mddev, struct bio *bio, /* Bail out if REQ_NOWAIT is set for the bio */ if (bio->bi_opf & REQ_NOWAIT) { bio_wouldblock_error(bio); + free_r10bio(r10_bio); return false; } for (;;) { @@ -1398,6 +1399,7 @@ static bool raid10_write_request(struct mddev *mddev, struct bio *bio, if (bio->bi_opf & REQ_NOWAIT) { allow_barrier(conf); bio_wouldblock_error(bio); + free_r10bio(r10_bio); return false; } mddev_add_trace_msg(conf->mddev, -- 2.43.0