From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8F7A24BD03 for ; Wed, 8 Jul 2026 11:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783511044; cv=none; b=ASOGiT3OoTlQNfvYk7YGRQ49w9n9L+nc2xmyvXEpvHHxNGtwohhw5Cs9UoyH5eHBTn3/Xz+ARzvhwytr8fLw6tJEykfQqM/FE+LtfG0u6XsbyYBZ088GhAuwvkFa+1P/gBuBAALDhtF6gKfOTvxCyU4xPq7HT1EBYA9DZCLyFg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783511044; c=relaxed/simple; bh=g4Ckx/oaiHwUXvQjjJSfNcAcM7WlcaOJ3VnGHKFFFTg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mV+0YT/feJQcEbkqxprY1Xg0Hlxz/xkql8vzPMv3GLLzETokD/RNC6RoF0UCystTmJCUavdvXfPBagpIUJ0fFtIfZ0pfr1SFl+3zPKgOC4WTKufpVsEG41+T2KghpUTdZTbsHc8enFd70MQsJToWFp7dm51asTmbk6WUk6QDr/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bc1ZIMaG; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bc1ZIMaG" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2cca24023edso8432825ad.1 for ; Wed, 08 Jul 2026 04:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783511043; x=1784115843; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=4suNiv2yUkpcu0FQfwaTGnjQpQAO2D0FA1sYqxvGsjw=; b=Bc1ZIMaGpzv47IBnfZVuefDe8tCtz7F/ob3s0xKa7ubT0/idArh07C+HZw3pRLBqO5 rzVfuiMVadoa76AsYt8Tf6HAn4AooXCC1ysTIO2YNMk/p9CdnlyLOzKtuJ4Z0f8Bat5O Abip4AbJUtAA5HxAIGaT0T9dxZOXhLt54e0HMgUE2J1ZJ8WctBze2s0EM43dD7tOOWMf m7bp5y1QoaA3OzAkbC/dgiXIvMolT4HBts5mUJe8/UKXE4eMHnoSYK6njHSi8de6fzdW B2bSb244I3NxXwdEpjeEtLt0et9l1LcLVG+W3PEKmba0AS8McQmtxDTu6OTT3UrCMl2P vhng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783511043; x=1784115843; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4suNiv2yUkpcu0FQfwaTGnjQpQAO2D0FA1sYqxvGsjw=; b=Ey6vblCnPqWZXe2Ubl+NbmuuOqzU2KEkn1LMJhP4o/us6y/nHGfOdBG1sT6ieI5NUj A7660EqPN7pNbTv2nnzeEmN3x12bO3BC997yg8ZpTutLjlv/m65p0MFlFCCbLtyUJPRF FfnvtQnZ9w4/dR44Y70b3SxY1cmDPwxFg9FyI32AYib6uBUPsFzMtg+WE/7xZYBz9tN7 kJ/IvmGZ9xTqyBtEcT01oQYWSSELa3AsEBoucIArkqoJODhfjUKopdmHMnoCjP6rFErg 1svJ4PKh71gs9q0dlO3LVl2xFXxFST0+qD+wXA/sa+T8viKYTz46mik6guEWCaqHCFVv FqXg== X-Forwarded-Encrypted: i=1; AHgh+RpIuCx/zxcdQO5LXD1wF+wbIguM6hjTBOjWYrk54GDI8hVOU0zkUb0pcUrfgrKDVGMDjDY27h8mfuBsI4c=@vger.kernel.org X-Gm-Message-State: AOJu0YwX3hISbASs0asSd1Myb20bHJRvxt9zT1Jqroml4cxJK7pRw8wN K146WwEazqP/lo+dJ57QCOEzWBQkz5sWMDdGDhwukxAmSYurM5V02b+ZGTpBaiZ64o2RRg== X-Gm-Gg: AfdE7cmDuhzYhXEeaWUk7bxBiG2D39HHeXchM7EC1zS0AB7DwYFJJRpS9w88Ssd5U4k leQ7iiGDGalABb3wdzjJm7j0uVaglJhduMASc+/TvvomHcD5vVcQyTe4bWIKv/b5UUH7d5BvXbN cGcKj30zWYfOs2AGqW+XSKcnNHUe33sjrlcCM5Wap89S0HHOQL1a0/d60WEZjcMh2/ukOFc1mvy lKszE9es3iVlrZOE4H6fPbBfWJLTmdjFMNRoslWSaA40lt038xZnAH6daQ/otPx7wIYQcrHLVNC cBOta53IkdVCjE0TsV262Okl/mSb3LUutgwH0Ch4gmNx8Fullvvf1LnLB7IN33TzW80XDFE3ONM zSoPzaw4KZRNmekRynqrVR0gv/QdyZxSOHOmMC2/ats4meEkGKG/G8wQ2Jqza2UZ3o9r4AYjsnI qc7A== X-Received: by 2002:a17:903:1b2c:b0:2ca:c01e:8837 with SMTP id d9443c01a7336-2ccea444eb7mr22149085ad.24.1783511043079; Wed, 08 Jul 2026 04:44:03 -0700 (PDT) Received: from lgs.. ([36.255.223.70]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb86bsm26859875ad.11.2026.07.08.04.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 04:44:02 -0700 (PDT) From: Guangshuo Li To: Tomeu Vizoso , Oded Gabbay , Jeff Hugo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] accel/rocket: put IOMMU domain on BO creation failure Date: Wed, 8 Jul 2026 19:43:54 +0800 Message-ID: <20260708114354.753817-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rocket_ioctl_create_bo() takes an IOMMU domain reference for each newly created BO. The normal GEM object release path drops that reference from rocket_gem_bo_free(). However, the BO creation error paths free the object with drm_gem_shmem_object_free(), which bypasses the driver's GEM .free callback. Those paths therefore release the shmem object without dropping the IOMMU domain reference. Drop the domain reference explicitly on the BO creation error path before freeing the shmem object. Fixes: 658ebeac3351 ("accel/rocket: Add IOCTL for BO creation") Signed-off-by: Guangshuo Li --- drivers/accel/rocket/rocket_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accel/rocket/rocket_gem.c b/drivers/accel/rocket/rocket_gem.c index a5fffa51ff35..438694ba567b 100644 --- a/drivers/accel/rocket/rocket_gem.c +++ b/drivers/accel/rocket/rocket_gem.c @@ -127,6 +127,8 @@ int rocket_ioctl_create_bo(struct drm_device *dev, void *data, struct drm_file * mutex_unlock(&rocket_priv->mm_lock); err: + rocket_iommu_domain_put(rkt_obj->domain); + rkt_obj->domain = NULL; drm_gem_shmem_object_free(gem_obj); return ret; -- 2.43.0