From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4F152FD1B3 for ; Wed, 8 Jul 2026 13:16:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783516612; cv=none; b=jYTlPPzCiAGvlJz/5ukNlrqJTDVLAbrxJ1hh7Pao1/DWOKoAf6+4huxZWF7KQH95qYtnLBUAMj4kKj2oagTZWuVxPXI3cmLV0JO558fose5JJFGSFRij73+XACYnPA80va0DC6dVLHfDKBAf0jVgyfD0zYpVUEztdbAusWWRoOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783516612; c=relaxed/simple; bh=Ut6iGecErQbbKq1EQTWQmxnXlyJqeb4XsvAW8iInNCA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qu73/2IhL8vhFFGX34t7kxs1KiPwTJlIGC8LgqadcakPYZOPPEUhorf2lIdu3YCsurcXNikx/AhwjTXYwnPVsCvBR9nNFHNlbfbQDTVpTJW/jqmhEpFY36S49EuT2psM2MSNXRSs1FvQHZwqATZv294z7/ZQHoVk+QhjFZjuCXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SEhCsOtV; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SEhCsOtV" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso540809a91.1 for ; Wed, 08 Jul 2026 06:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783516605; x=1784121405; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1g9bGpZfeB1rvyBPb5iXBjrZ5UuiljRZ+IlaR3rBxm0=; b=SEhCsOtVjv2RWiXHpbqsbDRUbVxvw6HY9ye18BrUyuQIBjQe8T+QY/Lv7ihx6sSn8D EzS51E6SjKoRFeakqlzdnfe9094JBR7EwooXw2KTSNb5034UrbcJWSZQA7/R7FaT9axb 28WDg+ZmcOYQRanh0cJCqBihZQSNYu9PfvyTuEncur4sSUVbJWAgo/tk+NJaf+U0wNjv hDOb+YyRw9hS3KW9cZB0XnL8O1JdklSSGlYEI0WrCDMBTbiLkkez1OO0WiwB/SyYrHsG DJ5+3Z3rCvp/nqy5zRBumgFrCvYa4xEIpfvHLQO8Oja7jW2LMgAGWzxKK6pggESiEgsP a39A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783516605; x=1784121405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1g9bGpZfeB1rvyBPb5iXBjrZ5UuiljRZ+IlaR3rBxm0=; b=i+2tN3dsRhXTVEc6/WquZXivPH2BWWlXH/RGKVuIg9QZNwnZWImDycQX1oIrLX6Mp9 0SyaWjktm6FdyqpUelTBiCDiNFn4wgxVx46KnByhSgO8A1mmnv6bcWRGUXU518dNQWDH vfSh+z94VCQGdOnAR4ujl4WIXESN6cuVyl3LD5Mtd8lF3ZFMoBumaWC2BGVImwIo4NQG GZNRUly6B7ofAKWbcIN3nadWBdUK9nD6Q70Fv2uXg4ROHKIFGXbFfkRqAZ+RdcoXq2SW BOGyph3G8VK+0bmWRzhoThXvijDR+GAOf3T9T374uJx0BjBq8tgEBb2lbZ7l3A5pS5Nh X+zg== X-Forwarded-Encrypted: i=1; AHgh+Rr2M1qtEqXW4z9klkz6HoorZcF2k3vw5B023E5SQbnDzUL1qmQxmXDdu+sZeQdpMe6uzVxg0C2VBIo7C2Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/Q2bMmQ2j73z6T0CN0KRgXM87znr4UwsX0F1NmZ/976hnKHkN DbNPIYhPIr5qV4WizDuKsTO4DOtHNTaEFTyyz8vW6qqckZhoEVkSckgy X-Gm-Gg: AfdE7ckNJfEHSO4/1vf2BglGs/uPUZFdBoEnns0Cx4E79g0XaGfG+tJ5kSXl/PZ87BD 0qDtCL63/u+Q/9l0aRKdIABh710PL0X/wZTfmudvrhE6grWNrIwc0R9cpyp3VJJeurDsjJYRyYJ erxoqAkV0KrbNidAHefk4wpa1NXF+mYtizX3fDtZs4WVDy+uKvudKfDohcggFMMkj/hjn6OViHo qryMPCeneTP5pkY3PbjHk4obNYIuKDgTOykjmxOjSnqYMJmGzQquvaqtaG8MVpnkX/cQz5RiVz5 +KQtEaKb4FgOUicyciRq6QNpDRBS/LwcPO34FxFv/hqruugTjIM88GO9OOdDVP+AphijZ86pDNv Hhh6b0SsFdJGFSnqteLB9b7OfSt/IZXZpoA7KnzWGNpxEwd3ZH/B81mgbQYqeHvvemIiVVx1/9J xJd4xB4xuPn58w+ZG69GqZiR10M6kUTMKTrxZXAc5T54c= X-Received: by 2002:a17:90b:3bcb:b0:381:77cd:38d1 with SMTP id 98e67ed59e1d1-3893fb74d3fmr2571017a91.10.1783516605369; Wed, 08 Jul 2026 06:16:45 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174accb0esm22447962eec.30.2026.07.08.06.16.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 08 Jul 2026 06:16:44 -0700 (PDT) From: Biren Pandya To: sakari.ailus@linux.intel.com, mani@kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v3] media: i2c: imx290: Drop manual fwnode_handle_put() via scope-based cleanup Date: Wed, 8 Jul 2026 18:46:37 +0530 Message-ID: <20260708131637.35132-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260616081517.44685-3-birenpandya@gmail.com> References: <20260616081517.44685-3-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Utilize the __free(fwnode_handle) scoped guard macro from to automate the lifecycle management of the endpoint fwnode in imx290_parse_dt(). This safely ties the release of the fwnode_handle to its compiler scope, allowing us to drop the manual fwnode_handle_put() call and removing the risk of missed puts if new early returns are added in the future. Signed-off-by: Biren Pandya v3: picked up Reviewed-by tag. Reviewed-by: Manivannan Sadhasivam --- v3: picked up Reviewed-by tag. --- drivers/media/i2c/imx290.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 21cbc81cb2edc..5c369c7ee21f7 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -8,6 +8,7 @@ * Author: Manivannan Sadhasivam */ +#include #include #include #include @@ -1514,7 +1515,7 @@ static int imx290_parse_dt(struct imx290 *imx290) struct v4l2_fwnode_endpoint ep = { .bus_type = V4L2_MBUS_CSI2_DPHY }; - struct fwnode_handle *endpoint; + struct fwnode_handle *endpoint __free(fwnode_handle) = NULL; int ret; s64 fq; @@ -1527,7 +1528,6 @@ static int imx290_parse_dt(struct imx290 *imx290) } ret = v4l2_fwnode_endpoint_alloc_parse(endpoint, &ep); - fwnode_handle_put(endpoint); if (ret == -ENXIO) { dev_err(imx290->dev, "Unsupported bus type, should be CSI2\n"); goto done; -- 2.50.1 (Apple Git-155)