From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 723CD380FDC for ; Wed, 8 Jul 2026 14:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519812; cv=none; b=a/bpgUK4da+v+SjKdUYI+HhqI11BKItCrc4GCnIxH+T/FpamNVZ1E5Mqas5vOcEvi8M6mqak+unJ7J+9koYchYKpCUmghw5TNaT+AM88FHsSITSzX6FJ+vIYP1e2rIPJQiFuFx5FbIU0Ju0WGO4viHy9HlgWKgK5qaFCCVRSiy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519812; c=relaxed/simple; bh=GwN1S4Y/Z3B3qmz+MTHgvzSV9DWZZu8uLiqV2eQGB30=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=W/BLLXSAvKLrbPrcdbSh012HgEfC9JrIOS38OTzX6Pv99scFURLdZKr9lNm3mIv9s+jhuXa9a3LVlN6FVlX/gCdYSuYgCgkfYtOZoT0xDkhNHVZnC7N60MYlNNsHvzvdBTb3DvUpeZheXsWCQJ0EpO1oj6nPBl/qAIEsvuTe6/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VHfu07ib; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VHfu07ib" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c15bf399d3bso86480766b.2 for ; Wed, 08 Jul 2026 07:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783519810; x=1784124610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=mUQFekeQR7aF2bl/7XnDJ3W7Z3Ri5CBrxTY3M+VB1/Q=; b=VHfu07ib/EbJt4Fk0PgTTpeEvQZ1JanNpqdiyTIfx8H8BWXbzRaupW18LpLuSkvSZw rE8ExQAB6hUwNoUL4Pf90sdVkfA7xQlSbpVwbmJI7nCiK80Q0pzSp2bjcW+8h8HOQtOB TU+umFStyu5JA0yCOHiWPU+bPMQM0hMKhsaFx7NxJNgDxk7yrB1kcUB+hF2HcVo9DWzW CEtutGpV4Yd8Mf8znJ1hvVSWVdhmSYq+5sw1Oe8L8Y3pV20Teaskq1Sqws20ry1K7Ri8 U7N+j6PC7+womxc+XIIn4YEBmLcSrFNk7ffMeX+xBrAOF2V05/raSzxa72pr9YCyqiXd XmMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783519810; x=1784124610; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mUQFekeQR7aF2bl/7XnDJ3W7Z3Ri5CBrxTY3M+VB1/Q=; b=I3DOERz425/OF8z29neSWIT3MaEvI/ua6edO/9/PknHaS47FgLPOjpSlGOYSR8xr5X kTMQufgKuA4WZCAF1sqHjB9lsddLlbQOOTY2wNTXaB7nEg03ycOtduwwCTrEgA07gq6L alzr66diWKS+aAL8kIU1ApH41M/Uhc4p9IKEEk1ib/a3BWG948sNKsFsZHG6zuED+D2q rhdTp6QJ9nNIoKC/wjE+mf2YcEcstykTORXzMj5dlqqxK1j6yhjBgvXQ8ns+BWfakTkL pxBwU/wWJn4/P9sQpFrlbQG7/vuM1vJEQZDCjydYs4cLrOPVBeAq0bpyWE3GnGgBF5MA F53g== X-Forwarded-Encrypted: i=1; AHgh+RqdGgORIZAvCIXsOP4cWM/QzsASQu+DHX9xIuhJ+SE9o2eFOjemHVrV7VtGy0ocpqb/TiKzbPWkraleC5M=@vger.kernel.org X-Gm-Message-State: AOJu0YzWzrjGOHzuSB/xlSbhY1WEnhok80b2AOxcyGyyzdRzGcjMhy1z cMRUtx/z1FGOLw2fJ8jGue3g0zWb4aZrEmI2zrx0CI0ufD0hnjmRugm6 X-Gm-Gg: AfdE7clgoRxLBw3pHwlFcMMgH78BJwULYI5jofXmaZOzArTBMY1SU1FZMcuHW16M9yk pi+0rXh9BFdsck8wr6Yiw9+T3m5yNX5gwIgD1jnGHd510yGVKcvTqa5fGw3M962c/p9WpmEiAGx k8TUZmpi/XpRsw4DTriOlRdyfUqAF/NFOjC0rs9OhFtx4QruxzKDbxlo2ECZk1Pd3X/u+/BIT8T MPboSX+opYjNrBdLRi0FWv78V5ggkSzwqBm2r5AbrNphepsDOvv27021NcBPveWjtHouAGPBuC+ RUBVki8tWPkZUADwo28LX2Y90S3x7Be9s9EKFRrYVtNF1O4U3eFM/CU8j6h65OFN6PMYuH42bi/ gdezNtEyKD0zSa6kkHCNuJh/qcGzy2jZiv9gs+BPKwp0YkwaESZ4Q7aFTvUcPLXagxfEWXMmhtJ X7E9fAPvE9P+QkNoyw/N/V+kTqc10FgRYZgTOC3zrPws0ETYj/lhfjjCsymnzb2GI3yQ== X-Received: by 2002:a17:907:1c0c:b0:c15:d84e:4bc4 with SMTP id a640c23a62f3a-c15d84e5e92mr56474466b.8.1783519809524; Wed, 08 Jul 2026 07:10:09 -0700 (PDT) Received: from fedora ([102.78.186.161]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15ad84bc3dsm335198366b.21.2026.07.08.07.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:10:09 -0700 (PDT) From: Jad Keskes To: Borislav Petkov , Tony Luck Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Jad Keskes Subject: [PATCH 1/2] edac: edac_device_sysfs: reject poll_msec value 0 Date: Wed, 8 Jul 2026 15:09:59 +0100 Message-ID: <20260708141000.1764100-1-inasj268@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The comment says it must be at least 1ms but there was never a check. Writing 0 sets the workqueue delay to 0 jiffies, which makes it spin. Signed-off-by: Jad Keskes --- drivers/edac/edac_device_sysfs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sysfs.c index da804ebe3626..3137cf6cf36b 100644 --- a/drivers/edac/edac_device_sysfs.c +++ b/drivers/edac/edac_device_sysfs.c @@ -117,6 +117,10 @@ static ssize_t edac_device_ctl_poll_msec_store(struct edac_device_ctl_info ret = kstrtoul(data, 0, &value); if (ret < 0) return ret; + + if (value < 1) + return -EINVAL; + edac_device_reset_delay_period(ctl_info, value); return count; -- 2.55.0