From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C95174C0427 for ; Wed, 8 Jul 2026 17:34:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532076; cv=none; b=gx7qpiHAyha81CW2tZSGjs0ODMcImzZPYVsoh5YwC8reWpAq1mcXl0v0R8wfWfrPqDpWgtsFLSouBNEqdmH4wT5HtgwkiZ7wCokzm4Az9OXtX2acC4XDvEZ37fnWt17PgVHcQrkJ+hn0VNTVvu7Z2zz7yiuLzVAJrzsde3f/p4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532076; c=relaxed/simple; bh=GxVogIMhu1mzW4YRsiI52i5vAv+yBYbcef61tqhGQOE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tTKLFMkxsidQpZiv+hRg4OuEILm1cmdyK98igvYiJPBLhhRww5Qfgw1cESmM/ghpLtZi66pc6iUGB+rfWzjgtWBgsUZgg5v8mNPErc8D1q1ie7/WdmWD+Uo/q644Ypk1jRoji+ZmqVYMkHlRGAEWQtp+vKSkhj/vq5UvGcdOfMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J1UjfpTv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iKmhvKvN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J1UjfpTv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iKmhvKvN" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668GLKRH3347814 for ; Wed, 8 Jul 2026 17:34:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=YHzHGsRPIUG VAMOUo6qKw+18SGmm5iq6ipy2Wi/zZYE=; b=J1UjfpTvutthxNKGybDQMylMX0+ bWW/hswSmLHfwZJIqwbYZ4iljIWp1jCoQ3Nuq8EKbMFGxLfO5NJu9LaVDILEzF6A 68YDRp+wkPropf0aEmWV4o4gnrOlx2t1iVOXRAPwMezV6fpVLSr4oqXTDep09T7t oCdTuskuLeBGcc8tJMWiZ8Xd6nBJ8HzxkM0rE83WzyMeRpFtLx1vaaY1YVUSffBN q1Av5LM0CZv45GjzcGtnt46ksJq9VmPZVDLMalLfNfa/GJzHLXAWHL7+GzTuena5 O8QFDz/cjPNgSGMuDkjSVEnN+dCiKKfjfY9C0BgqOfQt7phipMjUhjbnh5w== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9g7hk2h6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 17:34:33 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2c354050c34so15892855ad.3 for ; Wed, 08 Jul 2026 10:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783532073; x=1784136873; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YHzHGsRPIUGVAMOUo6qKw+18SGmm5iq6ipy2Wi/zZYE=; b=iKmhvKvNEtqD5HzAGJnEAAh5Nga7Aemx1Y9yBCFti+D08KNsJYE07R73lj+8WWZov9 ds4m4ZotXfCghkWyoJ0yKm6/maYnKV1aPGigthJw/bW/CQ+86KWZMZ6jNuuXj/MhNsI6 1vq4/fgp317u/GSmR3DY1c78Q2bsitf21zpZp04cML1fOInuGjf/Bjd7KHUvHQos1o6O LiMujBNlW3wVdzImr0rlLs9uWxTtK6WmEvQ+8GdIio8XY2AnaTkwY6z2GqmGIMGtRHi7 qoEZvfl/KVgRRDP6vlpyB/3ShxS5J1uz3yO+xyqR+XCLCQmOp3RC7WuTWUKf7GfvfAnL rI0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783532073; x=1784136873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YHzHGsRPIUGVAMOUo6qKw+18SGmm5iq6ipy2Wi/zZYE=; b=ar4iGna4suh3+1ODto5AWJI6zZuT6kX3y5NFY+WRujU17bYHn4mVc2v5pV6omq6zLV +jjoRbPJT2OWQbnupYjVGWZW3/eedaRX4oBJb1OordNOz7c4iPLvuYyNuomOJFCJ3dl/ nnGX2gTvTbv+M2e9ScpOe3b89MAEHiZi8k2xDcZtl7S8c/j8jpOWQSc1322Ud0APoUVY Pg4Jzez1+2qir1/R/a32WCmyTIcOmkMqsDb1KBxmFwAiMWkiMPlm9GGuFAA3ltAjbY3M bpxSYAilX7T2wBP5PQsWYaHsh+kPfz0HaHiTOCcmQLjJg3qtLtXILUY+TBK8iRZsnU+v mMdQ== X-Forwarded-Encrypted: i=1; AHgh+Rqsw8udMN71WRjVw2cVvpkXRrI9vNF/94kgfdHdbTo7INuZ+nfh+bJ2Bs1bv5zCDw8OQLCY1/nMAAcxUdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YylcAFQ24meQCJ1vdM5OcfgB6L8Jjm/jnmzRNXt31z9NVL3VerG 1Cm3TQBGOfUeEEDZAhEV+1C2vmSNCfgCb0+UmbEZvn5fJPjJuGqWOTtrzFJTRqmqjY6VSFijfgr lCQsZ+Bn0zRoXsFBL1NQazsooE3nG07cBp84YUpFqQxpep4tGQXpoepCIId8PtqB6R+M= X-Gm-Gg: AfdE7cnimbugfH2qppMGcAXGBuUcVqBEb3aXxJcK71PpoB4gEFqDPnulN+HVbEikqRU ph96tMWCOtEx5cGLn1/ebnC1AtK74Tx8+6Baq3vNt0+pzDbcwH+AAvEXyPcTp4aCVoqEw0BxVJc YlNJizIRJfAsrhVUCaVBDbJWgLOWTC819E6AY/xTKRPyfMjqNBKS/VBY40TN6q5/mf0fGBIlsdU PC+K9X5LaSI58AoMDs4cFPYRLCU5ooWZ7nM/n4WcvJhoZ3yvQslS39XaA1UmlD152CdU26EFOVn s8d9XiVv8Tm0NxE1ba2mlH5XlrSjejwtRfS2BVAygGqcHfUS1J9ubKXX3Ua7l0DLvGKJwpBvoM+ 4vJkqgtLQW0Dk2O3N57B2W+wztBH83h5JYm4nljGjHhH3XafpqmnrhyK/AA== X-Received: by 2002:a17:903:1a2f:b0:2c9:d8c6:1dc3 with SMTP id d9443c01a7336-2ccea287d5amr32556575ad.0.1783532073228; Wed, 08 Jul 2026 10:34:33 -0700 (PDT) X-Received: by 2002:a17:903:1a2f:b0:2c9:d8c6:1dc3 with SMTP id d9443c01a7336-2ccea287d5amr32556245ad.0.1783532072654; Wed, 08 Jul 2026 10:34:32 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb7e9sm32420615ad.10.2026.07.08.10.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 10:34:32 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 1/6] drm/msm: Fix barriers accessing ctx vm Date: Wed, 8 Jul 2026 10:33:49 -0700 Message-ID: <20260708173356.578713-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> References: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfX9fTuH0yVRRe/ v9G3D4N/bmN6jpI+a1iaEau/OWq1JL976fJVejPsPQFinqGVnEpKZoXN698/C1ZUm6+XkWJxK4I UcgIFu24yuDKwYQ8I9CGEOLcQ6CviLr3dWBIjUbMBCELNVT9IbdLVRfibH2nLqOEt8Udx71AF9d IN1Uj3TgeP00ziKDU/rLjQCpTqbBCL+r2E3HwR6pJzmgOgS84mao8/dnpyrC5FvUyIO7wztZH6f gAH2AiM8a4t767DgqSPHXPQGAwnZZlFVHMWkbWTkvXtQuvuV1SGTeUywv2KhH0LMS5ZUIL9Dzg8 XTL0Ab36wXrP9CiXSgPO3hIFTDUHia76GMjCGM2ZqkrodxIurzwqfKOgmTgA29SmVfPMM6WWY+N 42oeOFzau7rZrGrUEfQGL7rjjI4UdXOLnR6PkErpZ1iLlOqYcHckgxDgpGp4m2m4pHKW/L+XzRr pwG9dhdFxdyaiOVyKKA== X-Proofpoint-GUID: rCRJObwLpq3TMtGp-Gv_zbAaBqQa2wb2 X-Authority-Analysis: v=2.4 cv=TMp1jVla c=1 sm=1 tr=0 ts=6a4e8a29 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=PXeb_Y4BrUyLDKu8J0IA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfXyezooXubzmwP 0P/99ynz6pVZ9k0M7iUbnWSw4bsHrjUaBrnuBhNfrpR0lA96TTuFR+dJIEgeXj/L2PmTK4qECDT RVL6JhZd4Vkus8lCAPPEnAcwNf5jL5Q= X-Proofpoint-ORIG-GUID: rCRJObwLpq3TMtGp-Gv_zbAaBqQa2wb2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_03,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080172 Don't rely on store ordering to protect us from caller seeing a partially initialized vm. Reported-by: Sashiko Fixes: feb8ef4636a4 ("drm/msm: Add opt-in for VM_BIND") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 32d5ebea2596..ec88155e0ed7 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -224,18 +224,19 @@ struct drm_gpuvm *msm_context_vm(struct drm_device *dev, struct msm_context *ctx { static DEFINE_MUTEX(init_lock); struct msm_drm_private *priv = dev->dev_private; + struct drm_gpuvm *vm = smp_load_acquire(&ctx->vm); /* Once ctx->vm is created it is valid for the lifetime of the context: */ - if (ctx->vm) - return ctx->vm; + if (vm) + return vm; + + guard(mutex)(&init_lock); - mutex_lock(&init_lock); if (!ctx->vm) { - ctx->vm = msm_gpu_create_private_vm( + vm = msm_gpu_create_private_vm( priv->gpu, current, !ctx->userspace_managed_vm); - + smp_store_release(&ctx->vm, vm); } - mutex_unlock(&init_lock); return ctx->vm; } -- 2.55.0