From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDBAB4A3411 for ; Wed, 8 Jul 2026 17:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532077; cv=none; b=KG+4YsLLzJtAK/WWTQCvm6u3iK8y2RaQ6Awx/ETQnLYjqlcJBon99TPMybBTcEiCqo3ZVTIMIS1waakpTz4goGKpqg/VddtTXHwA/yuhDAq27dOAtrEbW0I9EVtyKYqXqOW0Uld+JzIANo3gojYsPEo6fBgepXQGWGTDCI8ADoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532077; c=relaxed/simple; bh=OkUH3ciOjWFg60h81ovKGMQgQf7pTQ48VJSsIXSetmU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AZvW930lvvRaVOZ2cr6GacKLAqKz8OXIquAKJ8anzv9vw3YssYkWfVdH89qoCzLRrMMYOOekHLCUbGj/6dx2wfPtUFVGL1dKQf7INrhi0YiZ1qsSJSBWAdVMHVuLOv8BBphNIrFBbnJldRfOOvh2TBhn69kULY1yDG6RHiqLEnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S6xaUCnT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T+Qis4Fe; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S6xaUCnT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T+Qis4Fe" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668GLJhk3347806 for ; Wed, 8 Jul 2026 17:34:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=vOFiS3gWQCJ aLhFgxBelkuMdy2oPlvu9rT+AQ3nGeTg=; b=S6xaUCnTQnFBBaVo/g2/kFoTUia +Wdp8+ZznsOU9ZoACXIvPFMZlSbGyVVAmeeEzEL42RKkxSqR4cNE3MrqUGZvVUku B/TS1/UIQ51DIWbkwbTqzNe4VqoUUo3Xj/Ksj1DFDw3t+PMAGb2qN35T/2GOqCII UxTfZvDvQnWqKnpID33AmWJHqoWo9P106iqWFnfW4gAR89Pu65Z69SRxLDQjOQGq CWCQ28OF6bLaxBy2T+eRgo9SVJ4UOD2DuTl80i4WgqCae+d8CjEJ8SRsLFBPi+Nk Ys/62emyyIfvmT5/K94JC89aRAnv6u6YcNTfj42R0rcw5EFlqaZeTZ46FkA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9g7hk2hd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 17:34:35 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8423f1fe39eso1760763b3a.1 for ; Wed, 08 Jul 2026 10:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783532074; x=1784136874; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vOFiS3gWQCJaLhFgxBelkuMdy2oPlvu9rT+AQ3nGeTg=; b=T+Qis4Fe6O0oT1Bq0DxUivnkn/JAV2zhnL0yTBuG21L6Q52A/1DhHIiUeHaw2DDA7h J/bLbcJP34Q5DG/d18eguwrelK2sH29YJfJ1pXUplDZEICghjcUswyW04wV9IILp277q jhb/qShJb3rqZThu7paP6MpSR7yTzrzMu8brl+/ffAylQwMjE2KrNxrTOLRBrvSAklNW qrMuiepTWALfX1qct+32rRMdf9+WuKiErRxLh+zQn6X9unJh0NEPYV8YVmg7gyTS/rWi 0QqRNHtLPKJsgFszbzqIh3y3819aqeQtF2DFwLdRwJzf4k4W+x5dDQ1LEz/piAloYnNL kU4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783532074; x=1784136874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vOFiS3gWQCJaLhFgxBelkuMdy2oPlvu9rT+AQ3nGeTg=; b=cULDFcw2Digikr0dujOHPOKLt+Ev/MskpODFzOe3lG+2zz4TV5Y098IuldKYm9tOez 6pOWKJyKkzt73NQjr3Vr0ZTrwR2SX9wYT0N/zef2uCFJYFcRY08mVOGUtnEUUTZoMPrw B2awp/ecC84TXkLuDZ6nZ14FLB9idJA7OmNrpItQRQs0kY+gHtXbFl20g+NvYoj365Eo gJCBwFTafZWdZ03xJ60Wp9gD5U11Hp0/wS8WKyOXbUwooX252Kn0/vcz0P/Vwj//bpzw f1ucG/dxRVVgfqqew2L5611qAL/0po1oTCq9QzeX7HHA36isk38oICMNTjVhVSeSl6Kb 61sA== X-Forwarded-Encrypted: i=1; AHgh+RoKA9b/oco6CcnMu4fxQCp2dX8cUFP00HOdoxkSHSOvUqnX9zeI2+b/mYTHz52RxvMoJzrpvH9DWKc7TV0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9yJFeHzVKuPI9OK+O8oRfnvSytb+TZ/W4/quKlcyGfFE0sob/ FX8BH3A3XYRvGmUm0tw1fsw8JtR5lSHoscvtGf2cpSxOYGEh0iDvzsMebuTOL7orGVADeHPfEqv GcYNqUyGkwpsVL5DYGbOfVw5cX9OUlIfpy/n3OzD8exLEUjYGVO8kmYd7m8iIFjycgIY= X-Gm-Gg: AfdE7cmTty3LG6w0qxxnAmEUUaNu0+eKR0g1vHRkI3LgBUtLbAZpOBWlrr2yqb6GYKY UVSAJO791ZL5F0cX607Ivgd0cMCfxcc6pjstRJ7B1mt3pw6BAubrC7R2Wdzfdf0sMkSllk6APjq ujKs7vwwvucPAYZK2rm5OPB4GWiF36G+yHB+pOJnpNGRdnP6Rhifw0k7f3QKCC4LJgnz4sS77TK g7ayJ1qvY9qe0tQfX0/X9ny3YsH4hpAixoqM8OUr0wLqTjwb/IX417SYI/zp1Pf3osxUq5JxOg3 qv67wijFFXGATaB4PK5zLo5hc+fPlZnbHVAlvWU8Nv9lJiqEbvGswdKhLqQ4DOE5gM2QDSDaqnO VHbas11WG7BQzbO4HHSr7eAA+5mRQLA4+6Mf4SupzpI++WAq0oSqJclkRRQ== X-Received: by 2002:a05:6a00:17a0:b0:848:55d3:c890 with SMTP id d2e1a72fcca58-84855d3c8cfmr187832b3a.30.1783532074383; Wed, 08 Jul 2026 10:34:34 -0700 (PDT) X-Received: by 2002:a05:6a00:17a0:b0:848:55d3:c890 with SMTP id d2e1a72fcca58-84855d3c8cfmr187797b3a.30.1783532073913; Wed, 08 Jul 2026 10:34:33 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-848414a34f7sm1423977b3a.44.2026.07.08.10.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 10:34:33 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 2/6] drm/msm: Block VM_BIND for shared VMs Date: Wed, 8 Jul 2026 10:33:50 -0700 Message-ID: <20260708173356.578713-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> References: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfX/uWjBxYpe4cJ yRPIf90UyEdSVxcnzStItbB8OC3OVpnddocYjthf3PkkYB7QHUKOFp70nxWiAa2qpSDvWq+o2zg g6sdJEbNehknNUM9r/89Gz4i9whnDUhCwUv7GaqW5YS9ZrQFIQ7DWx+3RtU3/riB1+8aI7R0net /Ju4kzCGWS6pUtyGyOB7IQpV1xFta6i8PT8Nj4wG2jHksgKS/2sgLar0n2vDGj16gfIQNJ/dQgM FKA7wqmf9c/p+hkCndoGS6C3PXg+xl7OhdRWaR6m+yt5AO6Uv3XtvgKFvEzV8S5hjCesAmko55K C69QUkZWMQmSTzDGBa0/ov/SMzMfXC4e5zUMld26RrQJ9oX4R1jfVaikHtQkm6evtEJve3D0chW 5x/dK5gL0zUU28hjGLvvnAbbZlw1O3BN1XhlWj6h+ihmxRVdVxZuroG+SG+8JN0FIL5C1rNBpYO lyxInNcd7OChKpN5jAw== X-Proofpoint-GUID: SZhzhjjlCqhyToJOATt630x_QPw_SHzJ X-Authority-Analysis: v=2.4 cv=TMp1jVla c=1 sm=1 tr=0 ts=6a4e8a2b cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=GoQzj6LmqzT0DKjVJ_UA:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfXzv6JhBAj+hqS zPED1bpNspDngaq6OdGpiKH6SaUqrwVEFdbTcR4d4mLSVH7PbyK4dyEUjkyiDoWtA4IM+OyytiD 3GtnhqNpIyVW/0B4ebyAKrP7M4VvTvY= X-Proofpoint-ORIG-GUID: SZhzhjjlCqhyToJOATt630x_QPw_SHzJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_03,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080172 We already block MSM_PARAM_EN_VM_BIND where per-process VMs are not supported. But in error paths when we actually try to create the VM (allocation failures, etc) we could still end up with a shared-VM. Since we need to create the VM lazily, for backwards compat, there isn't really a better place to return an error. But this isn't to happen in practice. Just block VM_BIND ioctls in this case so we aren't giving userspace a way to manage the shared VM. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_vma.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c index 3ed05ab0eeef..06a3f2aa3ef0 100644 --- a/drivers/gpu/drm/msm/msm_gem_vma.c +++ b/drivers/gpu/drm/msm/msm_gem_vma.c @@ -954,7 +954,7 @@ msm_gem_vm_close(struct drm_gpuvm *gpuvm) static struct msm_vm_bind_job * -vm_bind_job_create(struct drm_device *dev, struct drm_file *file, +vm_bind_job_create(struct drm_device *dev, struct drm_file *file, struct drm_gpuvm *vm, struct msm_gpu_submitqueue *queue, uint32_t nr_ops) { struct msm_vm_bind_job *job; @@ -971,7 +971,7 @@ vm_bind_job_create(struct drm_device *dev, struct drm_file *file, return ERR_PTR(ret); } - job->vm = msm_context_vm(dev, queue->ctx); + job->vm = vm; job->queue = queue; INIT_LIST_HEAD(&job->vm_ops); @@ -1430,6 +1430,7 @@ msm_ioctl_vm_bind(struct drm_device *dev, void *data, struct drm_file *file) struct msm_drm_private *priv = dev->dev_private; struct drm_msm_vm_bind *args = data; struct msm_context *ctx = file->driver_priv; + struct drm_gpuvm *vm = msm_context_vm(dev, ctx); struct msm_vm_bind_job *job = NULL; struct msm_gpu *gpu = priv->gpu; struct msm_gpu_submitqueue *queue; @@ -1448,7 +1449,7 @@ msm_ioctl_vm_bind(struct drm_device *dev, void *data, struct drm_file *file) * Maybe we could allow just UNMAP ops? OTOH userspace should just * immediately close the device file and all will be torn down. */ - if (to_msm_vm(msm_context_vm(dev, ctx))->unusable) + if (to_msm_vm(vm)->unusable) return UERR(EPIPE, dev, "context is unusable"); /* @@ -1456,7 +1457,7 @@ msm_ioctl_vm_bind(struct drm_device *dev, void *data, struct drm_file *file) * place, if you haven't opted in to VM_BIND context. But it is * cleaner / less confusing, to check this case directly. */ - if (!msm_context_is_vmbind(ctx)) + if (to_msm_vm(vm)->managed) return UERR(EINVAL, dev, "context does not support vmbind"); if (args->flags & ~MSM_VM_BIND_FLAGS) @@ -1479,7 +1480,7 @@ msm_ioctl_vm_bind(struct drm_device *dev, void *data, struct drm_file *file) } } - job = vm_bind_job_create(dev, file, queue, args->nr_ops); + job = vm_bind_job_create(dev, file, vm, queue, args->nr_ops); if (IS_ERR(job)) { ret = PTR_ERR(job); goto out_post_unlock; -- 2.55.0