From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3928D4C6EFF for ; Wed, 8 Jul 2026 17:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532082; cv=none; b=UmwK9gsmoqYkEooljauEDW2XaEIMvYGPV9HhClttPNyFX9s0OXS0h6j+62l4jblTOSb1yucLhUF3SJfVK/UitVQrplWSnF0v0ZJHFMHQTvZusQH3nn0ynqoqhYybvwDNzYVYgcbntLu5yuumqFTsG74SehdqKXuyvOx2AYJ1cMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532082; c=relaxed/simple; bh=2p5x9/agcrww/2CnFOxfT2Jfqi0IRk/KULI//snGIzk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IzU/LmXHpte4CXzvcs3i5eVX2sWug7DtnUEm9sD95i04mC399Uk3fe1jAxlTsthdJrZMmIhEXZM4u+r2kWDRjzOe+ODv4xU6l1jD1KpVTpT8OltQGaaIVu63P6OoB/iNVHZ+8TcuICMOafekVPPLWbb3gUGrlq1+4C9o20ZacNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MQascg2Z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OO6oVCpx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MQascg2Z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OO6oVCpx" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668GL9F43125820 for ; Wed, 8 Jul 2026 17:34:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=F2lLFVQBkCP nTnJ/UWIANHD/oq/CxWFvXtTUGL+m60Q=; b=MQascg2ZVBCkz2MZGg7FtMDgJ1B 87BiOgr3V9ujZIsNHjPQsRyI4LMd+VdMBgTzr8YKwc8sw+SNY3bljU5pMzKKtbIv 63JOTk7xaS+3XmregnEGcwOaoekNMPUE4hYVI4G/DTNUsTY4GQ3BCI+bywDvSDjR rLbMVsuo2XYZcKRHo/mSImoyZTWpSwChzHQ25q0wznPaMu7CHhydZOvENwqRBHop boYK1blOVuw4VtHkRtbNd5XarWswMf0hOXsVxpG/jdKAyzXY3tsMWFx2XMGG7GAh yP+izT2eiYnRvIf/DoZ5T8i/926wCgyVxv5evere+pu/J5VzT2mz1m/tvhw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9q5s9a0g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 17:34:36 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ccd1958e8fso11969475ad.2 for ; Wed, 08 Jul 2026 10:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783532076; x=1784136876; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F2lLFVQBkCPnTnJ/UWIANHD/oq/CxWFvXtTUGL+m60Q=; b=OO6oVCpxXylIegoDB2ZCq3G99AjYKoGWY/mWPJ3mbZmJ4htpGC67zOCiB4t95bkBtu KLLvNtrmrQu6PEuFVfwHfXgE+uoV5WSMEcavojk0QYvwqzNks1Atms3h9wxHNFMlXdjt N0VkXq727VWT0NEbJrvIc8c3+zxiEiZPfnN3Vhmu8MuHf8LMpudaHZP7jquvhUVrspsC 7LrdZdeX90Kk0PODs76WJyI6dlNpigoNGBqXbdl5QF1DxVbh+b6Fbx53PSIplVA7eCci NDUr/mPz8dPpsNtmgkTUCkNlV5F1UfUQd/8FcW+uA81A0mx3LkFmdjqe3o6WOnCJZ1JG eUAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783532076; x=1784136876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=F2lLFVQBkCPnTnJ/UWIANHD/oq/CxWFvXtTUGL+m60Q=; b=QvZcc7Z7nIEc4OEOKsJRrSKA6f+rbBoJX8/zR3I2XsEDVgPP03hHGtGCf49ULkLM50 YS8LWGkvQL5hPPPlcyAUW5CIzgIhq6sgEGdioqH+T86yHp62LYZfGrywtN76PjTTUIgZ pUo10skJpDBrM9yZ/GHzWXPjZP7+ozyrvb9NhmQItoUuLSZvZd1tFiFZML/iDHXOoudu lJXVW+ebKNuKiywgRvgNT354c32P+lyK/vV4+mBvk7u03enf/VgJKPvkOspthz1JZcip vWMDnzcWMXzaliC5plqpznHh/XJJPHoilAiGbaCypzq5uqnI8h38GFI8Dc89MJPDcVCE SXIQ== X-Forwarded-Encrypted: i=1; AHgh+RrshH8wxQ/DbWu1ueDSwmHjKAw7ZxHYCkkmp9xs1a56RiDsUvMaivAzSjFJ+zlJVhaa6WlcMFVBT9zXjwY=@vger.kernel.org X-Gm-Message-State: AOJu0YxfioIlh5kljEFn/RPhBg3hS8afvZ99h7qfgezP1hlSKkFI2Vag U7bPWWkq+L09+uyYV5sgMhYJJ440yobKcQdBEoIkDi1ojJYCUQt8kYkSj7iuzm5cS1uUeldY3Jr CUkMdjX5UH7gGdsSRCGhE3d6X6AkaVO5qgJzllOAg7LSn+Trrb2DA9Zafsj91qqjGEFo= X-Gm-Gg: AfdE7cmbJ3kkUS25QTxwt0FhnVf9g9Tc6GF7mzxQtWyeDNyrd8uexF+G2AMDvZo5b2h yNres2DiVX+vt1ldf2Zq4YzyNRjOffziSrGz1L53DSU+QayATcpc+LAnAjeSlbThVtZlcAVb2hz PpfAncawGP4np3ed0CSckYTgf37evujqmp3DzilEG9DdaRhuI3QZK3GI51ybdjPOHsMXPYWUkW1 id5HGHeNRuIM8KJLeCjrAUwnqV4a+XDzsAwIGB18p3BWaIvRz9DLIQDqHC/9wK96Kkof4DAFsTP nRYNsAwgeOL/Uzu6MSfkSxfE1r1JE0nov2IdQS4Y/8qApn6MV50IRexcEIZmx1ILRx+y1hefUL8 k5XR67a7cldmaFsd9s7uw+wSAu8qZnSoyaUgMEQyoPDKCXVb94itr1e428w== X-Received: by 2002:a17:902:f685:b0:2c9:e2c1:4fb5 with SMTP id d9443c01a7336-2ccea40b669mr33698025ad.22.1783532075693; Wed, 08 Jul 2026 10:34:35 -0700 (PDT) X-Received: by 2002:a17:902:f685:b0:2c9:e2c1:4fb5 with SMTP id d9443c01a7336-2ccea40b669mr33697755ad.22.1783532075114; Wed, 08 Jul 2026 10:34:35 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bfb7aesm31438345ad.29.2026.07.08.10.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 10:34:34 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 3/6] drm/msm: Validate lazy VM is created in GEM_SUBMIT Date: Wed, 8 Jul 2026 10:33:51 -0700 Message-ID: <20260708173356.578713-4-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> References: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfXynD88lFzAcQU c2g3b9pAfA0sRicB+eJelCwpkDoR5tgtRwVda/qVlXUipKtvsKBpdilnJPxPuarv1kwEIM1L0Y8 +X5l6+8iwUhZ2xNS8Pqvn8yknxsSU2wK9iA8QVT3WZXuPWw6kYJ2lBvDaItqQ6MIhcT6Nu7HnpS DfIZkrjHKDWpZG5eaAqK8dfTOgwDHb3lxbewdnBTOyzcL31ZHB/BZhd96IbTyP/pMLzkGWOrlJy JtMy/RD8Xd5z7sVMgttUY4mUIGyJOI5L+rkNxcc3sPD2PqZ9Z1pNzSWWgVGGcx7gw0d1pWBk3Fe JANhls0cMh3iH8+AAsECadyAxoWzUd4aKhCOvrpKx8flGFQhwjQitiiFOABtAHNzg+VYN5xwXWS PQ+8/gxY3Za4vdPeIxGZubyBiRIaGR1Q+C59St+bpF6veZ/uLJOammj3PXmyWKaygxrORDlAYCS iXhFNEza1nNedHSwDrg== X-Proofpoint-ORIG-GUID: -yqODKfJd-9mljN9OHbWXLA3j6xOfdkn X-Authority-Analysis: v=2.4 cv=NfTWEWD4 c=1 sm=1 tr=0 ts=6a4e8a2c cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ZH_LIYEqPuu6AAuj7cUA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfX2mrBq16WlvJV 4vZI35m4TpyxYOALMAfPcs/UyHCCtszi5AII5l8eHukhB8ptzV8Y/wbIhJkNyZrk4mpiQEMAB9U rdO05vbi40lFjORXP4VUERCLMbE5zPs= X-Proofpoint-GUID: -yqODKfJd-9mljN9OHbWXLA3j6xOfdkn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_03,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080172 Otherwise a GEM_SUBMIT ioctl before any BOs are mapped could cause a NPE. Reported-by: Sashiko Fixes: 6a4d287a1ae6 ("drm/msm: Mark VM as unusable on GPU hangs") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index 3c6bc90c3d48..56929e821200 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -30,7 +30,7 @@ */ static struct msm_gem_submit *submit_create(struct drm_device *dev, - struct msm_gpu *gpu, + struct msm_gpu *gpu, struct drm_gpuvm *vm, struct msm_gpu_submitqueue *queue, uint32_t nr_bos, uint32_t nr_cmds, u64 drm_client_id) { @@ -66,7 +66,7 @@ static struct msm_gem_submit *submit_create(struct drm_device *dev, kref_init(&submit->ref); submit->dev = dev; - submit->vm = msm_context_vm(dev, queue->ctx); + submit->vm = vm; submit->gpu = gpu; submit->cmd = (void *)&submit->bos[nr_bos]; submit->queue = queue; @@ -554,6 +554,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, struct msm_drm_private *priv = dev->dev_private; struct drm_msm_gem_submit *args = data; struct msm_context *ctx = file->driver_priv; + struct drm_gpuvm *vm = msm_context_vm(dev, ctx); struct msm_gem_submit *submit = NULL; struct msm_gpu *gpu = priv->gpu; struct msm_gpu_submitqueue *queue; @@ -572,7 +573,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, if (args->pad) return -EINVAL; - if (to_msm_vm(ctx->vm)->unusable) + if (vm && to_msm_vm(vm)->unusable) return UERR(EPIPE, dev, "context is unusable"); /* for now, we just have 3d pipe.. eventually this would need to @@ -609,7 +610,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, } } - submit = submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds, + submit = submit_create(dev, gpu, vm, queue, args->nr_bos, args->nr_cmds, file->client_id); if (IS_ERR(submit)) { ret = PTR_ERR(submit); -- 2.55.0