From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 486AC2D12ED for ; Wed, 8 Jul 2026 17:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532082; cv=none; b=GnXRrORUj5zQEHhiOVp0gDs+9Dkoww9Z9KSWjAjahIfyp1qdvTQixqAB19e7WJ6k1qlb+lNGWUJuooiTLfAVplSjSNAW9lRAiFxRoJU7eMqqd5XA2cLxCzxqO15faqv1C0FFzL5cS1NB5n84ITXjhFdwVQH7RxaizOcqH80jkoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532082; c=relaxed/simple; bh=I9tJsv2yZxCYpVVJfepNuH5FBHbvsIcfOdgszmUj7R8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ren+p7TwVjWx4rVDHZAAfgPkcupuJmjvKXjtUKwAqp+jw0Vh+Wfqn/tGLsIbn/6mGjR+wpsuidn7l+IkSFPLzwlDn0xkuir56sbekSyStl+bIyTTjfSBZDDoWekttdsebcUkCbO0YfDVk1mPOEHQAJ784lJcvaJXDHAxnlTJSJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eDO7R5h1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NOTJmqn/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eDO7R5h1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NOTJmqn/" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668GLnki3312741 for ; Wed, 8 Jul 2026 17:34:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=EhQM9yoBxVO cZmBC5qd4hROEhHqhjZj00aJ/HtUenEY=; b=eDO7R5h1OuGhxKu3dSrkemvFIxD x65fp7ISvzqP0aEiy94TX1nRtV4ITGlqkFhFWTr2zEKfFkI8JbpItIhfgZEYO/5b BayJiS3GebAZ2VcHklou5UhFennNVuDBhsGYmjuD2mb+LTXRtpr8DwB7pUiYw3NY SPn3aNcpku0XXp2ddKHi0thMtsJ8in+YtFVzUW/9hc3BaMV8uH56eez/CnuGlUat Cgncs8wjOq0Ikys0JaSLt+ef6TYzMG3cQayrA7EfmWMwqeBiBah4x8PfFQWORS/I 4rsdKPdjjkYE/PIJtj+/9jACLAgcAqBUQUsIzkkUHZyGTiO7LEAzM5Yhhqg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9c6abxcx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 17:34:37 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cce02cb769so12548185ad.1 for ; Wed, 08 Jul 2026 10:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783532077; x=1784136877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EhQM9yoBxVOcZmBC5qd4hROEhHqhjZj00aJ/HtUenEY=; b=NOTJmqn/RRgefhZ98KEntW8GU9RoxXckYBJPsCgk/4X5nT8xV5H3nmjquZZTJLCKNV mSr4OusGl7HcKIooA8kiVPSSWnI/Chh8Ohadtnfu1zM5Pz6ST07Otz5mFzcrA/go7456 A83la3QsGXCiaFwPrfjWTcu9B3fXTfN+TVinCxgkX/NSHkl4ciCdw3RE23GvCie32jWy +4cIRPe4R1XErVeeFjWHdhSfGtwgT1PO+wPEB9ebSv0AuI8rlMpjIc2zz0I5Me4LDp9B l6iG0/CBGEwlyEAXXRpAw4FImEVgwP/NMSa8UAvY7BL6m6uKG99dII+aCdxlelSw5IAd kvaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783532077; x=1784136877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EhQM9yoBxVOcZmBC5qd4hROEhHqhjZj00aJ/HtUenEY=; b=J5dVMcX+0mTSorfgFO5s7wYEufbeetJmKEyXWkv7PQakTboF2SfDCGfR2J2vXW0psM KiojPLqn3zyU4NNo5mVfxInCTun4lVO3XGUUn6bn1ChqBanwGsk8V4NNcvE0mksc6mHY fWIrzl0YpIv1ju/8sB4s0wgqEMou63JjE0HK+5V5s0yolZVQ6twC+anhgVIBfTqz8Htf 4kWaYf/xM6J81VqFcaZeynSZLEDSBMNXel7GLmIIFifuahlO8X94CGYWur2HTs1DQGsW mzyVlsdJTLVSTK2O9/Fm8uTotxXeBt7XIMVdXoNpEuEi4BzDKYCfbyZHg100LihI39qJ vB7w== X-Forwarded-Encrypted: i=1; AHgh+RpkuaGOViRfhXkBBSetuG2TG/xaKz7kNUACuzQjp9TO7DTO5P0isRS5H490X1hy9rS/IBQiJ35Hfc7+7J8=@vger.kernel.org X-Gm-Message-State: AOJu0YwjvzOsiWrXH/oubNBYd5Ez/tPU2gp+I0YaU1jqlWP2LksWT0t8 mOtC0r5DADiR5aQBzHb4p0Uo62XvpeC06fM9x/z3LcWfKiv28AmEinAc0/Oi8ffD9gc5BSA46Xh /uxhKniY6yrpCg45/EbVLOtpC0wdATjkkeE5Bq/0lplcX4vtcl7fDCaUXPgrawN6RyxU= X-Gm-Gg: AfdE7cledst7qSsuiJcxN29/G4/+gnMTJzg5BFccNaDvLrSML8zHHhgbO7r2gXfQchQ R6IE/x3DJqB1o1f0SSWVlC4pdgJ/+xZf4DxVb+CWJALhFPj2omQ5nKlU6pLL0YMrsM2570JSlTk p6dhjnGNfM8VM5rjQGCGhWdv7XsZn8jPMFnoYXO8vGxyC1DAlSrJALowc8Cm3LuHoZtTNSxKyYr jzZ3Tu9s8kSx4Z8uvK4M9yPntpMflftHE9VxXCfwzjc5A0ul4QRzKPhrGK/yBFn+IxyoTC3w5Bt +oH5NHkIMaMyZsYt42pU44SKj4Dm9gQUMU/NlyiP9mThqCsZ9rZv6uwaXcZlWvZZYXscmZ8E/wQ jlvtt1l4b5r+B7owcdzbhAMhSkG63BDrhPsp2xBYbXQaMVNIb3MN/cqnzug== X-Received: by 2002:a17:902:d48f:b0:2c6:a981:b591 with SMTP id d9443c01a7336-2ccea40c7b2mr36562205ad.30.1783532077033; Wed, 08 Jul 2026 10:34:37 -0700 (PDT) X-Received: by 2002:a17:902:d48f:b0:2c6:a981:b591 with SMTP id d9443c01a7336-2ccea40c7b2mr36561855ad.30.1783532076592; Wed, 08 Jul 2026 10:34:36 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d3d57bsm30956125ad.59.2026.07.08.10.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 10:34:36 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 4/6] drm/msm: Validate lazy VM in GEM_NEW Date: Wed, 8 Jul 2026 10:33:52 -0700 Message-ID: <20260708173356.578713-5-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> References: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfX9ow/vLZtpiMH 7n0FdZz1BI4XL7Bt+9YhoygClUQ/d+704vNwBFwC7NYe8FlwCT2mAxlp2apmcn6WQvv6bOh13iu ce5ukeuSbcatdDjzNQ0OzveEUQSSZCoM8PedpTibR/+s6Wh+FXcZjoot0YZYAVoMNgx4wEToYdj 8XfByG/Alk7b3R3MBl3lCh4FZaoYU8G2WQeyRq87X8ivoSzQSZYrjqJ8dIiDFM8DJPQDwjwAhqH tJ+POuc5p3vM2O18iFvWeFkPYatD7jtt0uNbI4/XAfi+B5Jw7cOWr1M1wDDKdYdnoSU+gj5hQip YhPMzYhI1g3iRBlB+Cj9zBGskF6B2ubJRE+miSu0sOYr0rLg86HASM8a2Hfg6z8NOLl3Xj/SHjS WEniifPPUOHNxwU5DXyj4A+TtVXIIkQ+KaI9lFl986gkcwEZcZ11TB8SrkaXEvE51SDLuL3h2IA rsyKPenRkxjEwkyNE9g== X-Proofpoint-ORIG-GUID: dkUxtEfghdtGzU6ZMWZeU0OzWagV43hQ X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfX/iFXxo7gfzU5 YvJeK4NqUqIp/AvXudAc8pSuIkl9AwvcNGuOemMVQqESD9JbqFyt4eFOtVYx7KKulkhVIqUKaP7 RQxUquZOg6B2KeGBr6W5quR53tnsYkY= X-Authority-Analysis: v=2.4 cv=UehhjqSN c=1 sm=1 tr=0 ts=6a4e8a2d cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=mcLY6QNbnPi337aWdgEA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: dkUxtEfghdtGzU6ZMWZeU0OzWagV43hQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_03,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080172 Otherwise creating a _NO_SHARE BO before any BOs are mapped could cause a NPE. Reported-by: Sashiko Fixes: b58e12a66e47 ("drm/msm: Add _NO_SHARE flag") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index efd3d3c9a449..4442cfa55b00 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -1146,8 +1146,16 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file, msm_gem_object_set_name(obj, "%s", name); if (flags & MSM_BO_NO_SHARE) { + struct msm_drm_private *priv = dev->dev_private; struct msm_context *ctx = file->driver_priv; - struct drm_gem_object *r_obj = drm_gpuvm_resv_obj(ctx->vm); + struct drm_gpuvm *vm = msm_context_vm(dev, ctx); + + if (!priv->gpu || (vm == priv->gpu->vm)) { + ret = UERR(EINVAL, dev, "not supported with shared VM"); + goto out_put; + } + + struct drm_gem_object *r_obj = drm_gpuvm_resv_obj(vm); drm_gem_object_get(r_obj); @@ -1157,6 +1165,7 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file, ret = drm_gem_handle_create(file, obj, handle); /* drop reference from allocate - handle holds it now */ +out_put: drm_gem_object_put(obj); return ret; -- 2.55.0