From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A5AD4A13A0 for ; Wed, 8 Jul 2026 17:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532081; cv=none; b=svd6tlnTFsjf7l8lr/4eKHWskLyhm1VA7Vt7dOGw+avKp/BoafpfjeGZjbH7BJuiIsDtCRMekKfOSs/x4qhwqKZur7M6xByNyXyzJyceLiTWUwnAyfdL0KCvmRxK82YJib4QtpxXqzRj/9CZrvj72PGY98T3aX2JYjh5BM2wUdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532081; c=relaxed/simple; bh=2JBv2Dx0yN9cj/0vtOJrmtab8cG2Ab/R2H32fmdXzgM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lCJyow0lCK7wNar9vhPqxhaIRWFQ0JvAf/E6MXyYAMhwaYiit/VeK+2BAHZkrta+ywg9sKVdPrJ87TRrO411W0R2Qqzh4ZznkmNcvL5tDLz8mu2AeQu1kEIK6Lx7QXv7XesW/JxKBzixF4xlnq7EZJV7S5ijqKvi/ea347aCDsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GsFV1zUD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZbVovCZS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GsFV1zUD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZbVovCZS" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668GL47k3347337 for ; Wed, 8 Jul 2026 17:34:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=il8ffV2n6Of 1AbVqvM2H1wzaQBsji1DJs+ts5z9fiOs=; b=GsFV1zUD8LoeoHXrsCAOY4Oh3LS nL0mOK9f5l3yyJiurMX9MTNThAT1BOTk6sHRzfRniUOiIGMoDjf3XlLoyoyWjMWp ziI8bF7rzk4PR6R1kWNHlG+RqIdulaybdD+vbGVUs948XOkpSSCmQgniaTSiMhye Xj9godHQfn0Ds5sqc4MzEkrnLneROoKP/PduTaoiIYfAlmkeUNrspWhuPCRkodDz 8lw1GOqCf28yku/is8aYqwx/RXEQd/8WA/h0/UwQFuZl2CyBCAFqbol1O7nwtRx5 t/KXSoStrF2lX8+SCoXITbgxk+lCPFupbPAIayyIwapj+D5WTuobRG+LS9Q== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9sqs8d5a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 17:34:39 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cca3673560so670805ad.1 for ; Wed, 08 Jul 2026 10:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783532078; x=1784136878; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=il8ffV2n6Of1AbVqvM2H1wzaQBsji1DJs+ts5z9fiOs=; b=ZbVovCZSIfT1RRRkY2bPNmLNyBWxjXaRDPfIMMqalzCLsy3NxBMmlsdOTFhUjms/R3 kU3VsJRIGMoVJD6nUP9PjuvgcvUWzq3D69qZ+xCsAbnoVuHNfzx/Ul19OKRlvYHvaGxP ulJBsnuZMJkusDmnU5MRIIusO/zkt3YJ1PU+xUIzhmovEdf7QXBdsHnKl5DmKAs5tj7w IAt1eNys2zHNXMQqe1EjIXNHe7T6pgWgiiTovZCifVxWBDy3XZE8sFzdWFmXy1K3/yrP ih8V+0UAm4Nu1ZqzTu55VDmnzwptxcaaG+9vE77J+u1H81m71o9mWmdtL0FpvhCFh4wk KzIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783532078; x=1784136878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=il8ffV2n6Of1AbVqvM2H1wzaQBsji1DJs+ts5z9fiOs=; b=ROHGEL9qByL1VG5zD4Q+oyrIwmOMsNb8KkYLcF1JWzgc3CwPCB1aPzxYmeEsgBGVUi KBUm7pfiR6lXUwEK27oK1eeFDD2yVjDHmFgj5+Rk4+5l03dD08GQZFHs5O/7rMF4I5be yGBN0Ze9TyEv99TwMfzgtNevU9qFyDHq1fdNzxTunX7lBUPoamvuzInYp3ePWYk+GZFw Ue3f1zSNLIfxs8S3mh6PJbXkeXZrd1uwvBKln4kz2wcDoLKgMTe//GLTchOgNFOB6Kjh 1grCfKc/p2nnouiy19RMz/UYfCh7/aHpjRN/oVvsnrgb6SYairWQUAExfECaig+da/e7 ermw== X-Forwarded-Encrypted: i=1; AHgh+Ro+pWoBel68qjnakQbr5BLzh+P5olFzeKqMh6CmIhPEXeRy+obEYHyHgfxd0E41hiVw4+nOXlWnUFUkqFU=@vger.kernel.org X-Gm-Message-State: AOJu0YwgKEq195xoiI8t9v0mAs0HDsLc2BVYqnsO9pN9qdpMeGUNRQd3 j42G1Gjkxm67f0v1wMAiqJMtNJzv0g8LSB2Z4MdJtQwZ8eJIWoajKKKse3YVASIetbw6AEnQe3r enne1e+//KfaPTr2Fg9lA9mYdNmKpk9aWr1n3xVPaeamkwujCYaZXRzoqDf5z/9JX3/0= X-Gm-Gg: AfdE7ckEstwlQOlvxDr3Mdaqb+LRBMeczITNeQ9lakczY/0I9Hh5rfGH7XhTNdc0eBU rgN+METmOkviD9H8kpXNvuwRzT+naDbW1B75mIUQUv+ek7yBCtt33Sq9TXZcWa+GmPIQu7KkCxg zVpkHaBAZeRMEzXiJ8l5cskP8YgRc1U22kfRYqP1JUNyCp9NMSgnr73iHxxhByvz4nDWG2Vne4/ mYlPzjw2guCze9CN8ub/REz/WGgk/P180tic6kR410eaKlwRQtAasfvv8ixv4R14dzRc5yxgPk5 LbxLymyUcQDjVqxhjSANrR8Bpq5xBjrK3s6/pXx0gnRvSxm7r0YNC0+D25zbBN90PMWOODlIke7 bBhx1T32dBvw6LiaRgUor+iyi4AzinLtNLtbM0BElO9307Fi6b7c3wbsqXQ== X-Received: by 2002:a17:902:f691:b0:2c9:a247:171 with SMTP id d9443c01a7336-2ccea371dcfmr36609365ad.1.1783532078337; Wed, 08 Jul 2026 10:34:38 -0700 (PDT) X-Received: by 2002:a17:902:f691:b0:2c9:a247:171 with SMTP id d9443c01a7336-2ccea371dcfmr36608985ad.1.1783532077898; Wed, 08 Jul 2026 10:34:37 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d3bcc0sm31168865ad.67.2026.07.08.10.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 10:34:37 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 5/6] drm/msm: Fix per-process-pgtables check Date: Wed, 8 Jul 2026 10:33:53 -0700 Message-ID: <20260708173356.578713-6-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> References: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfX4Azde7v6TuOd Al0mDv+1EFHIN7oqCme6bcn2+lCOabtDq0JprywJYI9VxVPBihC637jSzNuuzxseMprah43Hh3p wRkcG/k2sJ5d3JyRFmo6Q5hrhNulfN0= X-Proofpoint-GUID: r3_L2nfRAnZAJWSoqRAgzrzYRd8wkgGG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfX6RP3nCvm1x57 S0ypzK+KOKRlsThlUEZWcaUs5VjgzRIxndHtrt6IBjhgKnvyvhlk8O0kDQ0deL4dG4P3MgC02Yb IWqQ7RdasUfal0xrt8fKIGXtAoaMTT6/wMoz+xml/hAkVVU3vDoSIcMZ01KbLmZ70qaJlGKcisd uzX0UBJLK7vF8OZ/WmjBHyQ8fUKA7d9tqOzZVPWSoYQDF5j2aY8cPDItkkb1F+Mvbhv21T2lIds a+IfC11y7lTgbdWZZDA2qfALC8RkjGVEL0zkbcjRw3eZMhuYON+rMIvLiblo79+0y0IHBYoPFya IeZP83wbyo5jh+sqFRraLq+sxtc/jTrRVIE0ZD+E0R9tPogjTsSqjvIsJr6GZGMBs/CV0uzM16L L+YO/ID4uOnB5vCYH0lwqS93sTNeX38qCHnDPuQsOBZqglUyAwuyUjCh+AY9ojEBx60lswQrdgy m7VRiUqtIeud+vW0icw== X-Authority-Analysis: v=2.4 cv=Sv2gLvO0 c=1 sm=1 tr=0 ts=6a4e8a2f cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vtH2vi951kckHO5NeAIA:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: r3_L2nfRAnZAJWSoqRAgzrzYRd8wkgGG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_03,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080172 ctx->vm should not be inialized yet (or if it has, an error is returned immediately following this check), so this isn't a valid way to check for per-process-pgtable support. Instead just check if create_private_vm() is supported. Reported-by: Sashiko Fixes: feb8ef4636a4 ("drm/msm: Add opt-in for VM_BIND") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index c62c45bb0ddb..bff2a773c0d4 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -505,7 +505,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: /* We can only support VM_BIND with per-process pgtables: */ - if (ctx->vm == gpu->vm) + if (!gpu->funcs->create_private_vm) return UERR(EINVAL, drm, "requires per-process pgtables"); /* -- 2.55.0