From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3505301471 for ; Wed, 8 Jul 2026 17:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532083; cv=none; b=hUMseFdT3nCFUmlNYIUQovwJ6UxuHeYpJk+uzeiVIYr4tA0bqCIzleSVtRb4K3OOYFdwCUTDhgohJ8lDzf1bkIMHi4joZirAe8kUqIyqzvhIsgsDU2NFF3fEtWqc6PMszjmfzIMcaz+B6YcXIHVDsQBrVGemURa8e05+WfBjWFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783532083; c=relaxed/simple; bh=BCZ9gxEtHbFunXcuEn1RP6YpAHiMBUKxnhNwFVlf8Ms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O/MtRxXHqsSkD5kjmOBfzSpgKAlHV0UQXlqQmiRPNlqTyHQh4sMw/zgDXGjIpmwV/E66iHEuPGb8JJV0zRg/XS695Upzm4fIcMdATxYdYWrCWs+9146kfYzDsvWhrRS1K8R+rxSwcGDcQshp5p4EpDE9yRBNb+PBdBfZATm/SKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RGh5PJqY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=j97Uy2Ip; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RGh5PJqY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="j97Uy2Ip" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668GL5TL3256471 for ; Wed, 8 Jul 2026 17:34:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=jO+ZQEMTAut fU7hx9qwLY9HF5Xgg9vMbG+XmEcF/E20=; b=RGh5PJqY0fPWIzSS7aHw7yBNWx2 KKAQNxvzc9bKgQp7jj8Gu4K4mkBll4qgEg7aN9dQcubR4UvyUvnXKVuDwW/ESqMG O2fpFdg4zh0HmD/S/2Pcr2nnC0YdnG5ZS8HoDTMmkX8kqRdpovUkp99NcS0RmqeI pceqwJILItb98ZuZg9dzPDZABW7rhwhq95vPGdVaWkx/G0U6hXccldTouuJCM29w L9F96MjjAFWWGQGHUSefZqlIlhIfESDgDfKaPa2dFjtudpmn/e02mtcrFvaqBLZ6 PtRSlWUijYdnnvC+iiQM2VDhEfFdIMsQc6PNCNJuy/fZuZOwsBiPVWDnkRA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9sqw8dj5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 17:34:40 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-380b630c505so96849a91.1 for ; Wed, 08 Jul 2026 10:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783532080; x=1784136880; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jO+ZQEMTAutfU7hx9qwLY9HF5Xgg9vMbG+XmEcF/E20=; b=j97Uy2IpsFJ0y+ox+N11P5XpD2giK6rGplrqpt0u4zZQHvfJOfnYg35YBpl074bbju gwwrQQVmA9xRB5p15DMsR8WPlea0Qdr5rkA1s1N5e2u+U6W3vLHrgazPHlH440PjsD5s jJ7/XXbQeVOThQca4w/PMUwBd2opQcukAtP9AyhZNWu0VzIWqH6fRRvqJdReCWsnFDdg OMcIaiGqDYPTTrDe/7z7p+S22hpDYm3ZJxvdodSuPKsuJsry313CXH9fB5k1QFhGNu91 tNGVI5JJUgIR3UP2q1+3h+UebNFcWiCYIkJKgmMh2XLIdjvkTEJpfAkvHT7P+F1FG/KU oNRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783532080; x=1784136880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jO+ZQEMTAutfU7hx9qwLY9HF5Xgg9vMbG+XmEcF/E20=; b=MyRV2OtifXGFfJ0PUIlO6I7Lolec5X1Mv0S3MX5B6gTi8EnYJAoozQjyBCkhlg262G E7vZaBLXiCENBGHisxhUu7+FbYwlgbXEFmnDcvAg12YuC9or6pbgq6of/nblVyePH+7V H1XaqA/7PlCu9I5dNYgE0rAFZ/f2JTNult6LTrYUi/1pJ0pl7dsOcvIZVTDeaD1mudoA zpvXX4nYyCcau63I1o+KMfprAxJVVl3p1a882ORPzPMtAuQ8FKIHwlSwAEjY7qJe9mNw XvxzULpDer5W+Tu4IvJc8Xse8Mm8f3iKhafJCLDxK6MTnzSs1p9Fsv0n1KKHHS3T8S/7 U3Ng== X-Forwarded-Encrypted: i=1; AHgh+RqcJ6j8YcdUlgnhl3PqbQ/zS0iTVNid9NeNujvn4i7MfGzK777OocvDkl2GPky1i/onPzudF0RJV4WsII0=@vger.kernel.org X-Gm-Message-State: AOJu0YyHxTCr9wVTXRZyBt8dZWO/sew1ZUK2b3Aa900/Tle/lhraeWbc 3Wqk/O7pZKWAm43a/Z4++K1ZbORIGut/TKCD0UrjAZ4kB3UvRQbmcEKDGgZUXANVxujd0oBGE9x gZeuwbGlqXw9TuFm2Urpxz8o2EBgJzFcjPrc9oIcVjqQ+aW8OKDi5tBLCatxLi2w5/wE= X-Gm-Gg: AfdE7ck81jA1deiOF+gIsIXcC0GGPcnYfyjxcJL1E3pG7rbPhOMAbKnUVZoA+t4Yx0Z bmNOfz7kF70CN4V4hSg+rOKm3NJ87MC+r8H55pooT2p0GlUYMPCCdiPDsTYgSkR34cMeRz7Y43/ DH/94g3XOxcG3PxRvgJNlRm8vQjEzNBgubBwZfg5K+jADlVwcmJNg5neltj22NKjDJVbxs7g3NK n6Vsupz9YrmXvkFlwlodzhZNWPXauLECo3gdcYdZ6Zm/zqfUDsIkQ6ULcPwyfw7MGuaHg3XwPRH gJlOqqU/oJxAha5oeOm2NjK7EP66szCMroQo13IwsY6VZCKqq3RA7v8MUNIJt3ZK8kCnCxfByxP MdG+eHBwBD+NkgsjFs325BwMNSK6NA37vV9p/MfXgSoBPCjvwb1obrrbo3w== X-Received: by 2002:a17:90b:1c0f:b0:381:18c3:1b99 with SMTP id 98e67ed59e1d1-38941205917mr4211062a91.23.1783532079716; Wed, 08 Jul 2026 10:34:39 -0700 (PDT) X-Received: by 2002:a17:90b:1c0f:b0:381:18c3:1b99 with SMTP id 98e67ed59e1d1-38941205917mr4211039a91.23.1783532079282; Wed, 08 Jul 2026 10:34:39 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38903295585sm938106a91.2.2026.07.08.10.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 10:34:38 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 6/6] drm/msm: Remove invalid overflow check Date: Wed, 8 Jul 2026 10:33:54 -0700 Message-ID: <20260708173356.578713-7-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> References: <20260708173356.578713-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfX1U9hS32zSJgD UDE9ug3dmoernnkKwPFKBvdtC9ZIH3LUyxiVphgS4uLtyx5GZR72tQPRf0m9rW8+4eRpqgnLsdY MuYdOnUOtCcKQjb2mXFZFVxXS0X7Q4bPXqnHxx6iQuGAxPQbGETHeiCDYQPM9+mfxkwU8In79BO Vwd5iNXZkdGd0OdcSmzPjFmYbAxRAOIAuszugpqqLzUDtXFwrS91PHDNnZnivGXHrJBOw4Deycw Ldo8pxtdytRXd1D7KRwX+VhYXDUOv44SDaOrmXIFizr3yHUyzmc6Jvviz2Ucraa6ECDDAHxERA5 t8StaXYy7kkA0OV3n0JaYeNZeFAxjBPwf7Fr5nBBiu17PJ7SuI8MAazz7FR69DWhg6RnK+GkKDY 0ZqfB8CITjR5fIVXHI3UweQCJa7Ia/438vL4jzlOZz6c8iXIxP4dEO/c/NphV5w/2IvoeBFwJsT N3UgDQS60MCTOA8jlqA== X-Proofpoint-GUID: wy15hEj-KBxMN21g5bSk984lYut_lwNA X-Authority-Analysis: v=2.4 cv=fMIJG5ae c=1 sm=1 tr=0 ts=6a4e8a30 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=0g9OVxrcTuodNeR8YWUA:9 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: wy15hEj-KBxMN21g5bSk984lYut_lwNA X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDE3MiBTYWx0ZWRfXws01PgQSrHrt bbfbfogcBymYYzO2xNA9og68BT9iT65cUbPZ7/Pc9pgfr3HXqhMneWCOliXShqUOz+2MSm5LTIL ZZuRR49wdPKFE52p7gAFHZqvYSCdhkA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_03,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080172 On overflow struct_size() would return SIZE_MAX. But kzalloc() (and friends) check this already, so we can just remove the check. Reported-by: Sashiko Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index 56929e821200..3113faedd04c 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -36,15 +36,11 @@ static struct msm_gem_submit *submit_create(struct drm_device *dev, { static atomic_t ident = ATOMIC_INIT(0); struct msm_gem_submit *submit; - uint64_t sz; + size_t sz; int ret; sz = struct_size(submit, bos, nr_bos) + ((u64)nr_cmds * sizeof(submit->cmd[0])); - - if (sz > SIZE_MAX) - return ERR_PTR(-ENOMEM); - submit = kzalloc(sz, GFP_KERNEL | __GFP_NOWARN); if (!submit) return ERR_PTR(-ENOMEM); -- 2.55.0