mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Steve French <smfrench@gmail.com>
Cc: Steve French <sfrench@samba.org>,
	linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: Fix support for creating SFU fifo
Date: Wed, 8 Jul 2026 20:35:54 +0200	[thread overview]
Message-ID: <20260708183554.6wxt7qkdcwcehn2x@pali> (raw)
In-Reply-To: <CAH2r5mtT0-o-jTdtOEsGe8wiO37kEmxjYrrts5L0m0pen+sb-A@mail.gmail.com>

I have verified WSL and it does not use "LnxFIFO". This looks like AI hallucination too.
WSL stores fifos as reparse point of IO_REPARSE_TAG_LX_FIFO type.

On Wednesday 08 July 2026 08:55:02 Steve French wrote:
> AI search says that "LnxFIFO" is used by WSL?  Have you verified this recently.
> 
> On Tue, Jul 7, 2026 at 4:13 AM Pali Rohár <pali@kernel.org> wrote:
> >
> > SFU fifos are natively supported (created and recognized) at least by:
> > - Microsoft POSIX subsystem
> > - OpenNT/Interix subsystem
> > - Microsoft SFU (Windows Services for UNIX)
> > - Microsoft SUA (Subsystem for UNIX-based Applications)
> > - Windows NFS server (up to the Windows Server 2008 R2)
> >
> > Windows NFS server since Windows Server 2012 uses new reparse point format
> > for storing new fifos, but still can recognize this old format (also in the
> > latest Windows Server 2022 version).
> >
> > SFU-style fifo is empty regular file which has system attribute set.
> >
> > These SFU-style fifos are already recognized by Linux SMB client.
> >
> > But Linux SMB client is currently creating new SFU fifos in different
> > format which is not compatible with all those SFU-style consumers. Fix this
> > by creating new fifos in correct SFU format which would be recognized by
> > all those applications and also by existing Linux SMB clients.
> >
> > This change affects only creating new fifos when mount option -o sfu is used.
> >
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> >  fs/smb/client/smb2ops.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> > index e59fda1b2230..1261b928edee 100644
> > --- a/fs/smb/client/smb2ops.c
> > +++ b/fs/smb/client/smb2ops.c
> > @@ -5293,10 +5293,8 @@ int __cifs_sfu_make_node(unsigned int xid, struct inode *inode,
> >                 type[0] = '\0';
> >                 break;
> >         case S_IFIFO:
> > -               type_len = 8;
> > -               strscpy(type, "LnxFIFO");
> > -               data = (u8 *)&pdev;
> > -               data_len = sizeof(pdev);
> > +               /* SFU fifo is system file which is empty */
> > +               type_len = 0;
> >                 break;
> >         default:
> >                 rc = -EPERM;
> > --
> > 2.20.1
> >
> >
> 
> 
> -- 
> Thanks,
> 
> Steve

      reply	other threads:[~2026-07-08 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07  9:03 Pali Rohár
2026-07-08 13:55 ` Steve French
2026-07-08 18:35   ` Pali Rohár [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260708183554.6wxt7qkdcwcehn2x@pali \
    --to=pali@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfrench@samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®