From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A3AC3C278A for ; Wed, 8 Jul 2026 18:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783536817; cv=none; b=EVo7D05OhhdOZKWuoVhnFFTfZ1708Dgtg9vA2NCRhnpfuU3bwtdvhzCmhCVEX06poiiB1Th1ZE0irsW50QPZWG6/h/Fhcqx30Qj+gVrSCA4LlWUCw5lKI0njKMEwaCwmkyCeVvnYXIkILZDViYMqdayDb0DUwfFZ4FihQ9wC+EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783536817; c=relaxed/simple; bh=auKhlcHAZaqly05VI9TXDKV4vskrttOa3zEQbwSam5k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cRoOZEnZtxkYHwOL8Tg8FEfO5NrjmNu2LplcjQP5MiwEP+ak1Qw0XoEUvGeTA+iLXJSPW5LaE1geeoYoh4oDoqJmVBZNsOueWzRIiKBhjkw9STcOVr8h2fhKvtod5rCdILWQADAGAghFyF9QXe6dwH6bDQwhlCgUS1pQxacn338= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pzn6zAx3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P4zAhSZB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pzn6zAx3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P4zAhSZB" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668GKxeo3304124 for ; Wed, 8 Jul 2026 18:53:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=MDd5hUGl91pvH2nEiZvHsBpB wd3Dg/kjAQn4WJRYcLM=; b=Pzn6zAx32z/ioGd9q+dGf95FcLUV361Rgr8snpUZ AXUDDl8H4xBi27nUisuSsrKlBbAi3yVvVDWUqWk/4g8P33d5Y8cMcEHjM4mV3Ysj 6wT45Y93lvgq3qtKD7QyBK6mnKSrURK5EpCYWmg7wYzzObkS8AKf9OXxS0zj3BMw 0ymhVUdZYzWMpUnvTk8zUTLEUswZYyWtrStGD5jBqwV+fLXiWhr2xcdYbkhJAH4J DxVCwO50bJCFx8Gt2O39TOlXL2U5msYKt9ljvHRk8e/FB8RC3p25oKuOT4+39SUW fB8X6I6jfIVK9oswSOlBE7R+j/w2Gcgnb94+Au3SymeIhw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9rq311nc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 18:53:33 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c88ad1558f4so193759a12.2 for ; Wed, 08 Jul 2026 11:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783536813; x=1784141613; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MDd5hUGl91pvH2nEiZvHsBpBwd3Dg/kjAQn4WJRYcLM=; b=P4zAhSZB+sHipdnir3JIcmLCuopEWORC8HhmymYrfu/zhhZaZo1dVXbtC8EP6aj22A V6f/+5Xynn7jqmakC+BIsORLM8BwFLC9vKf09gU2aviRDTooOj39f+qMQA9h4nljilN0 k3Q18ao5cgsNUiOZ63rwmPlQmhWgyLKxTw2JNajOByJ8xFjEghdu5wt+n5a7FlzFft+x No8ep3t0fqRP6yXtRsX4PzGUzfGhn/7pin6ouPr4aTxeiVMXIeWF1sDLkd0gUclDTs+r 0RGJ+UhgS5DChtxpnLDZDGIuhtLA/+yQ9X/+xa/c492g8+19KGLZqF2/M/NtU8CMPA1u CBKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783536813; x=1784141613; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MDd5hUGl91pvH2nEiZvHsBpBwd3Dg/kjAQn4WJRYcLM=; b=a/uhJRPq4TH1T9j7aq/qqXycQ3AAEJ4D09iJD5eWzZFyIrAi6HK6LtWnXvjokqX96P bCw57f+ucTbKK/RrdWVyqs52wgCONO0REx4rcmd+AaTpXxk3h4DGOvqkcp8tRP+pJShC QS6GYvDL3Hfd//qfSeLW8zVKkr3fj3Kh3/4SPmRWxJlmT5DtxDyyHGHK+JZjy67PLSgc YZDyMfXrFm37T7Lc4n37fQKzgdfKeyLRJjlV0iNETWwe9nxDhBiWkSrG9YjYUq3zvKfu fD+QXstce7lAVcAVyoVsXlQxvebI0oexvNfy7cdNEj9nGJvtv1FGVmFOEskTD08eP20B l+xQ== X-Forwarded-Encrypted: i=1; AHgh+RrjXQ/ZHr07efiUHt8gr9mTj/Ll7aHyujKrPJhe/5YubqDktp7hRWqvNCoLMiwkUR+yrzRyJjBRSIAqhk4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2HJtBeQ1eMp7iZisJ9Pg+zl6at1N1kDXYBTU3y68kKSUOg+rh k1uC3aSD8BtT2lhV10Ii54x29ymCEyuTfy0HBU/7RtbfVf2DHQCE4rdSqXlk8jiPNLEifYRiq3f YSgLr5EBdzV9jHM2mpBU0VMYKoa6k4fk+LqysvEz1V5gBa0Q9SrK/pCEPCyVvfnKAhb4= X-Gm-Gg: AfdE7clczS7+kb9lenAAJz6K4dM2FXgCeJZPiz02KXE10kCAP0Vq5rBZcGeHZdt8w/f 18lD4WjTdYBGlC1RQLfqtITIQ7lERqiTGKA3vErKsalgJmZCjJOO23ANAXtRDVCLoAFukMeE2yV mwFxO5r5CF7tkilzMiBNeDIME5VHg1JjdSsjQmJmy7jzTCT9w3UhUd9XOxVN+zPrGGsoESElGI3 iFPiz2AqOGhMyMsfB7luv5tsP8LxInZ9CmV2dDmbXpD+H0GFYbz62aqHbb2cV1Yt//9MKqoD/qu cMru4hXj0MiqhnJiKC9bm2pUP8A4oLk6+MuNjTQjaNDb/RDJKmj9rBLaOolgyRxdK9gFiVNaq0m oGhnVkom9hgNiPQbBcQ2JCPToy4Ez7OhB4mx2zA== X-Received: by 2002:a17:90b:17d0:b0:382:1aaf:4bab with SMTP id 98e67ed59e1d1-389416e7dbdmr3591592a91.27.1783536812864; Wed, 08 Jul 2026 11:53:32 -0700 (PDT) X-Received: by 2002:a17:90b:17d0:b0:382:1aaf:4bab with SMTP id 98e67ed59e1d1-389416e7dbdmr3591525a91.27.1783536812170; Wed, 08 Jul 2026 11:53:32 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3117483941csm23706217eec.7.2026.07.08.11.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 11:53:31 -0700 (PDT) Date: Thu, 9 Jul 2026 00:23:13 +0530 From: Mukesh Ojha To: Lorenzo Stoakes Cc: Jonathan Corbet , Shuah Khan , Eugen Hristev , Arnd Bergmann , Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Anna-Maria Behnsen , Frederic Weisbecker , John Stultz , Stephen Boyd , Kees Cook , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , Petr Mladek , John Ogness , Sergey Senozhatsky , Bjorn Andersson , Mathieu Poirier , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Saravana Kannan , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 21/26] printk: Register information into meminspect Message-ID: <20260708185313.2fj7vltdoevflu7i@hu-mojha-hyd.qualcomm.com> References: <20260708-meminspect-v3-v3-0-7aa5a0a74d5c@oss.qualcomm.com> <20260708-meminspect-v3-v3-21-7aa5a0a74d5c@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: GjJycAlNsNKOB5XZabGusnlvQdzvArbO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDE4NSBTYWx0ZWRfX41GmXQXPvbjv MxZ24ig2wIocVE0W+e8U6eC1uPIAacm3D/o/TKqE0315EBnbI6fdITVndj/YWLynwfcciVieSHk zAEV+611ezUR+ZHgj0BSooK0E+RXtrnDmrEaRVV2s8YHfFdJBHk+gHfBxf853EOQPhF39LVVayy 499Mfmw11tZR3qlZOeuscsIvP7sp9+K1SNAoXCO3Q2RYmc4dMCj2x/rC+lm0HvVT2CVqFrO4Hk9 bzMfNNXSBQlSi2vE07vMtEXkrFTvTMMWNolcBdfsHnW55i6ykD0VfVj/T5VLVSkOrzk4N9YW3kg wFHysKuUIIkTHteoSbbdTYm2Ig1CPW77a6RllQbd2ygaEmO49uSOy71NapBvKL24QyVJH0DbUQS BsV0PoPGBWoJNWzUSkX0juAB9R9PIchAOeOPc6aajrZIHCNW31al6VqRGsrOFMUnLbWPIyKWw9s qR17i9hWkumyPxkPAiQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDE4NSBTYWx0ZWRfX0pnImLZbxb28 oStt2CkohwPBKWlqyIuGQID9eM+1FTfjmSBSaEud6IFvS4iILuORAik/F43k9Knf1ctqbN0fAVr hRiGzLcqvfyCmsuLL07KIoxmfbIhxyw= X-Authority-Analysis: v=2.4 cv=PYPPQChd c=1 sm=1 tr=0 ts=6a4e9cad cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=iox4zFpeAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=Oescfv6KCf7l1tfy-NUA:9 a=CjuIK1q_8ugA:10 a=x9snwWr2DeNwDh03kgHS:22 a=WzC6qhA0u3u7Ye7llzcV:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: GjJycAlNsNKOB5XZabGusnlvQdzvArbO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_03,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080185 On Wed, Jul 08, 2026 at 08:59:26AM +0100, Lorenzo Stoakes wrote: > On Wed, Jul 08, 2026 at 11:02:00AM +0530, Mukesh Ojha wrote: > > Annotate vital static, dynamic information into meminspect for debugging > > > > Static: > > - prb_descs > > - prb_infos > > - prb > > - prb_data > > - clear_seq > > - printk_rb_static > > - printk_rb_dynamic > > > > Dynamic: > > - new_descs > > - new_infos > > - new_log_buf > > > > meminspect uses a different API to annotate variables for inspection, > > and information about these variables is stored in the inspection table. > > This commit message is a mess again. You're writing what the code does, not why, > you mention separate API but not which or why. > > It's useless basically, and it's weird to list arbitrary fields like this. > > Always think 'what would be useful to reviewers and people coming back to this > patch in debug/development'. > > If it just says what the code says it's useless. Put what's NOT there. Ack., will reword this. > > > > > Reviewed-by: Petr Mladek > > Co-developed-by: Eugen Hristev > > Signed-off-by: Eugen Hristev > > Reviewed-by: John Ogness > > Signed-off-by: Mukesh Ojha > > --- > > kernel/printk/printk.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index 2fe9a963c823..f7f32c09b9b8 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -49,6 +49,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -518,10 +519,17 @@ static u32 log_buf_len = __LOG_BUF_LEN; > > #endif > > _DEFINE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS, > > PRB_AVGBITS, &__log_buf[0]); > > +MEMINSPECT_NAMED_ENTRY(prb_descs, _printk_rb_static_descs); > > +MEMINSPECT_NAMED_ENTRY(prb_infos, _printk_rb_static_infos); > > +MEMINSPECT_NAMED_ENTRY(prb_data, __log_buf); > > +MEMINSPECT_SIMPLE_ENTRY(printk_rb_static); > > > > static struct printk_ringbuffer printk_rb_dynamic; > > +MEMINSPECT_SIMPLE_ENTRY(printk_rb_dynamic); > > > > struct printk_ringbuffer *prb = &printk_rb_static; > > +MEMINSPECT_SIMPLE_ENTRY(prb); > > +MEMINSPECT_SIMPLE_ENTRY(clear_seq); > > > > /* > > * We cannot access per-CPU data (e.g. per-CPU flush irq_work) before > > @@ -1238,6 +1246,10 @@ void __init setup_log_buf(int early) > > > > local_irq_restore(flags); > > > > + meminspect_lock_register_va(new_log_buf, new_log_buf_len); > > + meminspect_lock_register_va(new_descs, new_descs_size); > > + meminspect_lock_register_va(new_infos, new_infos_size); > > + > > /* > > * Copy any remaining messages that might have appeared from > > * NMI context after copying but before switching to the > > > > -- > > 2.53.0 > > > > Overall exposing live dynamic printk information to drivers seems unwise, but > not quite as insane as some of the other stuff thus exposed... Thanks, this is minimal information needed to collect dmesg from crash-utility in --minimal mode. > > Thanks, Lorenzo -- -Mukesh Ojha