From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE4B83AB480 for ; Wed, 8 Jul 2026 20:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783542197; cv=none; b=DUgX/y+o45+/1XwamcDF53vNiVmnETybiax/xN1WlEHd29aQwnMSMjk6Rt4vsDrcJqoYbtohKt+eCsLsdPDWp4DSGFZWe1Aafy/yBcWpKzBdpENY8irNedodVtexSy/n27a6J1LBnT4ISlCaptJ+MffmPEQLbKlStXGA6/RBgo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783542197; c=relaxed/simple; bh=Dh7op/D6y72KqSKFeOFfXlBif3+8TipGaZ3CMsbhypI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kl9aP5pv09Pc2MLFL7O1JAHyRfsbwgA5Us1AIaB3fuK4W0QUhCoG1nBCtoQVcE/n74ihNbMNLf0+xgNgCEHZdfygrbw7KzJxMcryOQ9nBdXGXE1aY2PsjGQ0te9ZVShWS8HtQGmcI5r1qEIA635+yvuP8uTUvytRmUzp0xssb1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fyErrHMx; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fyErrHMx" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493e4ccccc2so1506405e9.2 for ; Wed, 08 Jul 2026 13:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783542193; x=1784146993; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xGPWKT+T/Sc4FxhkqkRyahjTyPdMRSTRlzX+JKb5mbQ=; b=fyErrHMxq4Nekka2qWxh4nwGe2eFKjiklHThFMSod0MFh/dUoyd6TV+87gR8ChvK2B jmjG+WxbKTWRwHFRVnwuKN6sSLjYmUKMaHwStEh8uK7s4Kzsa2ia9PsV4OGL1brRwIQB PN1MzLyUcUverVODQjrOQtAfRI58TwHG93YVPRNaKe3rbeUilRmiR6K5964p4Th/Fh9p Pphz+eTTWxTQQDs3sj99mkq234xxQGp4aLl70UnTUdMdJWc8MXQO2IYvVF7mg8rC5gJL 4Zm84nP6hVPXjMbnx3HGzTH9VAROVSoIRzHNMJiIRaD4r46bgJ2lfh1kCTN26/CaAeJc Ekng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783542193; x=1784146993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xGPWKT+T/Sc4FxhkqkRyahjTyPdMRSTRlzX+JKb5mbQ=; b=sciZvbRjAAEzquIcWD9JV54o6LLkiQfF4keKNFNy+wIOR4l8KWr1ao6ct8LVBkAuLx v0DJGEJu6V3+YiFSXVb1vSW6yDIZw0htkfKs/+qwZZjurisqPNHdd3iRRmyicfZ8PJsd gcAn9Eq8I5puuO9ADzeMU8HjWMRMmbZWgytj5kr0/KB1wrcRApsG5sWJR6+wLIVgmfZa XToMMoHtVtZbm0yuU7fDN+uA1gwFEzuAPD3c14a519hOSATsaI6XxBIJGPtOEzE8KjTw K0CJ3pVOerRt4kSW3xpb9a95RVG614HRZkCxaMHaQmmveyVgn/uUyfVtMpxY6FrPJb2r gQoA== X-Forwarded-Encrypted: i=1; AHgh+Rrt80B+I41fHoHpu2TjxcY00Lfu6y5qH0ooIrj81C0jBhVtFjbuI1Bs9ZurxWuRLVHKKamum0+x0SwiUy4=@vger.kernel.org X-Gm-Message-State: AOJu0YyHL037VxfMnRlAjgmiJxL99LZY7Is6eJsytb8KHEgj+YSn9wM8 +kaEhHvo7qq1eP8M3Eh/PyBiOC/TQFvZYPrM9hA8l34SlPOfclUqFbD+ X-Gm-Gg: AfdE7ckxk449Trtositu/LeddV6LSwVx+9FKVehvQnDJWON3m7NTyJxMpEq/svm3Ku7 5zm+ih69d1p+MRYYPy6KnFZKqHeT5WoSNFPTTFnLhlpyQfMehtzIMjv5/ngH8EBGq46KjxjpgjW lGLMPBq4RHCAd7gGIH6WqanwQ5O2FuORMjlG8Ui5668RLJnSd3k0Ji75rXUZH2QGsbv9Le9p2oy avmu56crnuQCizv64OriAc/OUS0udHalw9N/3MdOiJSpDfICo7MxViQ3lqoEQqug8jh9o99DGdo PwmNL0ZtMVWPUo+YIlz3DT8CEN9FYYW+I7cZqg3B/fZUk2GAGmPpliqCO0e5j7Kh/dZAdSghbXc UOleFsh7rtfAcg/h084P3n81jS4FXdZsOwjQcP89MSg7leqIUol+PHoDJ87tmVz9GxZ9rkOzCCb e+qvdg6ypSlwCUxZGl8dfEoK7l+FzY6krjlY4ovzmlUAvOeyxM6A== X-Received: by 2002:a05:600c:528e:b0:492:4363:e7eb with SMTP id 5b1f17b1804b1-493e68f03damr41743525e9.32.1783542193163; Wed, 08 Jul 2026 13:23:13 -0700 (PDT) Received: from osama.. ([2a02:908:1b8:2060:2b86:7192:b44e:9f03]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e5a5d174sm101663785e9.2.2026.07.08.13.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 13:23:12 -0700 (PDT) From: Osama Abdelkader To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader , stable@vger.kernel.org Subject: [PATCH v2] drm/imx: check parallel-display drm_bridge_attach Date: Wed, 8 Jul 2026 22:23:09 +0200 Message-ID: <20260708202310.12971-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260706142732.49397-1-osama.abdelkader@gmail.com> References: <20260706142732.49397-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit imx_pd_bind() ignored the return value of drm_bridge_attach(), so a failed attach could still proceed to drm_bridge_connector_init(). Check the return value, as imx-ldb and dw_hdmi-imx already do. Fixes: f94b9707a1c9 ("drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector") Cc: stable@vger.kernel.org Signed-off-by: Osama Abdelkader --- v2: - add Fixes and Cc tags --- drivers/gpu/drm/imx/ipuv3/parallel-display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/ipuv3/parallel-display.c b/drivers/gpu/drm/imx/ipuv3/parallel-display.c index eb75827394f8..fd48845877cc 100644 --- a/drivers/gpu/drm/imx/ipuv3/parallel-display.c +++ b/drivers/gpu/drm/imx/ipuv3/parallel-display.c @@ -210,7 +210,9 @@ static int imx_pd_bind(struct device *dev, struct device *master, void *data) if (ret) return ret; - drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); + ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); + if (ret) + return ret; connector = drm_bridge_connector_init(drm, encoder); if (IS_ERR(connector)) -- 2.43.0