From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E7DB41169D for ; Thu, 9 Jul 2026 10:53:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783594431; cv=none; b=mG2Hyfsomdrv6TB/27eKjj/NN0LbFGnfIP7l7dC7iA/OTEl3VIg8VxOw5dbz0h2DuBjJ++iWAJrjxIEG3JDkohbkr4Gevr429hw79soE9xXn8Cu0EBsx3yAj+dJtZfVKASkcrrRg7orIYG+kfS+Ho3pp15W9WEgQRLA1wRIvbZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783594431; c=relaxed/simple; bh=0phjc396Z5UDqSN2QCbrCy61trHVna+xzjhKOkfOAac=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Bwo4sM5HJjHOtyWSobsO+8XhHTKa351qaQIPS8EOsARguz2ChI9fMLcgItKN3yj3pMF2tKRYSZ3EZ2r+33s8+GE21SmQ/8mR3QVaaMiaDCL4Vk3b6frPvt3Xz1NHPUOnXPF3e+lRvJu0T1NQqxlCi9h23icA4OWC2Ia/gbjekHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EypU9a75; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EypU9a75" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso917704f8f.1 for ; Thu, 09 Jul 2026 03:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783594425; x=1784199225; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=YPjUMqEmR24+93sJKKscz/hlX989oAE7Njr6XMslinI=; b=EypU9a75pT+upcwUFKq0t4qK6mKOGgNFUfOZh86vbq0njpci5jduXsk1V2m0YY+9Pl AH6vhF3s/xa2im5EsrnTIJWe3ohLGliPt20c720GjNx5P+im5SaL9AuweMcWL5lZkScH soY2DQuxSNhKrIOhy37JvP7KMQNHhOgQGIZ5hKNOc06E02MHCJfzz2rr8X+Da7zFuCw+ CQH6pw95+NCTwVLbnP9uyDEqn78AFWuwN8JdcI4g4+CIvQOOD2wLEpAOnPd2IrDh+sgU 1c6A+NHAnwarnqiE2wiDKWVOcA04bmhHLElBJKRRebbLal3/IOVOyABND1QdJy0Ct2uQ KwEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783594425; x=1784199225; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=YPjUMqEmR24+93sJKKscz/hlX989oAE7Njr6XMslinI=; b=SNRmyfLPEL3BlIt2TFBsUVKK8beUH+eqww1+7X9/uK9SsKwwPk2a02Ot0HeHT+O0uH Q7mWIfBiy/s+XDM79PwkXt6d4eSKYdWBmaApYBNLf7DmXTSWOigUC5Z/VXQxGkEe3/1u rQiuDGOfUkYf7JbObwMtdqGzs+YeOFz8oWnNYt2XquOHKdEb9aUV0Keeajz1rY1RlKUG 2q269lXUB3yInbx88ZIybg09hGzirQZSOzAIjJazfNGznOpXIB8+6JESXvQz0pBUxAPw udsacEfQdcFRMzIqOh2rUYRi3bZoHiclfs1oY+Zs/Mn6ucBusHgPqOJxnKd+K413jADl 7FCQ== X-Forwarded-Encrypted: i=1; AHgh+RocW26/EmlasXA5OIAOqS5Hw6xLwisRwSZEND9ubOfpdyV58qpFh+vK3GsIevn43VPUGkCKA3+mgy7ZX+4=@vger.kernel.org X-Gm-Message-State: AOJu0YxjdJSjThyvuhwQ5DGmHrfcgsg7CSfySjwSCSH6kZMQDFJH2p9m WZLwXFdixz/YwvI1mkI5eiAG5VwLPp8ZA66Ur0V0Wt4mcPTjynElLg8n X-Gm-Gg: AfdE7clTJ2KdYBnPv92mEyfXiACKoDQ1zdeHdDKnmpR7PpRH9aBQMwiYMdIqDJwyNmS 8PklW+9BFWRqBovAeWCmgOavf1eIDH6Fr8WK9DiL2fEwd7Wo0wGGryrUXa/td4PRy7xL2Yab4qL oAvatz2dXfNVrgtdzD0xw5zkpw2dYE45NlceLk6zXqV1enCId7/3VpKlIF573zW6hF7AzEyrZpX ibSWzdFe8C6E1VuhZCFm1Q5APMrSOhYOXtLJ2u/UgBvYoSM1rtu8tn7JKtrC6Sqq6NZJ+2Dmpni EM15S76FTQ2JXdVGWYl7VFJbK3p6LrHHIZNdpS2fbQwiVGvIyK6kCVjtZfR5h5FqQo4LCuQrkiK 90ZhVXPuJtRZdo4yiNzIj7FCnyKC0Cql/LVLgxT1SiyM6pUpPfCI3TjKSydNESZ366XQmUCXonH mP8ZkhDz2rbgwyJKjHCi16R3PVZtj3NuM4M8t4F1dqqhGuBonR6vq4 X-Received: by 2002:a5d:5f51:0:b0:474:57f0:49f8 with SMTP id ffacd0b85a97d-47df07a988fmr6552629f8f.4.1783594425382; Thu, 09 Jul 2026 03:53:45 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([67.218.233.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d91bsm55275558f8f.4.2026.07.09.03.53.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 03:53:45 -0700 (PDT) From: Iker Pedrosa Date: Thu, 09 Jul 2026 12:53:24 +0200 Subject: [PATCH] drm/solomon: remove unneeded variables in blit functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260709-fix-ssd130x-v1-1-1272cb3dc85e@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x2MQQqAMAzAviI9W+h0OPQr4kHWqr2orCCC+HeLx xCSB0yKisFQPVDkUtNjdwh1BXmb91VQ2RkaajpK1OOiN5pxaOlGTpxjH+aFUgQvziKu/9s4ve8 H95WCKF0AAAA= X-Change-ID: 20260709-fix-ssd130x-d7dc491af074 To: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel test robot , Iker Pedrosa X-Mailer: b4 0.14.3 Remove unneeded 'ret' variables in ssd130x_fb_blit_rect(), ssd132x_fb_blit_rect(), and ssd133x_fb_blit_rect() functions. These functions initialize ret to 0 and return it unchanged, so return 0 directly instead. Fixes: 2258f03989af ("drm/solomon: Move calls to drm_gem_fb_end_cpu*()") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202606301409.I0ctsf41-lkp@intel.com/ Signed-off-by: Iker Pedrosa --- Fix unneeded variable warnings reported by kernel test robot in the Solomon SSD130x driver. Three blit functions were initializing 'ret' variables to 0, never modifying them, and then returning the unchanged value. The fix simplifies the code by returning 0 directly, addressing the static analysis warnings while maintaining the same functionality. --- drivers/gpu/drm/solomon/ssd130x.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c index 4907be694aec..0940eae7a2e4 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -897,7 +897,6 @@ static int ssd130x_fb_blit_rect(struct drm_framebuffer *fb, struct ssd130x_device *ssd130x = drm_to_ssd130x(fb->dev); struct iosys_map dst; unsigned int dst_pitch; - int ret = 0; /* Align y to display page boundaries */ rect->y1 = round_down(rect->y1, SSD130X_PAGE_HEIGHT); @@ -910,7 +909,7 @@ static int ssd130x_fb_blit_rect(struct drm_framebuffer *fb, ssd130x_update_rect(ssd130x, rect, buf, data_array); - return ret; + return 0; } static int ssd132x_fb_blit_rect(struct drm_framebuffer *fb, @@ -922,7 +921,6 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffer *fb, struct ssd130x_device *ssd130x = drm_to_ssd130x(fb->dev); unsigned int dst_pitch; struct iosys_map dst; - int ret = 0; /* Align x to display segment boundaries */ rect->x1 = round_down(rect->x1, SSD132X_SEGMENT_WIDTH); @@ -936,7 +934,7 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffer *fb, ssd132x_update_rect(ssd130x, rect, buf, data_array); - return ret; + return 0; } static int ssd133x_fb_blit_rect(struct drm_framebuffer *fb, @@ -948,7 +946,6 @@ static int ssd133x_fb_blit_rect(struct drm_framebuffer *fb, const struct drm_format_info *fi = drm_format_info(DRM_FORMAT_RGB332); unsigned int dst_pitch; struct iosys_map dst; - int ret = 0; if (!fi) return -EINVAL; @@ -960,7 +957,7 @@ static int ssd133x_fb_blit_rect(struct drm_framebuffer *fb, ssd133x_update_rect(ssd130x, rect, data_array, dst_pitch); - return ret; + return 0; } static int ssd130x_primary_plane_atomic_check(struct drm_plane *plane, --- base-commit: 671b7825dbfe9ea6e3ad3001003aeee0df48d1b5 change-id: 20260709-fix-ssd130x-d7dc491af074 Best regards, -- Iker Pedrosa