From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 731043D3D15 for ; Thu, 9 Jul 2026 06:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578950; cv=none; b=sniCxl1qabEaOZaQnvBc3kQ74sGqF4YKxB9SxmYzou53in+BZprKS+/lG+Z/F+r3ye9bIZuTR9iMx248x6Ug7eAY/G7y7rGMMKpygvPM8dYm/2iLGHhqUEeOKq07IHgaAdzQ9Stgb+zhZaY25vKmgn6rCTuSAvCMPOR/hNQQLWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578950; c=relaxed/simple; bh=QG/qBYGp1CFoAUEioBOEm/0Vr40BG+zvspOBhc0KLXE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YCG55417Aethq+8lTE2NdoMOuNZ9F7Y6rQYX1918VZHqlZgXnlZj3/Y/mW8SKJYUITNssw/OWTuYYduxWa2Z6BP6BFXhf/uTxoOcdFZXeeckzyxJb3Dt6b/f5GmjQueMx4XTmYLF0EQx5I4ooj/PZMk8+AEr4y9ZxwGtgwGZqqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T6ljj75+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EcpL61lW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T6ljj75+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EcpL61lW" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66960SXW750282 for ; Thu, 9 Jul 2026 06:35:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z0EqAPxjwdtcQIJ6xwVHlsStlD7K7EQBa7wviyRj3cA=; b=T6ljj75+RZN42Dol W6WaouM4UXt/sxxgAwcbLRB2jhkpunGtATTnog74/YcynuGCmDpEQo40NLhg5BB/ kO7LNIJfvahRMtSz2vC8+4kTy/NV0Z+0iOZPnQBbDYebtoJxx6IYo4RGCzZZaXpc pB+PczWr4UPWrIrMitIgHF3yFD/2JCYcp7OfOaP+yO0blVduJ9+olZqP0+keVrIz GJgzsH4zdm4Osjs/ywwBJEGSVLNkaGmg1Z28elb4r/u+LosstnXAlvTVGgSpxnST z7hBeGeRMk1bLIzlUnMblPuyUB1NpXgI37nL1rxl4Fqxguv+clKh05IcecbZYMf9 4Qy3Ow== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9wwfsnya-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Jul 2026 06:35:44 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c88ad1558f4so1354389a12.2 for ; Wed, 08 Jul 2026 23:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783578944; x=1784183744; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z0EqAPxjwdtcQIJ6xwVHlsStlD7K7EQBa7wviyRj3cA=; b=EcpL61lW0Wp2K3s6pqkX9QPoJ3BzYt+AAy+JCBMCB7pKGW1m2zPv+FUIl/1RDVTEAI s9/k6u56jsHYD4osqdtzaEQR4xGQmUdEawJi4ztSpzmBCSbisqaD7MZuPJN5pgFeb+YN A0MMxAXJVWgqjebh4vwTwRoMLT58RQStpK78rEmDwe2PLMi9srbjQxew2SYXscIs/tpO W3nmuSz/INpk++gdl4N9k7fyHNqvSnPvZrDTR3DZyEoKf9rFSJdIb762HOS5G3CvMJ6V BTfq8NBQaLgmgqhZsg+8LppeYMCgAukSJkdqLQioJOjYBvrZK4+kh+3G/dtuDK+sJ8le NAew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783578944; x=1784183744; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z0EqAPxjwdtcQIJ6xwVHlsStlD7K7EQBa7wviyRj3cA=; b=pash3ic2eimDfPDhpnnU1HVcMUTpjpNmjrUKlTD7JCROwD1tZTUD1duhDFzKSYcGYv dHZdhdpz9MHamn+h22uf5NTmIYWViP7PjVpgn17PFj+UBB514hHbX54MBJ9Z7vP77Vjk rVbCvGXgaWWp1kHGbWN1g6Vs/4C93nNwuxeOEM+9oC89kQwswXMk60lkZLcvh/6/IuNf ASIPfpzuROV8b2fwiIEanrobKPnrFXXR0rxWBiAw1qsU17XeJi9s2n1SFM/XZKnP56c6 t7SVBVhyhCqJ1LSecmaGf1UHoNugbYTWhadQOhwcAOwvFHiFdw6Gq85J8hhu9coFSBlc h7kg== X-Forwarded-Encrypted: i=1; AHgh+Rrrhkwy6UP1Q+DW5tNa/CIqjYxhGVauB86vhUrEtwi9FQQDDwTAPvCjbOZnZrFWA/CS0mnrnBaJy4W6vgg=@vger.kernel.org X-Gm-Message-State: AOJu0YwGoywxmcpc7gctD4lfnZRyooyjqe3HCrwZ0cJW+RrGGitGYA5d AtrWipgAq3RsRfHe8TSgqpq/nOkWnoLLIyE+h4g4Q6U+qH3GGmTzRRMRvsdJ4cQUUbkJIPgqtDF qF+Ti8s2ZzzUWCP95AmrUw5wJXWNEZisVwB1RVw9/kkVBMUn0SKuTK7sXan/p4MEArvI= X-Gm-Gg: AfdE7clPl3qA8vrIlixNBKbfJQMkcIy8m3Ym0ABqZD9PoKbpoEZYexwAy5IjncXixK5 24V/NpzjT8QUr7mDhBlA27EDiZ7b/0iDRY/Aaa0MtXdOEoX3RwMj1lvWNRfqrz4X2NynDTt/1Nn xubJZpg0lB2w93xnyGNzDgGIFsPVsJc3gJPZK6je0uLUQeoUo3MXMMrdPifUhLnlKvqAOPKzmGM 7I+zF5gZtvd6BtPlTItZRandzjSV9O7Srqc6XduehuS/wDsNpYSymgYyKah7OTdUQX5dADTmCsy yaw7Ca+IRNOjbuaZqQxtXGEa26iFYCjasOVTLOMHfswHj8NXDIvj7PocuONs/CgZYrXEeyoI49l 3ZxUmtFDXwM0xGKSef92At3SOYiZgednzZxoKBi4CbnQ3uQ== X-Received: by 2002:a05:6a20:c998:b0:3bf:bdb9:f602 with SMTP id adf61e73a8af0-3c0bcc6a270mr6656532637.22.1783578944021; Wed, 08 Jul 2026 23:35:44 -0700 (PDT) X-Received: by 2002:a05:6a20:c998:b0:3bf:bdb9:f602 with SMTP id adf61e73a8af0-3c0bcc6a270mr6656493637.22.1783578943419; Wed, 08 Jul 2026 23:35:43 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174a56848sm28304294eec.16.2026.07.08.23.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 23:35:42 -0700 (PDT) From: Krishna Chaitanya Chundru Date: Thu, 09 Jul 2026 12:05:17 +0530 Subject: [PATCH v3 2/4] PCI: qcom: Keep PERST# GPIO state as-is during probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260709-link_retain-v3-2-81a9d187bb61@oss.qualcomm.com> References: <20260709-link_retain-v3-0-81a9d187bb61@oss.qualcomm.com> In-Reply-To: <20260709-link_retain-v3-0-81a9d187bb61@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Philipp Zabel , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Krishna Chaitanya Chundru , Qiang Yu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783578926; l=1729; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=QG/qBYGp1CFoAUEioBOEm/0Vr40BG+zvspOBhc0KLXE=; b=ihJm48Lda5dcP9vNT/LESX/IJC7zDKsME7N6tASM4TbxgsiS59KnttAt8fxhcwoUzfu2ZuZ15 wGw9wT+ApGhC8+FIcaD3nm6FkRbwQfRlCz+35C53uYonymK6P6GdDHl X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA5MDA2MCBTYWx0ZWRfXyGS5S/ZheW0+ Wq51GN0LK3Aek5J4oKEb578EsthGYhLZ3KvjTSFFFG9R4N3/bf70uBIFt1HCMpTshjnsN6MoMTG sGszj4mJNo2Ddi9lErwGiWadOJZqVyLWgprDNHLk3pa3l/Hxh58bf31zZYYT0AWy33jkB4xmaTA nPOy56Qr8JqtuAUU1XiBJG1UvH1YEBOQgmiyWhlu7RDiqnbnS+YjBMld0DkV6stnYEWETJW0DqF xa6wSukY4h75mNHyoF8reL+rTRu5TdjTeDm9o8m28prIpmMUp6543qis26QtY9TOtpiGp2TbmAU wcsf9puRecJ5DtWkZ0jbcUMH6gfHaKVQSIXBwIXG6JwIYLU1NtPI9dBN56khZd/dsgZw6kmHHN+ aCxgknDzO000fSV73taIbx3kzZjaV1rpP03s4c43Z7//Gak8Z5LT4Y0yu96bB2OwX90NY4Zw/Oq wes+qIkGXwwYcpG60aA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA5MDA2MCBTYWx0ZWRfX40Uo6jegkPTK w+iMTsMBXIy4Nh+yEzN4SVNqfOcwEdZeTkCAJeTVqnSbHtDKO2s8RstcfTqGubkmUKyWY+co+rT 9sXKH8t35zNbRtxdoJFnvvXhIlFLj54= X-Proofpoint-ORIG-GUID: YyvIRrUb8iOxBe_HSGYbDTpV2qVazc4p X-Proofpoint-GUID: YyvIRrUb8iOxBe_HSGYbDTpV2qVazc4p X-Authority-Analysis: v=2.4 cv=Krh9H2WN c=1 sm=1 tr=0 ts=6a4f4140 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=awRzx6-DDdmypIrTvt0A:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_01,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607090060 The PERST# signal is used to reset PCIe devices. Requesting the GPIO with GPIOD_OUT_HIGH forces the line high during probe, which can unintentionally assert reset on devices already out of reset and break proper link sequencing. Change the request to use GPIOD_ASIS so the driver preserves the existing GPIO state configured by the bootloader or firmware. This allows platforms that manage PERST# externally to maintain correct reset sequencing. PERST# is asserted explicitly later during qcom_pcie_host_init(), so forcing it high at probe time is unnecessary. Tested-by: Qiang Yu Signed-off-by: Krishna Chaitanya Chundru --- drivers/pci/controller/dwc/pcie-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index d8eb52857f69..9ca620d4746a 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1841,7 +1841,7 @@ static int qcom_pcie_parse_perst(struct qcom_pcie *pcie, goto parse_child_node; reset = devm_fwnode_gpiod_get(dev, of_fwnode_handle(np), "reset", - GPIOD_OUT_HIGH, "PERST#"); + GPIOD_ASIS, "PERST#"); if (IS_ERR(reset)) { /* * FIXME: GPIOLIB currently supports exclusive GPIO access only. @@ -1918,7 +1918,7 @@ static int qcom_pcie_parse_ports(struct qcom_pcie *pcie) if (of_find_property(dev->of_node, "perst-gpios", NULL)) { pcie->reset = devm_gpiod_get_optional(dev, "perst", - GPIOD_OUT_HIGH); + GPIOD_ASIS); if (IS_ERR(pcie->reset)) return PTR_ERR(pcie->reset); } -- 2.34.1