From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 474AB3B1EDB for ; Thu, 9 Jul 2026 06:22:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578178; cv=none; b=gzqCWoljDmCPBsq+bNTCEnL/qxpkrs7FbRp214RYqmTJs0aQHlwZ6t53/odikekv4do0t2YEJclZ1b0f44dC1IHetzeVB6eLqTVa0YoYCG1Tq1ZfgmPiT8D0t/k86xyBseTg2y0LoD1vjwEoKKNcXQUXTANZpB2Tw+DwQAtfkBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578178; c=relaxed/simple; bh=wuSlAl66usvu0PLcpR4fJ5qbWuXweuGPE9gIWrR8Xw4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JATbT5mgjYEKF0EwSj8v22iOm+uYrojoETsWByet/XG5H9T4VbF4DJILOtqDDtKykbDfYbgpvI7fIrC94ZLXT08hUyPDYM85Gcqfq3sARv2vfYeIrV3OULo6+W7Jkxpou5wn1sqlx9KHcp/3ATA+zFUmlKwiT8zL3h3xtuKFDg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XzX+4NxR; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XzX+4NxR" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-381065a7a03so1035224a91.0 for ; Wed, 08 Jul 2026 23:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783578176; x=1784182976; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=T/p//Mh6rAQJnJjEivwgC/TetVxw3EfDCqsDUKKx0Uo=; b=XzX+4NxRMlCmYIgkgqxf+85eSGYSHHWcedEH5FHR9TTHd5k1hWfJtbUtDRMYXH4D0r Ae33hZvF989c+8jinJuu2nPFKwY0TSH10DJOKeiSGkngWQ2jo9/KTwaEOYyFeMBEJp5S xqkQ10gbsw0ztJP/GFR83jf6cunyQLsQwu+bhSF896qFD2DxlKWhoDrRnmS1Iyu9mRjk Wf56y9mYEYl5VhVvWji9QqYXXhjhOfHqkgOi3n6lugQgu7hqhT4fHZhe9WiMIoE88wBT Ap3BW217zD8H3ZokiIwCjxRseotWqfJSz7fJRhOHmbGM1VFK6sk1pRszltTHqWjE9DGi ayDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783578176; x=1784182976; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T/p//Mh6rAQJnJjEivwgC/TetVxw3EfDCqsDUKKx0Uo=; b=l501OVcje1PLSbe0twy7Am5XWB/08wmhO9Af1c6iHtGzYMGrpWxF8JIxNVdbgm3M33 zfQkQO0nHCR8RxYoLk8DEbvHjMXq5XqNVELVt5gr3aX/AJNTJzF5vu6+j1Jyjz6sWPVS Y2nJkBZPyxYmv5xFIrX6ZI3AK2NW1DaAZ6vuwB+YWX4EGLqDALue6PPW3LK80YW7MXWI lIzwfNo37okaRooxGxq4HN5rfIgMU5YL+qxiYux4Nh59hnvRjzVbzoMFK/GKFsuBRV2X hyrE2vJsgHyk8hFKAkG8cNUZpAORS6sgEmdbuKFbPRTxSqp2/S14LLne2kUw9WLHVCS/ Z0yg== X-Forwarded-Encrypted: i=1; AHgh+Rqe63RP4z2UvFrMKpXLFU3Qygg38y1R45gUl+0f6eWS/7BpCITLvtpFI/+QQovv7icXh17wrfoPH67cYEg=@vger.kernel.org X-Gm-Message-State: AOJu0YyQzGCWBNodP8oxHA494BB67/9BlodCS/XSoKsGyZSN5zLBZbx8 9Piz38ODHMfQ1Za/xmzXNMbESSX6+vtSU8ydu4BSX28yVGqZT69leuhq X-Gm-Gg: AfdE7ckpD4P8FGSXAd+ZSkbgb8/MPxVkxlPAXQuM1neAaQPchLraG7UmF7P2cFfHZN2 DP9vntHe4bsK8nrhQ9IObbwIt6NWHRhpixPOdkYEoflccRlQQS5+9WfQaj5AhiQ9w0rCKXqNRcL VWzrQhvN+5lLczeNaFLIGigibl6DXFX+MiStHdIFkSaS4BowGfGuSPvEpoiHuVQeKa//YdGo3dV PSvj5Cm+9YcNU+v3kBGChjy2zQblcIz2i2DWtBzvikc74g0K5qugGmPkQHccPCEKafZ+l0WVPYz Y3/V+QaGWkPV0ASTLtlN36Qo//meU6n932vIwHxceQHxsg37PkTo5zlRPpl8xKbu9WwIrT4ChFM GaFRU6fl2KW5d5nUOuyAUEDGJnW+jDElAOH/KohYxrhxVpqvnTlNlFbMcmG26fWNuv9+Dcrdxjs 0lQ1Hht4epI5F1JhCJwlrAkYb3D7Vjn+n5 X-Received: by 2002:a17:90b:4c41:b0:387:e0bb:5801 with SMTP id 98e67ed59e1d1-3894278d1d9mr6359228a91.40.1783578176229; Wed, 08 Jul 2026 23:22:56 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:ea9b:46f2:6d0c:46c7]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5564f58csm620730a91.8.2026.07.08.23.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 23:22:55 -0700 (PDT) From: Ruoyu Wang To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] Bluetooth: hci_qca: Clear memdump state on invalid dump size Date: Thu, 9 Jul 2026 14:22:50 +0800 Message-ID: <20260709062250.4166128-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit qca_controller_memdump() allocates qca->qca_memdump before processing the first dump packet. For a sequence-zero packet it then disables IBS, marks memdump collection active, and reads the advertised dump size. If the controller reports a zero dump size, the error path frees the local qca_memdump object and returns without clearing qca->qca_memdump or undoing the collection state. A later memdump work item initializes its local pointer from qca->qca_memdump and skips allocation when that pointer is non-NULL, so it can operate on freed memory. The stale collection and IBS-disabled flags can also leave waiters or later transmit handling blocked behind an aborted dump. Clear the saved pointer and memdump state before returning from the invalid-size path, matching the cleanup used when hci_devcd_init() fails. A static analysis checker reported the stale memdump state, and manual source review confirmed the invalid-size failure path. Fixes: 06d3fdfcdf5c ("Bluetooth: hci_qca: Add qcom devcoredump support") Signed-off-by: Ruoyu Wang --- drivers/bluetooth/hci_qca.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index b2d1ee3a3d115..1222f97800f4a 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1087,6 +1087,10 @@ static void qca_controller_memdump(struct work_struct *work) if (!(qca_memdump->ram_dump_size)) { bt_dev_err(hu->hdev, "Rx invalid memdump size"); kfree(qca_memdump); + qca->qca_memdump = NULL; + qca->memdump_state = QCA_MEMDUMP_COLLECTED; + clear_and_wake_up_bit(QCA_MEMDUMP_COLLECTION, &qca->flags); + clear_bit(QCA_IBS_DISABLED, &qca->flags); kfree_skb(skb); mutex_unlock(&qca->hci_memdump_lock); return; -- 2.51.0