From: Hongru Zhang <zhanghongru06@gmail.com>
To: david@kernel.org, ljs@kernel.org
Cc: akpm@linux-foundation.org, baohua@kernel.org, liam@infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, rppt@kernel.org, shakeel.butt@linux.dev,
surenb@google.com, vbabka@kernel.org, willy@infradead.org,
zhanghongru06@gmail.com, zhanghongru@xiaomi.com
Subject: Re: [RFC PATCH v3] mm: retry page faults under per-VMA lock when mmap_lock is not required
Date: Thu, 9 Jul 2026 16:47:52 +0800 [thread overview]
Message-ID: <20260709084752.147379-1-zhanghongru@xiaomi.com> (raw)
In-Reply-To: <ak0Xl6q52exX9sBH@lucifer>
Hi David, Lorenzo,
Thanks a lot for the detailed review.
Yes, Barry and I discussed this offline, and I am taking over the series from
this version, with his agreement.
I agree that VM_FAULT_RETRY_HARD is a poor name. I will rename it to
something that makes the mmap_lock requirement explicit, and document the
semantics more clearly, including how it relates to VM_FAULT_RETRY.
Lorenzo, I agree that the unbounded VMA-lock retry needs to be addressed. I
will look into ways to bound or otherwise avoid unbounded retries under the
VMA lock, and benchmark the candidate approaches.
I will also look into deduplicating the arch fault-handler changes by adding
common helpers, so the arch code does not have to open-code this logic.
For the retry sites, I will audit all sites that return VM_FAULT_RETRY and
document the reasoning in the next version. In particular, I will look closely
at the userfaultfd released path, do_huge_pmd_device_private(), and the
FAULT_FLAG_RETRY_NOWAIT case, and update the stale comments where needed.
I will also fix the subject and make sure the next respin includes the full
maintainer/reviewer list reported by get_maintainer.pl.
Thanks,
Hongru
next prev parent reply other threads:[~2026-07-09 8:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 7:50 Hongru Zhang
2026-07-07 13:51 ` David Hildenbrand (Arm)
2026-07-07 16:52 ` Lorenzo Stoakes
2026-07-09 8:47 ` Hongru Zhang [this message]
2026-07-10 14:54 ` Suren Baghdasaryan
2026-07-10 23:37 ` Barry Song
2026-07-11 1:54 ` Suren Baghdasaryan
2026-07-11 2:02 ` Suren Baghdasaryan
2026-07-11 4:00 ` Matthew Wilcox
2026-07-12 13:27 ` Hongru Zhang
2026-08-03 22:48 ` Barry Song
2026-08-05 16:49 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709084752.147379-1-zhanghongru@xiaomi.com \
--to=zhanghongru06@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
--cc=zhanghongru@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®