From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 755BF407CC1 for ; Thu, 9 Jul 2026 09:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783591080; cv=none; b=ACs8sJDSC0wJldRoaP019KHpBiYjLrN648/EnRTVKrZhn9TKlTKfA2xReYBAyqwjen32jP4BHK1dMM5PS5W7ZBEM4gC6fcbpStAGGnGWo6r6u5PkM/LHZ73/4kH9K/VF2L3Jat6f3eo3CHOf+ez6M6AVZ5pdnLSHle7S6K383ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783591080; c=relaxed/simple; bh=8mYc+Nbjm6+sQSrADVmvWRSMeKKljH7evJpSSNXklR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=blN3DHP2hleYOayHkFadsOZN4JKua7JAbKn0jjT153PkXqM9oBna7VlqasPZXRdldSwt3Wrmku7HRBL3eFzU+6CUotl0Mi4e1oJiVB8MBtRFZtfDa9SebvUwMmDeDsKkSCLyeyvULzyLkKoB67cFs3QzqO2QMTECBNJJby985nk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=cDYIfjw0; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cDYIfjw0" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ca70925c25so23240705ad.1 for ; Thu, 09 Jul 2026 02:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1783591078; x=1784195878; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZO05xNK1Hbq+tmP+bxjD79MnCLqnvQlOFToHRwo4P0Q=; b=cDYIfjw0tctxjV3LHr28wZw9HbFx0L59CuLb636tk53eH0xU2HiwPhvAuL8JzpDcrU XeZJOnKHysmF3AnmritDPjyvF7sF8zPc1FkSLZXuos3fWoIPowIJWcTT/B4bTw0UQ9nR f9Zjs5VWNq9gbpVMDZqmQLs7n+FlXIL88kkGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783591078; x=1784195878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZO05xNK1Hbq+tmP+bxjD79MnCLqnvQlOFToHRwo4P0Q=; b=Wy/IyCWMG/VC48rirIS3owcDwzmqrHiuSdMDZQai3gnvE8mnhsL3/3YklCmNSyFp37 ZMx0u0krYBJJGo+4hbPHMHL8NsmOt3ettfUGe+3DIl2eIOso2boNw7RDaMcarOdSc9Gb IIgF8yfLpKrZYYoGwvH5XewQpHoWv4Kc5prCkpjK+Cyn6gVRnhybRw/zeW7lHd7hv5r7 QsiIlJ4hb2sVa9lMM4UnPk9FU+U2XifPzIryBmuO8HZcSefpdUCiZHhaq7ZFPHV16Q2f 7igvScYBzT14vsaouq9UGqsP3q2KfHMIZRmvVM0Ro+Pe+MfjGktcnqQVpnguNS2ZKeNi Z8Bg== X-Forwarded-Encrypted: i=1; AHgh+RoOQrwupUx9RAKjlRIhk6w1y2A5oi7W7/jgA0Vj6C6R2qDffNCmIdttt94j4WPckvTy/MfjyAHV/5SEaYs=@vger.kernel.org X-Gm-Message-State: AOJu0YxJ2O6lvn07/t+32PUlPFf2prt9wlLTNl46Ttijkokwu52OqUNm 5Len9LaOuR+J+olwiOtqL2Qh6kPxUNUX/p3XpTndzTiASOe3UGNhk4aupn/b6H4FAQ== X-Gm-Gg: AfdE7cmuI3WrbOvsA3VZNdHa2TFhChzhl0dWtmBAUwpKtwKAFzZPhrNQN/fPBZdjYap 6X/dvVGYfm0CTBIqAdeNm/j/H9R/eih5wG6NOL6ON2qIN6pHm/VvoStIMmMeXeHo1b+tN5xDDR/ qiBXZ8GprfJFkBWxfGUtcAd5ZQAuHUDwSHGW6VuGf4tsdkhkLcJnRiOh/vO+Z/amqzIJqKHKjU9 TMzxR2NQX/olbA/Gy0V8JCLQ3SYS/GHI2vkTlKk1HU2cBMcxgZQYA4fOmmrBy8mwIg8snqMG7LF SfOgXkStbf9x8lErSGrevH/8UHlSsgyxpuPbrJ+R/NAxFbe7tmJ5un7QOWUhh4SVVvTYalsY9fP IGHOZSp/9Lm+C8zdXe0uU2yjnpOnZQRw/KrWy/1Xsa2VoIfQDID//6QKKevHfU918CyYjxaEC1l qlRHhAVi1wdyeOTUkDI2gsmymeeP0vfLWtzdMf276up1ZNVzdNH60VPQXc/PuQKHMhtpxeVQ== X-Received: by 2002:a17:902:e78e:b0:2bf:dd0:c8b1 with SMTP id d9443c01a7336-2ccea1a4d4cmr66175845ad.0.1783591077993; Thu, 09 Jul 2026 02:57:57 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:bd09:6ddb:180a:69c5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d5bd2fsm41082155ad.78.2026.07.09.02.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 02:57:57 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v4 04/14] usb: hub: Return actual error from hub_configure() in hub_probe() Date: Thu, 9 Jul 2026 17:57:09 +0800 Message-ID: <20260709095726.704448-5-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog In-Reply-To: <20260709095726.704448-1-wenst@chromium.org> References: <20260709095726.704448-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The addition of power sequencing descriptor handling in the USB hub code requires dealing with deferred probing from pwrseq_get(). The power sequencing provider may not yet be available when the USB hub probes. Return the actual error code from hub_configure() when it fails, so that the driver core can notice the deferred probe request. Also rewrite this section into the standard error handling pattern: if (error) { # handle error return error; } # do more work return 0; Reviewed-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Changes since v2: - Rewrite into standard error handling pattern Changes since v1: - Moved "int ret" declaration in hub_configure() over here from the next patch --- drivers/usb/core/hub.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 13264e86bc6d..fe10d72ef39d 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1874,6 +1874,7 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) struct usb_host_interface *desc; struct usb_device *hdev; struct usb_hub *hub; + int ret; desc = intf->cur_altsetting; hdev = interface_to_usbdev(intf); @@ -2005,14 +2006,15 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) usb_set_interface(hdev, 0, 0); } - if (hub_configure(hub, &desc->endpoint[0].desc) >= 0) { - onboard_dev_create_pdevs(hdev, &hub->onboard_devs); - - return 0; + ret = hub_configure(hub, &desc->endpoint[0].desc); + if (ret < 0) { + hub_disconnect(intf); + return ret; } - hub_disconnect(intf); - return -ENODEV; + onboard_dev_create_pdevs(hdev, &hub->onboard_devs); + + return 0; } static int -- 2.55.0.795.g602f6c329a-goog