From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BA822773D3 for ; Thu, 9 Jul 2026 13:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783602740; cv=none; b=cSoLKMtbTd+hkb96dBAxkWoCKc10IXi18zkZ6CJ/g2S1rcqaw9QGa61kUfcaW81SY6zfqjzHm9r0Jj0J5mRFIqzkL1BzLatjJcYHmM5mqS7L9D6cjAeRpu0d6N9e54jpW1+g7dDpoFkzaxMBtIFfyy/YgOXysMNasRB4TATQ7GE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783602740; c=relaxed/simple; bh=6wPyJuyF+/xBBGX4QagqtP33CTHXZy52Mtv6fMLp970=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rq7dY6KGHlGXei19qS16jEO54KYd4bvL/R4GkusrO7uQsUpmx6vkw1IThpD5QRBOm0YvrG6nO+x0UqN+T1gPtGuLEtw7DZWlpUnwYwOjdS4RSM3IR933286kFN/A1cuAY8KwC5liiwFAPk/mt9rNtvB1NiWGQ11NXxRn9CJsvVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai; spf=pass smtp.mailfrom=0sec.ai; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b=pUCt6kT5; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0sec.ai Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b="pUCt6kT5" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493bb510ce4so7338175e9.1 for ; Thu, 09 Jul 2026 06:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0sec.ai; s=google; t=1783602734; x=1784207534; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=RrKtzVIGFaIJtEucWTbdAfl+74MzcIHqgRfH6zC75gw=; b=pUCt6kT5ygqL8MsowtA7XXB92Uy7w1cRT5V1kxkuXLNEqrrg/2APBBJE1xiV14Yv/L f8hvefm3k1l4mYahtpXOdE52+McfeLZqGv4tmoRVLaefEOEOXejTzvlViPNPiDJ/GWNJ H8vWTaK3FzR46G0qNYcJ4UJO92AzuTS3AmxFSsez6Y2NVQ5dadfhCzrK0VI8Zp0aLPre 734Z4ELnRbFz2y3LJ6ylPDsVYxIJcXfz1Z0RBRoBVfTp5jI9QcJGqN6Gp0gyzGvmqCAl yUgWVVxM57jqmmuk0koHr9TgfoGakltj2OmYW9l3yzm+DyRZ1rBubz+oRuSpJSJP2KI6 k+Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783602734; x=1784207534; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RrKtzVIGFaIJtEucWTbdAfl+74MzcIHqgRfH6zC75gw=; b=XaGCbppPB4BIzK9NiE0IS0ueihtzsSHdVk1qzwcU8xpjzdjg+R0xv9v02lvarHT1JO fXmIH+GnVZCadKDPnwYUWIr6XAJSJu+MXb9yOze4vKtgz2RqkL4tJOitJ2pHzHoazM5q Usz/ubgCIU3G7rTp/hov9DUZ9A5sfmn0u3jLLsytQitCaEeFvfVj9ssZRufHmAc9J45W vcPPkr932I9NKQOCwMEGgzcHizNF0Ueh9gc6abBykB+xcwkoLG7NH3Z40Hyh4p6Xk4/Y aDsybN3+0eTN1TFCFHxayPlOdV7K0RZZCb5Hj9iAYUB3xcGKIpxxI0GnHwtKmFruzsyk nF/g== X-Forwarded-Encrypted: i=1; AHgh+Rr7wGGwLK80uTZke81x/OXb0jpqyvFEPsXBSCIrxkoGLlmHw/82dbwOB1QZBIgzfp67nDDCTD9NQypYETk=@vger.kernel.org X-Gm-Message-State: AOJu0YwX/tbGxBuK1IQvzve4guLS83OWQqmHPgttNZSor0jKKHE/saka CYJ+THQ2qAuUw0sb0g1J+mkpaN3a5I94Kr32yQMSVMdPmIMx6w+oylU9zuqBdGvw1oI1 X-Gm-Gg: AfdE7cmChv+H+9zfJa3hOqKnA5NZsELfFqmovoxpXWTsNxjRdkUnHLxUHkAhoqbqeJJ 0heRxMVhHSSXN2v03GWAgaLecjIIJgyHn4DWAul7YT+zEELFuqc3SACmSxjMKd0e9gF3aRN5UuH +lxlFpPPxkXWvHk+PwSv2qIkvh3y+WiA6t3pugng8f59oPTxV00iIpOxRd8S0N8IRbpUcsI2aj5 UyUNVK2kcPdSPFCnGvHVyLsALn5JpCKH0zJp2nQY89PMZ6ZVgpbWw4qn98aJ9sp6mkt3ZE2C1kR /IacP0l4EFZI7iGNMESYccrrYPYdwYYZu9IV44Rnk8wbZnwmlAvwULb4kr/hslJYhF7NX+5fVtX wv1Ijv2We8m2YUnLNDt3BSoW7IkK+E1SuyncJKgcc/xzBEWPYPThimoIzQoiwShY3dB5Krs/Vtp 0s/CKdxk8AxU7UhecRXpqFDm0xMW5ZxquYgCezlfO/ETs1Tdc7lEqJCq7RKFYf8l989U+JPnK/D SLe3Q13XphnDn1/xwtyNOLdGUAa1wqUN1E= X-Received: by 2002:a05:600c:628e:b0:492:6113:d4fc with SMTP id 5b1f17b1804b1-493e68cfbbcmr70465045e9.17.1783602734192; Thu, 09 Jul 2026 06:12:14 -0700 (PDT) Received: from PeakBook-Mini.tail8e484.ts.net ([178.197.218.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6cccfdsm61196745e9.1.2026.07.09.06.12.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 09 Jul 2026 06:12:13 -0700 (PDT) From: Doruk Tan Ozturk To: hverkuil@kernel.org, mchehab@kernel.org, nicolas.dufresne@collabora.com Cc: sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, detlev.casanova@collabora.com, kees@kernel.org, michael.bommarito@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Doruk Tan Ozturk Subject: [PATCH v2] media: v4l2-ctrls: validate AV1 ref_frame_idx and primary_ref_frame Date: Thu, 9 Jul 2026 15:12:11 +0200 Message-ID: <20260709131211.44425-1-doruk@0sec.ai> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The stateless AV1 frame control V4L2_CID_STATELESS_AV1_FRAME carries ref_frame_idx[V4L2_AV1_REFS_PER_FRAME] (signed, -128..127) and primary_ref_frame (__u8), both copied from userspace. validate_av1_frame() already checks flags, quantization, segmentation, loop filter, CDEF, loop restoration and superres, but never bounds these reference indices. Decoders use them directly as array subscripts. In the MediaTek decoder vdec_av1_slice_setup_ref() does: int ref_idx = ctrl_fh->ref_frame_idx[i]; pfc->ref_idx[i] = ctrl_fh->reference_frame_ts[ref_idx]; slot_id = frame->ref_frame_map[ref_idx]; indexing reference_frame_ts[8] and ref_frame_map[8] with an attacker controlled signed value. In the Rockchip/verisilicon decoder the CDF setup does: rockchip_av1_get_cdfs(ctx, frame->ref_frame_idx[frame->primary_ref_frame]); indexing ref_frame_idx[7] with the unbounded primary_ref_frame. Both are out-of-bounds reads driven by unvalidated userspace input. Validate in the core, like the other AV1 frame fields, so every decoder is covered: reject ref_frame_idx entries outside [0, V4L2_AV1_TOTAL_REFS_PER_FRAME) and primary_ref_frame >= V4L2_AV1_TOTAL_REFS_PER_FRAME. The upper bound still permits the value 7 (PRIMARY_REF_NONE), which decoders handle explicitly. Found by 0sec's autonomous vulnerability analysis (https://0sec.ai). Found by static analysis; not yet runtime-reproduced (Rockchip/MediaTek SoC hardware required). Fixes: 9de30f579980 ("media: Add AV1 uAPI") Assisted-by: 0sec:claude-opus-4.8 Signed-off-by: Doruk Tan Ozturk --- v2: wrap a quoted decoder line in the commit message to satisfy checkpatch (<=75 cols); no code change from v1. v1: https://lore.kernel.org/linux-media/20260628134105.21001-1-doruk@0sec.ai/ drivers/media/v4l2-core/v4l2-ctrls-core.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4l2-core/v4l2-ctrls-core.c index ba047d7d8601..5096c48ea402 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls-core.c +++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c @@ -793,6 +793,7 @@ static int validate_av1_film_grain(struct v4l2_ctrl_av1_film_grain *fg) static int validate_av1_frame(struct v4l2_ctrl_av1_frame *f) { int ret = 0; + u32 i; ret = validate_av1_quantization(&f->quantization); if (ret) @@ -836,6 +837,14 @@ static int validate_av1_frame(struct v4l2_ctrl_av1_frame *f) if (f->superres_denom > GENMASK(2, 0) + 9) return -EINVAL; + for (i = 0; i < ARRAY_SIZE(f->ref_frame_idx); i++) + if (f->ref_frame_idx[i] < 0 || + f->ref_frame_idx[i] >= V4L2_AV1_TOTAL_REFS_PER_FRAME) + return -EINVAL; + + if (f->primary_ref_frame >= V4L2_AV1_TOTAL_REFS_PER_FRAME) + return -EINVAL; + return 0; } -- 2.43.0