From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C4C235F16C for ; Fri, 10 Jul 2026 02:54:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783652070; cv=none; b=JYLx2ek3qceJJDG4hCHcR09ictk5aKQETUyC/kKHEPa23iaw22yU3E59fUaI2vNs8gTj1VDW/sI7reXdZlraRPI/42XNlAAkHJ3j3C/qaMVctr5sN+GPcpeRZJEmspKlthAnGec9IwfdSTCGgxNmXyQoWHRxbJ0X3zIapGpPato= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783652070; c=relaxed/simple; bh=ZRQ0rtnnQB0Oq2dtTeQphk53sePamjzWEWuDue98Mlk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PRS2+e9kMq7JpZk3eXVhhqof6PxQFXgASyGVd5BogRV+AbF58ux9Ch++pVkoJwRj+mh6z95w+h9TZSY/OZaZnsYXuj+iWeExvgdHQrM1Afuwlu3+Z/eD1bWqukhtCjh0fQa2OkI4a5e4N1FsCrEEB7SR1gQoXdAbZ5Vnahkgb6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GnWYbhuX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hdp22n5G; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GnWYbhuX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hdp22n5G" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A2cJfT2473916 for ; Fri, 10 Jul 2026 02:54:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8srnsUWvtGuuuukabgqd6mjKla54hcWqMvwIgpbUTnI=; b=GnWYbhuXMgrgxBbG kJ2uEbofdKwgT0U/ixGKBhVZX5C3pyvYLtXuty7G2FQiL0VW5eet3RWp1rHzWUtg RC7Q2ON3TLDE2wExRm0s9EVQD39ksPMEq6eGSwc1eRrvM5oRaL+i6EzAXpig5KsH VxZ04CzldOOQgMGWC6BbH4pPxz9RhEG3rt1fx6QIqpzNSl4+LHniwzGqxC9/7bGe jpzNsoN27XhsxawFTyfJY4v8x92iyMOFHQUk12vs0j7JI9DPFsn2XPQ0Ytxhmfc5 nwPFH1+3LqWRHw5d8OPSQLQnYFhy2fJkR2wemy/+q99+LSXerKl78orL4gICnUdB YDvN/w== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4facqpjxyq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 02:54:28 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-ca7c1e22995so838874a12.3 for ; Thu, 09 Jul 2026 19:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783652067; x=1784256867; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8srnsUWvtGuuuukabgqd6mjKla54hcWqMvwIgpbUTnI=; b=Hdp22n5GJdkupe1PjFq5Jl4/I9pfktiAZPLH9CvPKNwzYj2CecJ6Zc5DOXrfWVbDcM qOJvV/d2u4BJQ2W6x4wNAz5pfQqh+0dW/5LQLe2zalkfbrZpWVaEHWV5fT4YYMSfN029 wva72pyl+6WAYU7/Y+pCdDTJGOqBxcnYFbUcOLW/Rp10p5YGFzhfUnhz1o5XRUPypZpN 9AWjXFR+J7VkvR+W89Z74ozpXFbM/gdxDJA+4wQfithQTnMKCUONYPWUCbXNrRAkbwzN +aa7leuMMmpCEUQ0ZcyNHIUm0E0uVdW5q4Nw+INFoiEGNGvnT5R+kjrDo0paKqHGSVUR lV0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783652067; x=1784256867; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8srnsUWvtGuuuukabgqd6mjKla54hcWqMvwIgpbUTnI=; b=dBmhDN9smYqnlwC+UT1gXoXSE3646lcz6Zy6ZHk/DizzEk6HKhvcrGIFUE4PnknVOU TBaAQmrjSnot6UC9htFA4YIWq6459bsr2vz6BmBd3WBKO/nxSAY7HyUK+n6BjKvBivq+ Kp+VyxTpPF5AzdIfYdM2uIgQIP9c+Zx1jGbjX6GiD9uvx87zRuzlTLMGQEKODcqW28r3 QWWVSGNRf9T1dSU8+MVFBfRieU7RtxoK4ikJ32CV7mPhuM53sSMZ2GAzOgWbd0KO1Z/t YmD3srlmidYQ2UjIXqUi6w3KhG7PT6QZRJdVsx505ELw7BoOgZAYd5Wjpc9kybhp9Jr7 RQrQ== X-Forwarded-Encrypted: i=1; AHgh+RrtzfZBdwE1AKZ4Ha7kIU2tXIiFF+bBUnjc+6n6rnvCMlLiyB5f0dZhgoTDWAOTln2Jz2NRh2aQcKIOMSc=@vger.kernel.org X-Gm-Message-State: AOJu0YwLdYbyStE4QbDMDi6fGDHuoATppZ1LmJxdKLQk7xGl6UuYnS42 3be13X5s/K8IdyCfMQ5kBPuxp49VlHhHk3rZq4OaUYG3lsSmavuY+9kw0SU5ZzZqi/byiK89G4O xvzs1rSGsQJPCwNybnU2+LMXYXHxbzAXgYNPa0fgmj/XNyaKKPWyU83IoDkqS4XkAIscjKZ+D7F k= X-Gm-Gg: AfdE7ckc9fTdvfO5QJHWoi2R2VnMDU23kIpAwepOcVDa+HKkM3Lbka3+xjSzI9ZpqZU 5sydw1hxhdNxct9kAKYhs5wE5Yd7qYQjHsyhrscDZjiAQOLRzwXmGzGUsGLaq6hQ7DBzFenrAYb hqBz2VO0F55RK5kYMzuIKnceCaCxdDmTW+uID/jW1BhwkxGQ0KFB/JK/vsx65zATdLLvzpU5zre 77MwrRbrNgPHx+XyLjBSHQl/hiLEtx9Qw62fti2XS/KW5zXCfyogQde+RlsMEcd+KFMf4+d8ePm 5uFHqZADWtUZHxiAIemP1/oZBi+5QVVMjyQHpkbwq0rjwMiGpI7RjbRUYNivqG9yOL/MfD/QgVj sao6vR03ZOMunWguPHsfUZ6Rb5o2OG3cCKqkAJR5CMG6W X-Received: by 2002:a05:6a21:10e:b0:3c0:9c19:65b1 with SMTP id adf61e73a8af0-3c0bd3acfb6mr11104569637.73.1783652067239; Thu, 09 Jul 2026 19:54:27 -0700 (PDT) X-Received: by 2002:a05:6a21:10e:b0:3c0:9c19:65b1 with SMTP id adf61e73a8af0-3c0bd3acfb6mr11104540637.73.1783652066768; Thu, 09 Jul 2026 19:54:26 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b6596681fsm41843220c88.8.2026.07.09.19.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 19:54:26 -0700 (PDT) From: Vishnu Reddy Date: Fri, 10 Jul 2026 08:24:03 +0530 Subject: [PATCH v2 1/2] media: iris: avoid bit depth validation for capture formats Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260710-qc10c_fix_and_disable_time_delta_based_rc-v2-1-701d6dfd1ac1@oss.qualcomm.com> References: <20260710-qc10c_fix_and_disable_time_delta_based_rc-v2-0-701d6dfd1ac1@oss.qualcomm.com> In-Reply-To: <20260710-qc10c_fix_and_disable_time_delta_based_rc-v2-0-701d6dfd1ac1@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Dmitry Baryshkov , Neil Armstrong Cc: Bryan O'Donoghue , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783652057; l=2168; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=ZRQ0rtnnQB0Oq2dtTeQphk53sePamjzWEWuDue98Mlk=; b=15LLH6rKDf939RdkOMJKOw8UWOxgXGNM5upSQQzewjZB15bas81M3g0OgGdZLgTWxxN2+9OVm I+MoJDYRt3wDX0yx5mt73PstfhI/x/CW/Vv366LqmKLKIuKH20eFs0+ X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDAyNCBTYWx0ZWRfX3ucV8iTSNTqh 0FknB+jNLU/YXSANo6yy3ZV0ljVExN2mN2yqNb6CUrwNi1pj/aZk1191rg7hJknVMniBinJnkXY dxZ+4PG0dL6/pU+flWpxZgRst+ysW0hiC0eOwVGver2zH7temsGAeicEXGquvoU8zfjY8RCCW56 pHMmzE7P2If1q9jfLIG4NpSqAgZgLcjyGb5gU2ScseklU7pr/XKKyOtlaPc3Nat0Tfm3Pka4sW0 W0q0vJIz7EveWz9+JdAJeJZ/qnH63gFyatHGgIE92GdZkTmJgKnH8u332A2tjCIPeOuWHyy92Bv /luNtjVobvOG/OzEgHPPXeg/fmZd3Fwl07R4+pxbkgoZod1nsLfJRcszh2+j821w73TARIYGLJi 9lnVFp2zbJIeeVd16Zf9v+LKCCs0lDnX5f4RIJnwuWnASVN4xx8Us08vx/AE1B1lygnnCgFZo4i bU7OcLio31Gh7f7qCEQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDAyNCBTYWx0ZWRfX/rSVAqH2Nsxe D8fwKyCmbeQvMGWm3Iof52MRfITu3rSde+hNFovevFVmQtplgwWu/5MN9fNq+yBrxnyth5YoaZp XYF7bAxrbPBnbPUJcY4dRldDY6/vqsk= X-Proofpoint-GUID: 8W_954WWdvPKRrqyCtE_ANB_zfGBoM__ X-Proofpoint-ORIG-GUID: 8W_954WWdvPKRrqyCtE_ANB_zfGBoM__ X-Authority-Analysis: v=2.4 cv=GJ441ONK c=1 sm=1 tr=0 ts=6a505ee4 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vL0Q6q4W2X9FnyRf_zQA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_04,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100024 When validating a capture format, check_format() compares the requested pixel format against inst->fw_caps[BIT_DEPTH]. However, the bit depth capability is not available at this stage and it contains the default value of BIT_DEPTH_8. The actual bit depth is updated later after the firmware reports stream capabilities through read_input_subcr_params(). Because of this, a valid client request of QC10C format request is rejected during the initial format negotiation. The driver then falls back to the default capture format (NV12) and stores it as capture format. Later, when the firmware reports that the stream is 10-bit, the driver sees NV12 as the selected capture format and switches to the default 10-bit format (P010). As a result, the original QC10C format requested by userspace is lost and QC10C decoding cannot work correctly. The bit depth information is not reliable during the initial format setup, so it should not be used to validate capture formats. Remove the bit-depth checks from check_format() and only verify that the requested pixel format is supported. This allows the format requested by userspace is handled correctly. Fixes: 20c3ef4c7cae ("media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats") Cc: stable@vger.kernel.org Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_vdec.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c index 9e228b70420e..7f89e745a4b1 100644 --- a/drivers/media/platform/qcom/iris/iris_vdec.c +++ b/drivers/media/platform/qcom/iris/iris_vdec.c @@ -95,16 +95,6 @@ static bool check_format(struct iris_inst *inst, u32 pixfmt, u32 type) if (i == size) return false; - if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { - if (iris_fmt_is_8bit(pixfmt) && - inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10) - return false; - - if (iris_fmt_is_10bit(pixfmt) && - inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10) - return false; - } - return true; } -- 2.34.1