mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ricardo B. Marlière" <rbm@suse.com>
To: "Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"Jiri Olsa" <jolsa@kernel.org>,
	"Emil Tsalapatis" <emil@etsalapatis.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"Alexis Lothoré (eBPF Foundation)" <alexis.lothore@bootlin.com>,
	"Ihor Solodrai" <ihor.solodrai@linux.dev>,
	"Christian Brauner" <brauner@kernel.org>
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Ricardo B. Marlière" <rbm@suse.com>
Subject: [PATCH 1/4] selftests/bpf: Install bpftool where test_progs expects to find it
Date: Fri, 10 Jul 2026 19:09:37 -0300	[thread overview]
Message-ID: <20260710-selftests-bpf_fixes-v1-1-aa24dfd6f4f9@suse.com> (raw)
In-Reply-To: <20260710-selftests-bpf_fixes-v1-0-aa24dfd6f4f9@suse.com>

bpftool_helpers.c looks for bpftool at "tools/sbin/bpftool" or
"../tools/sbin/bpftool" relative to the running test_progs binary, matching
the build directory layout where bpftool sits at
$(OUTPUT)/tools/sbin/bpftool.

INSTALL_RULE installs bpftool through the generic TEST_GEN_PROGS_EXTENDED
mechanism, which flattens it straight into $(INSTALL_PATH) and loses the
tools/sbin/ prefix. After "make install", every flavor of test_progs,
including the default one, fails to locate bpftool, and bpftool_maps_access
and bpftool_metadata error out with "Failed to detect bpftool path", even
though bpftool itself built and installed fine.

Explicitly install bpftool under tools/sbin/ in the installed tree
so its relative location matches what detect_bpftool_path() already
expects, restoring the pre-install layout instead of introducing a
new one.

Fixes: f21fae577446 ("selftests/bpf: Add a few helpers for bpftool testing")
Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
---
 tools/testing/selftests/bpf/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index b642ee489ea6..47911c9b4977 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -1055,6 +1055,8 @@ endif
 DEFAULT_INSTALL_RULE := $(INSTALL_RULE)
 override define INSTALL_RULE
 	$(DEFAULT_INSTALL_RULE)
+	@mkdir -p $(INSTALL_PATH)/tools/sbin
+	@rsync -a $(if $(PERMISSIVE),--ignore-missing-args) $(TRUNNER_BPFTOOL) $(INSTALL_PATH)/tools/sbin/
 	@for DIR in $(TEST_INST_SUBDIRS); do				  \
 		mkdir -p $(INSTALL_PATH)/$$DIR;				  \
 		rsync -a $(if $(PERMISSIVE),--ignore-missing-args)	  \

-- 
2.54.0


  reply	other threads:[~2026-07-10 22:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 22:09 [PATCH 0/4] selftests/bpf: A few edge case fixes Ricardo B. Marlière
2026-07-10 22:09 ` Ricardo B. Marlière [this message]
2026-07-13 15:32   ` [PATCH 1/4] selftests/bpf: Install bpftool where test_progs expects to find it Alexis Lothoré
2026-07-15 21:40     ` Ricardo B. Marlière
2026-07-16 21:09     ` Ihor Solodrai
2026-07-17 17:03       ` Ricardo B. Marlière
2026-07-10 22:09 ` [PATCH 2/4] selftests/bpf: Install resolve_btfids.test.o.BTF where the test expects it Ricardo B. Marlière
2026-07-16 21:10   ` Ihor Solodrai
2026-07-17 17:02     ` Ricardo B. Marlière
2026-07-10 22:09 ` [PATCH 3/4] selftests/bpf: Fix lsm_bdev dev_t encoding mismatch Ricardo B. Marlière
2026-07-16 21:11   ` Ihor Solodrai
2026-07-17 17:02     ` Ricardo B. Marlière
2026-07-10 22:09 ` [PATCH 4/4] libbpf: Search /lib64 and /lib in resolve_full_path() Ricardo B. Marlière
2026-07-10 22:58   ` bot+bpf-ci
2026-07-16 21:12   ` Ihor Solodrai
2026-07-16 21:07 ` [PATCH 0/4] selftests/bpf: A few edge case fixes Ihor Solodrai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260710-selftests-bpf_fixes-v1-1-aa24dfd6f4f9@suse.com \
    --to=rbm@suse.com \
    --cc=alexis.lothore@bootlin.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox