From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012000.outbound.protection.outlook.com [52.101.126.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1A7741168C for ; Fri, 10 Jul 2026 10:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.0 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680852; cv=fail; b=pfS1JrE9VX5+BEF9DzuCONfBHK2Cwjx5LbkKjKW/guT91T18AP+xMxPz1UOoOBR6/pAL5gfVPGT0uJiRyvJ9b8h7at2axURDCtZzWFAhnpRQzPkTMBLUybr4WHmXSgAu1pjVkJ2TR4VA31NbEwH+8b5YzE99ukciz/GfXIqnGBk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680852; c=relaxed/simple; bh=l5JwS64xqOxDl/2tI7oNOLtZei4rgW1MkmU9pCVgJps=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=o1nitf4OYPxJXWsWdwFhBxaJ+7OxiNnKzrBOfgPBXAmz+UsJP/Rp/sqQDpdXpkqv34G9HWJDsJ1CpzUYnn1WcPRrd6j4RudIX9jDpGGWuq5zTwSaE1dQgB4qj6dDodlcuyAiJhSh9LbN8cRo6dJ8KdGkqCty3ZF4p9p/kEtweEY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=JFbwikqn; arc=fail smtp.client-ip=52.101.126.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="JFbwikqn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q0B3uzPP/acvM59LCkE7NlkjsVyPGhMTpuvDLL+/oK7VqaZWLunzAFWbrm1sc3KgTxeyKE4snS74PNYbXLpZauBmso4BEBOvL/OFN+av2XRdZ0YNfOw+PU15jDWmKWKbpmvl+6zOL2/ZH7lKXOVWUuGJbsrLQLAcmwkcKi6mwFNyBtU9Q02+Fa1sqcdLb0KELwQtlGK66Q8en3uznRFYd0QegKo7nmnBeaXQNwva9gmoz2sAh6Iqsh2euf4whhbBnN6P7l+XZKyVxGyJFHMgILKQD2sL2Se5/pxrBTB3/MVg5SkAGtcOk0gJIdc8TS2Yt95gG8/TlxdNwgj5xNjYww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nTJ4b4Phy1+NpVa7xhIBePP0s74V2ApHDJe0ZLomhfA=; b=aH0tDz45uuz9Op8/QP0KMx936BCN+ooqq+e0bM4AsdhnNyIg98WxsOpQcnFdNWkXsBR1VjPXqjw2QOyWWHuvFBS6K5nKBZup4o9tdeapJEe2/M1rR7wWuykuRL/9L1MtIsJ3/+JfR9RGCblnoIPGGQsmTtSToTN33Ism9O0FvSEcGD2yniS5XF4uZyS8D8n4igXQchEgAqwfUxoH5OqT7L9+W4AGJStSzN+UttlL8m25uJPcg/Mg+3C9mqaUyMTCwkXuR1yOXsrFm5uNtdHQW6vr1psVC7yNkV32cNnbFin6y6TIh3uU48lnpaYYaZHBB+9pi4bxtHma/IpnSXEORw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nTJ4b4Phy1+NpVa7xhIBePP0s74V2ApHDJe0ZLomhfA=; b=JFbwikqnsOr/M2xXKFHS8W5xgvpijnMUe+7CrUw6nAnyJHGrm6sww/dN+Otj+ZH46VTw2+zaqllpY9dUav+OPN2tOjc+7/ZQ1fCAaCKwlDKwGZvb/srLGQ1X08GAD4/qDFutV1rWNx0GC6NfTF54Y+1z57Cuf5qvf/ftQcjN1krlB9DmZbkNCGc5eIr+qzPEIaUQVmYVgQXmyNMd4AUsmn3jSkvehCfrzV1qLFB0o4kEQYgEH8QpPRJ8jOlR8nzdeLDCB71xOOSC0F35+G/DmnXv3pF9fTig0EZAyd7cjTZi0x4RX8IrGDz+9NnNr9c27vlXShJfDKKidVJ4B584gg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KU4PR06MB8388.apcprd06.prod.outlook.com (2603:1096:d10:7b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 10:54:00 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0181.016; Fri, 10 Jul 2026 10:54:00 +0000 From: Pan Chuang To: Eli Billauer , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org (open list:XILLYBUS DRIVER) Cc: Pan Chuang Subject: [PATCH 3/3] char: xillybus: Remove redundant dev_err() Date: Fri, 10 Jul 2026 18:53:08 +0800 Message-Id: <20260710105318.376496-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260710105318.376496-1-panchuang@vivo.com> References: <20260710105318.376496-1-panchuang@vivo.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TP0P295CA0021.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:5::12) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KU4PR06MB8388:EE_ X-MS-Office365-Filtering-Correlation-Id: f3e2134f-59ef-403e-37cf-08dede718c78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|52116014|1800799024|366016|38350700014|11063799006|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: ROb+yv1lCx5M0lXi6krpmzpGTxDLs31VwwJjlJe4nANWih8kAIahals8RgqkGvAFnuYdDqeqb+VAjkdVSeQ8eEZRFEswbTmb4VVD2GOzxzlJfvXVthb8cL2mq348+KmC9j1D0Am+XCPXBw5VxbMyLWCsmLIz9PhlZWNpjeDGF3TN8x+nH/aT5Ks8Ky2Q3MCa2WxfZBRIj7xTyMcoJly7tuzl/BpMftn0hPy/4Kip2MaYUiDiJmW7rVw3/yk2nXbmjHQxypVrS9l4vytYc7lgG3BdIk8rO5IeJkSoPtI7CULhd4RhNiFwueDjhOxEpIzumAcUnYAp4zYHjvXipIwiI8+uPRfu0AbyohEgdgU50rttGNE8YwbHw/MqJWnN5JukJaAvRDUL7YSfgouwrHzuIiQ4o+9sBvoAlYQQYXQhQ8ngJF+Cv1ONQ8FbE0XYgexY6LvcxtQNi7PmkYXowlwk3caZF3CMHUbFP1U/ohQVvvBKpakgDW7HR8S9u8M3cpz8oLx5hlm/0TVCHZCrj1FNRDJgtTvr1rpgJfuaEx3Yzuh5GDT530egZsVbY84LsT6ejJ0GPLUvLqjVVBF3Q7Ry4URGdB9RSJg7RlCrcB3jZpz7ukiL4ujQF+EJff0HA+dx1jd+kUieQLHSzrQp3fhNh3CDxa9PIlrlvbGnXNij76eZx8W/rfy/fZbSKJ/U9mpjcZIrcHY3+QnFtVPTIzcX/LTQIGgoUSeN/tVqbeE9be0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(52116014)(1800799024)(366016)(38350700014)(11063799006)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j8ePMA2mrABOwbEAnhcOKthLi1rqDomwTrCmHe6h+pAbHaS074XdjUPeSdzq?= =?us-ascii?Q?x864Yi9YHr2FhXGvejQifI1JQ0eaRUSGDczmxP4D8BvFTw/REYjImCB+ABay?= =?us-ascii?Q?REfgQFUq+9+Z7zrUJxvq4pPNyfK9S0MXEIRdPwGG4OhR3SuX25X7z7SRvWy6?= =?us-ascii?Q?OxO2SC0ClqJRqAlL35x5VIXEOQHxtGqlfjs8Y//eJM4NIzSzjtbjZ7h+tfHw?= =?us-ascii?Q?2OwUPkHsLTCAJkOXm8uhvRwZgL1M7bw3VsF3zkANGIvb+7ewNqId+ek0knEF?= =?us-ascii?Q?eYVWzX6u2Q8Nwwg5kv9u0LYE46azaKqQgdtIFB56QMmuDlk8fIrnY+TpotjA?= =?us-ascii?Q?JZneBir+s7lgdKxwPsG0V9qHhheQEVS0RiPUCqi31OqyibA9ZSkL6ao4ba3O?= =?us-ascii?Q?BENWLr8OjWTI9GDkTGjfwvp9hNKIMV5U+i33DUlWjuMYNwejvRQqzlhDAw8u?= =?us-ascii?Q?WjVolgKIhxsgpC/mnSXStsBr76XwpwKJzv38sQPCuhEcF2cJgxhVXXUgkbCD?= =?us-ascii?Q?d0JuNhrtmDqTZJAb8pmbynuZq6DFAa42KLYhU4A8amwpVA7HKHSd424EmbGM?= =?us-ascii?Q?ZeLuJtBD7D5v2XNwtI6yBIK6lDH+cQEzJB2aDsDyo4oHsVFerLxPIVyAnwcD?= =?us-ascii?Q?A4Qc7Tc2FRr7EF4qlo+3yTBYJxdg12nxezdDXPrGt9+s09Y9YufJzom5bNiz?= =?us-ascii?Q?PLD+B8sPbF0GHBXfGQnZMY7DIMEvj5VGRO2UN1xlWpWXSIKnegYKCW5KKY7k?= =?us-ascii?Q?mctTjSW7CnJvssHaT66RaMeJ8Ic7kb8eSXIej6/3ZBLcK/v9tQM/TuGKobMh?= =?us-ascii?Q?bk3TiiFMWqgy4287wM0oeAQ6WDT7dgttfuvcBigF6t+C5BB3gCCwfUp+211r?= =?us-ascii?Q?1ArbeAR6ZfvNb1O5sw7tPOVmcRyeL+cd/VrSDU+AJTNqP/FafWBpgY6QbIoZ?= =?us-ascii?Q?Mn64CQqY2t0zvhnPYE7SYMjlLI7UJq2nys0ZU2TNRjgVINqQdiGSePaWRuzj?= =?us-ascii?Q?6bAFzImV2VAAok96uqqt8zy9w6T911Bu78Vz0yHnL04xku8dGqwkOYoQN1sy?= =?us-ascii?Q?HEjmP/DOcQW/9Ca8onxMrklxgVWzplTOb4tgIsHe3GA3V2NTCIWXHqB2zdgF?= =?us-ascii?Q?f+uwZpdjMzjDhRleY55ZrSc9RsKRl/p8iCBuve2kslvQo4R6S7OIUfalev4H?= =?us-ascii?Q?kFshmm38EQNxAjYvI6YEqHE4U1hhXE49aqJcJCZ8bP5rH7y22T+J7QPWHbJq?= =?us-ascii?Q?aAUrDxYVe6a9v16PDpZcARjMZlfd2XYeIZXsAgHD3wdJAFuEe12EVxHjOqG2?= =?us-ascii?Q?st/+q5t08r/coDX4hAMbI80UNwD2/mrrkQvWxzqqiyqcZohPvs25SiVMzCca?= =?us-ascii?Q?TjEEQOJXxFK/0Kry1+KZgVCdTqT14hCz+QpAQqap+dwJcDlUz1KezzCnI4ah?= =?us-ascii?Q?z/HEXfoL92+PwCjXhZP4toPVj7WDwL2QgareH5Z5dkj3KiU/S91sjtBv/VDu?= =?us-ascii?Q?b7N5vXtiS6K87/+TxuvLvvhuMsy5wxhdnSwKTE4fvzxtuBMGGskcIh0rU8z3?= =?us-ascii?Q?xWkxLusxck/3JJxfzlP4DP+FiCYUIZ8q8uU43Ttp/jM/qu8QDLubdap/1vJg?= =?us-ascii?Q?MzGpxyQ5uuJLQDofdf/PvBpDd4JaCqbO/TPrEra1goSSCgOdKyq9JS5AA3AN?= =?us-ascii?Q?HsmFfq8HWDUpk+hhger9kEwBwBVLKqA1oXMRQzAZTI295SC+C7JWpmM+urxM?= =?us-ascii?Q?T7VOK4yw8w=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3e2134f-59ef-403e-37cf-08dede718c78 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 10:54:00.4273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bqH97zECugA6DRoENGppJs+dMb81bdxxiBkz+kTCftGhNPU+0weFlgquO2OCTFLsHuLmFljlGIgy0VJwZkHXaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU4PR06MB8388 Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/char/xillybus/xillybus_of.c | 5 +---- drivers/char/xillybus/xillybus_pcie.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/char/xillybus/xillybus_of.c b/drivers/char/xillybus/xillybus_of.c index 1a1e64133315..46e1046abfca 100644 --- a/drivers/char/xillybus/xillybus_of.c +++ b/drivers/char/xillybus/xillybus_of.c @@ -55,11 +55,8 @@ static int xilly_drv_probe(struct platform_device *op) rc = devm_request_irq(dev, irq, xillybus_isr, 0, xillyname, endpoint); - if (rc) { - dev_err(endpoint->dev, - "Failed to register IRQ handler. Aborting.\n"); + if (rc) return -ENODEV; - } return xillybus_endpoint_discovery(endpoint); } diff --git a/drivers/char/xillybus/xillybus_pcie.c b/drivers/char/xillybus/xillybus_pcie.c index 9858711e3e79..32064b6c7627 100644 --- a/drivers/char/xillybus/xillybus_pcie.c +++ b/drivers/char/xillybus/xillybus_pcie.c @@ -83,11 +83,8 @@ static int xilly_probe(struct pci_dev *pdev, } rc = devm_request_irq(&pdev->dev, pdev->irq, xillybus_isr, 0, xillyname, endpoint); - if (rc) { - dev_err(endpoint->dev, - "Failed to register MSI handler. Aborting.\n"); + if (rc) return -ENODEV; - } /* * Some (old and buggy?) hardware drops 64-bit addressed PCIe packets, -- 2.34.1