From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E212C4266AA for ; Fri, 10 Jul 2026 11:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783684583; cv=none; b=KmnmGSA5klKe2GE5Q3xUvVBTWOs57vF9it0CzmXD83Qpvbn93qHweJA2b3tTzEotDvB7qFa/o/dMULxXKvjO9Ut1WKoGi6YwOOU+Gt6j8MHcPgc72hkbC9H3gyed0CP3lnzx9ZrscJSpK7k5m4xk+kGPRQZ09UN2qJkWhC0J1d8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783684583; c=relaxed/simple; bh=zLGEpiegRh4FFq0BMnzwA9fu2/Q7LJvjrYlVm3SdoCo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jLDiM+kFZnr8Z0leFqROUgs/QSP6Ptqd73ZLNYhKDAYIpiMOs/ogIqzaJbMaJEJHcWET3MmGfj+28pQ/AYEhXTdCfDPfUKmq5VuVrUSHsJuDNP0t7Pv+BaRd9YHohaed/oBd88t3s8mGhOgAXy3jF/t2iFXA0eVCLyCSdsQPnw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=nYcHC9r0; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="nYcHC9r0" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 347361EDB; Fri, 10 Jul 2026 04:56:06 -0700 (PDT) Received: from e134344.cambridge.arm.com (e134344.arm.com [10.2.212.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 38A8B3F85F; Fri, 10 Jul 2026 04:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1783684570; bh=zLGEpiegRh4FFq0BMnzwA9fu2/Q7LJvjrYlVm3SdoCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nYcHC9r0kTZZFOTYqijD1QvjLT/UAiUXTYSgwn9Kb+fSYiyb+YP1iRlwQKkGYw6fB T3vj8BQ2F8ueSi9Y0EI4pIbNXgwi2WijxyRis9swT8ZIXybL9mkB8/GPIq+KsDDigY jSrYrCbLaRsAhAo+WhEbGtDWW+vQJ60EBhu9lc/w= From: Ben Horgan To: ben.horgan@arm.com Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com Subject: [PATCH v1 09/11] arm_mpam: resctrl: Make read_mon_cdp_safe() self consistent Date: Fri, 10 Jul 2026 12:55:43 +0100 Message-ID: <20260710115546.29644-10-ben.horgan@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710115546.29644-1-ben.horgan@arm.com> References: <20260710115546.29644-1-ben.horgan@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When read_mon_cdp_safe() is called with cdp_enabled equal to false then the reading returned in val is the sum of the monitor values for the given component. However, when cdp_enabled equal to true it is again the sum of the monitor values but with the initial value of val also added. Change the cdp_enabled equals true case to match the false case. All callers zero the val before calling and so no functional change is anticipated. Signed-off-by: Ben Horgan --- drivers/resctrl/mpam_resctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/resctrl/mpam_resctrl.c b/drivers/resctrl/mpam_resctrl.c index 59dea750ff56..d97565479014 100644 --- a/drivers/resctrl/mpam_resctrl.c +++ b/drivers/resctrl/mpam_resctrl.c @@ -487,7 +487,7 @@ static int read_mon_cdp_safe(struct mpam_resctrl_mon *mon, struct mpam_component if (err) return err; - *val += code_val + data_val; + *val = code_val + data_val; return 0; } -- 2.43.0