From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 96BBE42255B for ; Fri, 10 Jul 2026 11:56:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783684580; cv=none; b=mCgV8PKVEIXzScMaRXmYma73LtXJ+rzfEBNgv10U60J+DOrDsK5ayOF1aQt8kl8b8ouLfaiqMztWflaYE/7CNH5NasDk8DS5dLyDcPE90vSjd7W53p1pwbvA8rx9rhQeJMNlI9/sX5X24qnnu7huGuCxvU2kNjPIEUpYlhWoq1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783684580; c=relaxed/simple; bh=IhqgtJ551+2AeSwFpzXLRHOVZq41eD4WsNI+b8vq1tw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kFB+tGKC+zulAW4vdLSDFKavpS6XIoehjw6a6LYNYgIvOW+wCvsjG5slBPoFivclQMCtbt7SmVn0X3dNXOF9vn4m39gC1AgxVk8P1A3DHcN1lBG8PipoG1QruZCVXSDvvnUCvT6MY6CnMJ4+CPiH/cmTwBE7clm3InmmeMWBQF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=cDaJUQ8/; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="cDaJUQ8/" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 08ECE2328; Fri, 10 Jul 2026 04:56:03 -0700 (PDT) Received: from e134344.cambridge.arm.com (e134344.arm.com [10.2.212.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 148503F85F; Fri, 10 Jul 2026 04:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1783684567; bh=IhqgtJ551+2AeSwFpzXLRHOVZq41eD4WsNI+b8vq1tw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cDaJUQ8/PWoExErsDnu7+UF3RhX+jeze4GyzNpulPD67xdWd6Lf092pxuD+Qgki9K nrfbxEG5xy9IXuBgPL0kS+8l6jFEs+Ab3wQ1iva4GbTqsEHJlfD8/y2EuyfptdROHQ z4ElX+kFYDp+PczEeyNWEBi4FUOs+4A/gev+FqG0= From: Ben Horgan To: ben.horgan@arm.com Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com Subject: [PATCH v1 07/11] arm_mpam: Initialize all of struct mon_read in mpam_restore_mbwu_state() Date: Fri, 10 Jul 2026 12:55:41 +0100 Message-ID: <20260710115546.29644-8-ben.horgan@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710115546.29644-1-ben.horgan@arm.com> References: <20260710115546.29644-1-ben.horgan@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit m->err may be read before initialization in __ris_msmon_read() when called from mpam_restore_mbwu_state(). Initialize the whole struct mon_read in mpam_restore_mbwu_state() and fix the spelling of mbwu in the name. Fixes: 41e8a14950e1 ("arm_mpam: Track bandwidth counter state for power management") Signed-off-by: Ben Horgan --- drivers/resctrl/mpam_devices.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c index a49f426aefc0..c9adc450f087 100644 --- a/drivers/resctrl/mpam_devices.c +++ b/drivers/resctrl/mpam_devices.c @@ -1640,7 +1640,6 @@ static int mpam_restore_mbwu_state(void *_ris) { int i; u64 val; - struct mon_read mwbu_arg; struct mpam_msc_ris *ris = _ris; struct msmon_mbwu_state *mbwu_state; struct mpam_msc *msc = ris->vmsc->msc; @@ -1653,16 +1652,18 @@ static int mpam_restore_mbwu_state(void *_ris) return -EIO; if (ris->mbwu_state[i].enabled) { - mwbu_arg.ris = ris; - mwbu_arg.ctx = &ris->mbwu_state[i].cfg; - mwbu_arg.type = mpam_msmon_choose_counter(class); - mwbu_arg.val = &val; + struct mon_read mbwu_arg = { + .ris = ris, + .ctx = &ris->mbwu_state[i].cfg, + .type = mpam_msmon_choose_counter(class), + .val = &val + }; mbwu_state->reset_on_next_read = true; mpam_mon_sel_unlock(msc); - __ris_msmon_read(&mwbu_arg); + __ris_msmon_read(&mbwu_arg); } else { mpam_mon_sel_unlock(msc); } -- 2.43.0