From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A57A382F01 for ; Fri, 10 Jul 2026 19:08:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783710491; cv=none; b=qNIPx+aSDCpGWWkVnvrqGARt1YnvDZCWx8b720qm3ZlV2pTdW6IWvP5XqZx5Va1k+JY3ixcO/nWFTRfsQ0cBNmuSRReI9i4bBw4Dhu3bT12od6O2cKE7bvzHx3/o1vJ9dDoB0Z8mzFSRW5eU8bZX+th6ElEhE1Eqmour/I8L+98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783710491; c=relaxed/simple; bh=yeE7iN6mEU/fzO3uJ3RR15BZwTZk8YNzVd6nf0zWZxU=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZW1QaJfemnYCFj59HcoYhhteYZn1oorFYDtTkFg9HErg7tBdJU0HIJzok9dPoPkW0DzOWZj3jitXo19sI9ESJZO/va0KxQJMAtmz2CbopgdP1EqUwBHW6Hi92Iu+HQfP+MrYDFzuq1shLr2rABRC2d8pp5EMA0CP/ppeAvQOk3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a67IKIth; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a67IKIth" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-493b77b150aso11105535e9.2 for ; Fri, 10 Jul 2026 12:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783710483; x=1784315283; darn=vger.kernel.org; h=content-transfer-encoding:reply-to:content-type:mime-version :references:in-reply-to:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to:content-type; bh=XYmheRZks84ebbE/VW7oiD93RBquqkXcsU3VJTJ0fDE=; b=a67IKIth9KErnEJn/X9ISydT5AKKwDmmRKVJJuINHPlcRgK4x2wngMLX0qNyaqj9LU MxdB1ceD+FkGqKm0t23bcrsuRtoVUvo2v++ixNJO2FGbhr4k3axHm/gG8vuNnn41grG8 euBlJaeQG0ldeJ+N7ta5kfc+IeJBc6Vha1EENLd8cuCCS0nlbIriwSKzMFqi6IUhNJSz k5vYPvaWOsvdWwKCapEPlXcpy7HVCUU2o6fZ8Nhtc+2wGxxS/5Tt/tsMzoI8rAODa6GX ZfdbRbh4lLVPErdNFMuYkgesBhqNf3G2Ve5VtqQEz0TsxUXL0mpj+be8aw0erBNMRXDr fS2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783710483; x=1784315283; h=content-transfer-encoding:reply-to:content-type:mime-version :references:in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XYmheRZks84ebbE/VW7oiD93RBquqkXcsU3VJTJ0fDE=; b=hq8iumT/3EWKEdINciPCZadRjNLMZnxjj6pIpOXjGoPL59aXOqT55xCnJEjbw4T++T 4ZMj9f/bgiK/5JTnnbf6vBaNNjJWbgkfGc7eCasJx7UwAsli4nmWgtq2eAN0MegUUUU/ /9DqropxKEzXS5aXLcpy2ImuuuGPCCqJX8Yg/vOh6i5BeXinMwSGG0Oy/GdypqG+sxVk CAKNXjpCJ6vFgGOrpkbP9xCFm6J8qh0jSVmB3J0sI4BcTltpyjQzEWei7uMeZC9njTiM FskW4dD+qd0lUlQzy8Szm7iOPviiFHveIZDWFaYyvIOXGgRiA1kwTOkQU9RdkBfrNMMr CFEg== X-Forwarded-Encrypted: i=1; AHgh+Rr0m7iFmnkBdNjPYKBAkaLWNggPGplKgElmv896iiUO4qsF4VQMVt0HlYcj8otHZiryImYZB5AWLVvnrG8=@vger.kernel.org X-Gm-Message-State: AOJu0YxBXgsjhoPIP/jusN8IIrUJpEg8NoSXi0TFwpW/ItDG2Okn7Ces FVIkw3nYDxcKInEcBM8pzd4WWwu2o6CWj7p4DURZr3DuRntbZ0vF/3TF X-Gm-Gg: AfdE7clVOVrXOa46hOkN8svEx73G0POflgdcw6NGksDktheToYxNKGfT1Sc2vJ4+4ZV 8KXO8d/1I0sZumEC/FPzPuwDrKzOmeeUhcRvncySHHxf8GPltaemo2sCvIKqsN/5LO4yXExkBnc pwwVfD35GglLfB+oZQQZ27UYI7Caf0nY2vLyaTqmQhJwqB7fpDd9a0G5eGQSvzXRONjoIHYoz8E /TvCLAUXlCfjqxqOmTquOIncaIMCk5kWivBVwQfYNxJQ7aVFRoJeGv6DD7hkzscF48ygo9OukUn 8pdzoI2yrZpRaTwjvC2j02VtEzqpOF862hVomESnCMUJN/Jb6qtLvvVvAfNSm9n56wn5Hda5rkg QlhvPvcXv2FGhsxvVYP5tZ6DIiwU76BC23PIT9mvDr035q72VF7s0igqm24OqjtSDxo1BAA/fvK NzkT9g/EqOThZbtL2/T2R6wXGgMw== X-Received: by 2002:a05:600c:1502:b0:493:c773:c3f4 with SMTP id 5b1f17b1804b1-493f881d64cmr624905e9.22.1783710482709; Fri, 10 Jul 2026 12:08:02 -0700 (PDT) Received: from able.fritz.box ([2a00:e180:154f:ec00:aa08:de24:db33:4496]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f567eadfsm55000755e9.6.2026.07.10.12.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 12:08:02 -0700 (PDT) From: "=?UTF-8?q?Christian=20K=C3=B6nig?=" X-Google-Original-From: =?UTF-8?q?Christian=20K=C3=B6nig?= To: thomas.hellstrom@linux.intel.com, dakr@kernel.org, ecourtney@nvidia.com, simona@ffwll.ch, matthew.brost@intel.com, nat@pixelcluster.dev, airlied@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH 08/12] drm/ttm: use dma_resv reference in ttm_device_clear_lru_dma_mappings Date: Fri, 10 Jul 2026 20:52:48 +0200 Message-ID: <20260710190752.2355-9-christian.koenig@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710190752.2355-1-christian.koenig@amd.com> References: <20260710190752.2355-1-christian.koenig@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Reply-To: christian.koenig@amd.com Content-Transfer-Encoding: 8bit Instead of trying to grab a BO reference. Also lock the dma_resv object, that TT unpopulate is done without holding the lock looks extremely suspicious. Only compile tested! Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_device.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c index e4188e2ee7ab1..be6fc42772f9d 100644 --- a/drivers/gpu/drm/ttm/ttm_device.c +++ b/drivers/gpu/drm/ttm/ttm_device.c @@ -293,19 +293,29 @@ static void ttm_device_clear_lru_dma_mappings(struct ttm_device *bdev, spin_lock(&bdev->lru_lock); while ((res = ttm_lru_first_res_or_null(list))) { - struct ttm_buffer_object *bo = res->bo; + struct dma_resv *resv; /* Take ref against racing releases once lru_lock is unlocked */ - if (!ttm_bo_get_unless_zero(bo)) - continue; + resv = dma_resv_get(res->bo->base.resv); + spin_unlock(&bdev->lru_lock); + + dma_resv_lock(resv, NULL); - list_del_init(&bo->resource->lru.link); + /* Double check that res and bo is still valid */ + spin_lock(&bdev->lru_lock); + if (res != ttm_lru_first_res_or_null(list)) { + dma_resv_unlock(resv); + dma_resv_put(resv); + continue; + } + list_del_init(&res->lru.link); spin_unlock(&bdev->lru_lock); - if (bo->ttm) - ttm_tt_unpopulate(bo->bdev, bo->ttm); + if (res->bo->ttm) + ttm_tt_unpopulate(res->bo->bdev, res->bo->ttm); - ttm_bo_put(bo); + dma_resv_unlock(resv); + dma_resv_put(resv); spin_lock(&bdev->lru_lock); } spin_unlock(&bdev->lru_lock); -- 2.43.0