From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1F9D288C81 for ; Sat, 11 Jul 2026 07:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783754984; cv=none; b=UH/dRHx9nvvD7R8QWhw6EPZ8kzQDZ4InRgnrgRuTlytpac/ZX21+GIIJuLyTxRdG5oJMLfd1GoeJ7MNxfIN6qYck04/mk/p4PnrpS8yaScWeOhvw7BY2oJ+cPGK4d6ZYi7FRybESLl+D8L1bFkdeNYfldoXTWSM0ZW6jtxcaYZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783754984; c=relaxed/simple; bh=/XlkIXDNyCf52m3eODYUQTRTmkrRjD16hDtyTWWG2aU=; h=Message-ID:Date:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=lnWh92F58ewXnvJz2Y2c1L+FtMzTNrUIP/h4IFz1/tObO5S+r3KZncwZ4jP2ZRErtCxWgnsw2FWTvQ4RMqZ4/JtUR948iydrIvgWLtHS71p/lzV1OLft+okV13JC9KNHxWzgOtXOAGu8NXCSCcfZ7E/dimCFxmkTETjxhGOqShc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c4yAEAEm; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c4yAEAEm" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c99eaa1f020so1600487a12.2 for ; Sat, 11 Jul 2026 00:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783754983; x=1784359783; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:date:message-id:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aECS2VE/JAEE5/6Q1Vp8WOCO6a5H3TmUFObfoCBKPk4=; b=c4yAEAEm1oReqza7mQCT9GPYlW7c5BxCNuiYwODgtxb5UAguhr9UL5V01T29E8PCLt p+4W8v2p37/aq+kB6+Sy+wpVYiGV0SOMxTM4tIk/AsI9uoVnFi/jTau7lLHQ2w4/EP+J jVLaUdx6+3md2yXxxqfdeLkSOr9SLUx/0BcTcaHVtv2e8mXeP/iSiDnkknZAz5XJYd+U 13VNxFF3GNJqVE1EqhtOtCKid4l5khR2r3WRPNi3vaBXiCMHoiAf8Iq3ZBlx3+aA63m6 /TRdmj47XOmt5FNVdoikSjh4r7skOh0IIL6iq01UaKKpV6/PRXcJVeBviGqqwTBRQIzq LGNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783754983; x=1784359783; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aECS2VE/JAEE5/6Q1Vp8WOCO6a5H3TmUFObfoCBKPk4=; b=JxBIuWHv8Mexjoq62i2yTfKUrhdENaYN3qmSQKVEXv1bj9DFMn+oxXaqN17zvwG6u7 C3rD4mlKUFEshCS0CzVNxw1bF9VLpylbi1OaG+iiwEo1MN8gFuRN2ubaUJt7bshX51qI x8gYbtlf1w+q0ZO7UDiQPBS0gB4q3g2mi8x2bou7K0QZxr7n70HaFjlfiX8RNpadaW6W 4vG6UwJHD8mkvQ5QTLYxgTHn9Mb9+0tS+Rrn3bUEL/wSW77js2/L+5/PQWBhFYdBPVEn 6WJIy1TzvQAOYxUPbXxGAUXszgCVAk0jLz74el9m3TpB9UrspIYtHhDwUyFvL6m4Z0MR I8gg== X-Forwarded-Encrypted: i=1; AHgh+RoV2n0NBHs2mpyEuWMMFn62F5FWNSbDFZ2IwjMUZ5HJTkfbdhJx9TrfF0y0bqVH316TrU6OXX7KpCcCpak=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4GkY0/A6Ndv2oDFKQh0X/RJ3nnZAD3S2s49FToBwup/XQNGyM 8L4YdV4qmcblo8vGa7VDyvEthf/4PBqlYSGaEjPaIr5Ct4j0WLIOi/oq X-Gm-Gg: AfdE7ckwTbZme/8GIhJyusYDG7WLabgo34HZfWPVpXBeyPrBpu7BtWhuUkkMxDiOfSB CFUcKXETl9eJw4fXUKb86+T/uaFiqSBTjBVo/ttpkprDrp+QXb0p/3HDoMCg5jzE9ThNjkyvRxK jGdXcZNqXJWthPAjJW0lf5FMKrSXsHuD3RQ7Df6aGcK6QOLLai9tax8xs56O+F03eUvK9DyIIw2 hnaP+RSf02egSI+y3lfxuAeDD79U6lAMMwoEngU6bpuimUoNHsaYfAaN2dOznewpAoeVFr/LnPZ IwQ7vAL2LU28uEozGqh/XPR4ELplg3D4Bi3P3xsds6igdHPDxK/Fquk2TorNRZTLfFrF6ySIQ/d MSxry58GGioUsTA6nPU+LZfKwyc8i9atz1GrHik7DY5vSmLQnJrCxWuazIbMcZvBJA7Ol0VoAZo YT3ra2N63VIbmKOGbF5siqP6M= X-Received: by 2002:a05:6a21:4591:b0:3bf:6c08:2841 with SMTP id adf61e73a8af0-3c110775a5bmr2018390637.48.1783754982831; Sat, 11 Jul 2026 00:29:42 -0700 (PDT) Received: from reply3_full.eml ([49.216.173.166]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b658a99afsm45004071c88.0.2026.07.11.00.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 00:29:42 -0700 (PDT) Message-ID: <20260711152936.191.alvinhuang0603@gmail.com> Date: Sat, 11 Jul 2026 15:29:36 +0800 From: Hao-Qun Huang To: Dan Carpenter Cc: Greg Kroah-Hartman , Viresh Kumar , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: hid: fix SET_REPORT return value In-Reply-To: References: <20260704081613.434445-1-alvinhuang0603@gmail.com> <20260710020644.6728.alvinhuang0603@gmail.com> <20260710124050.31335.alvinhuang0603@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Dan, Thanks, that makes sense now. The point isn't just showing the code is buggy, it's explaining why changing a years-old return value is safe, and that belongs in the commit message rather than the thread. I'll write that reasoning in next time (what checks the return, what doesn't, and what could be affected) instead of leaving reviewers to ask. Appreciate you taking the time to walk me through it. Hao-Qun