From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34E0C2F7EE6 for ; Sat, 11 Jul 2026 23:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783811663; cv=none; b=d9vhfFYD8FKuyKXXtWl4gKQswJzCVzj3PwzwT0be9KoBtv+fsb0VjQzXYNagbOwxlZU1tu1kcgyN+3xh2GQFzs6B21K5iSj9vJ1JNT9nhsfvw+G7l1YEg7xyiorlHjdrxU+NqrgWybNSBc/8mdhjmQXpvil68/wH4SupgH5pzLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783811663; c=relaxed/simple; bh=EHGw54sKsJWQ1hQzRhATaYr2/DetzRiCOtT0KFSI9Ew=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hrp635Am7DoyICtLCJ25nKzYd4eBIdV4pme+theqfwo4c2XPa92PNzew/w0M9eX8yNb64lSr7te9hr2uy0WCQmpZSfJ2e9fdjRVqmTdOquPZje4C5j3/HWC245UMN+c1FObl/cifo2SWUisigW4SfofLIvrbFBVsEgOoL1S9fGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LTo46Dne; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MJPEufeY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LTo46Dne"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MJPEufeY" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66BKw8XM586342 for ; Sat, 11 Jul 2026 23:14:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tkOX7/TAel/cmrpxcy/qt8cPl9Sf+yVa1N0EotZKyl0=; b=LTo46Dnekt61/Y5a o3leuBGV7NmtsgXfibCf1/BflZE76bnzxYWpWAj2nCjKYJ+hQOABxTgfCHM7XkOj DQ/DajAm0MqOLe7gXKW7N+u6wNlL8nwT2oUdTTXpBdH6QZs6X1cnRNh0k+i7ZbQ7 sgLh/snGQgOJMh3MSDBJxcc7mSR0iFrwDoXsOt6kZddECL/LT8zDgKZHDJb+W4Su 9dVDKwLiLirvrFgaY8RL/xPHfYwGlH6OsCdXZSL7+/SubbPUHgXIexJgs8A0/QCH +07g81stQI8b2GmBHtIVWtPk7Oj0Qz9cSUUCAeM+B3AhwzokIrcdG8e08juvPNOQ ysahlQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbekchr71-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 11 Jul 2026 23:14:21 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cc640dfde3so27402635ad.1 for ; Sat, 11 Jul 2026 16:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783811661; x=1784416461; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=tkOX7/TAel/cmrpxcy/qt8cPl9Sf+yVa1N0EotZKyl0=; b=MJPEufeYRht/D0dn2yO9X9dn8kDuhtkIfRaAGt73sG/q3Oml8/0j7dB3iul2eoC5th OUAy/cUAb6Fnp8R5O9j4ZzJ671j5VTWIiihuDsFlxzT9k924acG49WCa1N7NXhRBbdTk FBrHLv2OEz8Afqtz39ifmMNAAQEmayaSWq/TmJPIEEkit2PlbaYSl2e6RB4HMtzvlGqV 9BW6njNeH4JECCheIzcziuFrxcs9Ny5ttUyDfYvNf30FrchYywkc5sB+geiBVnF7RMCc R8GNf0TBwWkKDgn8ThnBYiO4MPHjRmAmFS2gakwMHyUIz/SoxW6xTvmB+lSoVqpkCMny dlXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783811661; x=1784416461; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tkOX7/TAel/cmrpxcy/qt8cPl9Sf+yVa1N0EotZKyl0=; b=PMFXFvMdScv4TDuKZdXO/EcqeTFOgpSgZsfJMsGOReRdcK+u1r31twKfYPzyM6QebS ufr3/s/uMshNh9HzUOCrMDxiGr2MJnUTiKpj/CX/mNZpqKfGhdjYn/6lHelJEMl8kW95 2Q0ltGWdATHhnGS11pdV+6XzkIizcKClVY+6VteAdHCcVSdi27S5+xHYPsyh/U1AnzeL HiGhWnvoPxR5uZVr7oCI99qeYFxn03qw4DtH4/Wuw7qhmniRvTkBDauVPvQCPaAX+D3z gqbK+IX91IXAn+kMUcuuO3MNpAIN33YHye0Mv2pT8YlnMgtTDB3e8kpaQuaX8O63GKpb 0JBg== X-Forwarded-Encrypted: i=1; AHgh+Rrzp+KXDO+vLSmqoc2asIOGqrnTVuT1dAPNKfCxPiQtgB+Pl2uzGGK9AflKWJcGdpudaBEOTubf0rR1TWM=@vger.kernel.org X-Gm-Message-State: AOJu0YxCv8ISnlsDwLzI0KVh+Q3LLbG2AXNVh7s1LE12ryGsYAu2jWcO QhNztW3cY8sJ+XB0P+w+9EI0TUDn6Qx07HWQBiIn7Kf3X/nTWlRelJ+VINOdH18Hulv7TZaKaec omz6a7D5WazKDj5CRgnThG8RIDgyhGIfODyhqHjuotGrJXOouIGLZDYLSbbwg6SsBFQ4= X-Gm-Gg: AfdE7cmk9536B+p3ld0EG4wY0n7OHwYO1plM42KYj7WeSDZoW3OzjZiQalNkhweDqSk O4DtUaRccWsUyYs8rt275N9220mBxmll4XOQyPi/g9z4Z6GbLgzjNsisKnJCdWn4h8+YLLJuErt XbCmJYlzndZaKb/FkxfutyNg5FJFQMnVS3mkcr1GY6eWtJ5FfXPamSQNWvaxR+9png7oTDiCjNc 9vW9SJS9S4qra4cove5PTsA0uaQBF1NCVaapzyNhHgDvKEImSEn3cCisO1OJcq0llG3T4E7CAsS PV17h6f+RRmjdrvP6USnpsxx8qa+ZokzDf8r9RCK5hRery/vbOJKD3QwgRCvzsDj6zKPEZLbJtq A34WtbsPFkPqGNqugaxOwEQc8/u8= X-Received: by 2002:a17:902:fc85:b0:2cc:8267:31b5 with SMTP id d9443c01a7336-2ce9ec12126mr39887275ad.19.1783811660699; Sat, 11 Jul 2026 16:14:20 -0700 (PDT) X-Received: by 2002:a17:902:fc85:b0:2cc:8267:31b5 with SMTP id d9443c01a7336-2ce9ec12126mr39887095ad.19.1783811660224; Sat, 11 Jul 2026 16:14:20 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb86bsm78488355ad.11.2026.07.11.16.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 16:14:19 -0700 (PDT) Date: Sun, 12 Jul 2026 00:14:14 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: David Lechner , Paul Geurts , nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, tobias.sperling@softing.com Subject: Re: [PATCH v4] iio: ti-ads7138: Disable STATS_EN bit while reading conversion results Message-ID: <20260712001414.70a87eec@jic23-huawei> In-Reply-To: References: <20260706074803.13624-1-paul.geurts@prodrive-technologies.com> <867d2cb8-a1f3-49e9-a8a2-04e232f404ab@baylibre.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzExMDIzNyBTYWx0ZWRfXziYDWv1kbZEi YJGgPbt0MIKncrKaKQbP2niZLzyhCmKhR/etS2JlOLokaoGlNPv7gjvOvuB/oA4+ujgCj91nlFS EWYhJpPr9TNU77EHbmfgSpOpV05hzyUYj8iZQ/thp75q/2eo/vfu0WHGFQUoGXY4mkTjqD+hu/Y q/ReF/jeFWLOkWN/cYtHkCgXA89HmIBafDU04/8Cc34mAJurGtZxG2qTNc4YbMcUdux7QX6hROx x97Yi3MLWIwj2V+22Qy3XmUz78mO44wXQM8NxV9RJ+ifFE6tjNUMsYIyQOrbC92yPUJ0amLSlGS rkg2YbCSHp6nxqnYvSijblECmicyWrlfW1Oo5wSbPjvdVkz5N56D6KkrzbMhCDrjL2K+gsUeNSk AvSJYee5dT9t+GbHeBou0IXOH46RNRxES+PW4yt4Nk9BzJXBBpBC+5GQy6JtDjKL8tOiF/fBx+b 2DJMe3ogTquKYSZbkxg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzExMDIzNyBTYWx0ZWRfXxdFMiMEnt3BI nQGeGPSOhK6WXcp36qRR2DdsazYYReo3HrzYsZnRY+GUr9u1evjYdrdoUjpPIjU1udk4ngQGJw3 vpe5Q5LY1F2ZaOyp25CGcpeWN++T5zo= X-Proofpoint-GUID: BCY9lpJIppXYuRGb2YF0fGg-d5p-VH8_ X-Authority-Analysis: v=2.4 cv=XNsAjwhE c=1 sm=1 tr=0 ts=6a52ce4d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=QyXUC8HyAAAA:8 a=GSyO0BWpQcPk6rojcgkA:9 a=CjuIK1q_8ugA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: BCY9lpJIppXYuRGb2YF0fGg-d5p-VH8_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-11_06,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607110237 On Mon, 6 Jul 2026 22:58:37 +0300 Andy Shevchenko wrote: > On Mon, Jul 06, 2026 at 11:30:59AM -0500, David Lechner wrote: > > On 7/6/26 2:48 AM, Paul Geurts wrote: > > ... > > > IIO style is to have /* on separate line for multi-line comments. > > > > > + /* Reading the statistics registers reinitializes them. This is unfortunate > > > + * but necessary to prevent data races > > > + */ > > Also multiline comments should follow English grammar and punctuation, in > particular the sentences should have a period at the end. > Tweaked all the stuff mentioned and a few other bits in commit message. Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan