From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54AC53A785A for ; Sun, 12 Jul 2026 11:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783857465; cv=none; b=hrOdBynU1NcgxZDRx9zaOa+fGE6R8HlDLtD20yKgUhAncr4y0o86QEysjP39jZEjPBgQUtHHK4i6NmcGuvCMqheaEElY43mWMkM5L7zPo9fZ+OFkAZbQW+N5JRshKTmS8uqAQl4A7fNPKX7SytpPVnZeiAs1UU/IJDzs1vay4tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783857465; c=relaxed/simple; bh=2Fbe+51I+NHaqoJEm/Ia1P/RkOrsQ8sOHQ84+D4jX5M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RB6Kk/Dp8p1UNEL5VrWecLzCK8c4k6ylq1xCDkMLFoLM5R6MEYmEBv7VoOzFdz7vwP5E/qH7sQBrgI8ikhDWOKzSQKZxPxRBhisaXFJh7BMcXrl2wJWPYKxoQuDLNibH1bsxzs1NW4KDaSYNHw9cUED5TqqqscIUJzS/h9i+4N0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lx8dK1Dx; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lx8dK1Dx" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-388b404ea89so1890551a91.0 for ; Sun, 12 Jul 2026 04:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783857463; x=1784462263; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mrmu7Ax8Tjv7DXY7cz3wQn6QU0gYid8cSWvbdHALi/M=; b=lx8dK1Dx6EOJ93SWfzMu2Yrh46dyN5y1NDOQqa7T70moW1cMZoqgiB8eIb2VqkyqO2 h3A7k6v0EJen2+rdr6lhowYylZx3a0Qwlcbjs2Jy5CZq8GOr6QtXT21kll3sUEvFVu6c RT0E8B3LHiFGdRy6J9sDrhomMfUXyJ8WaTQ9TA2URfyEZU4SNTn1KxA845JiUMhs2DbV tjKRZjHBW+ySvYNWMApWuYuO3daI5zGT73mJwsX4P3WrU152wPxjJUsLQBNHxGaD+foc Id14flc0NzohhuT9y5DJH5PMywfZEri0F4SE5UpfpthpBvrQXvODM6iUBobRmenJ7E6h Wixw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783857463; x=1784462263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mrmu7Ax8Tjv7DXY7cz3wQn6QU0gYid8cSWvbdHALi/M=; b=kcPWnIBXJJrIvdbZ9Moo9DmrBejdQYtjdmSW5GfCUSzDlYLMyU0hXGkPpOlqnaLNaa vJBPOe0d+TkMy/U2+Dsvx7zB+j4fixELRGg9ZKlccX1lzumaJNeCoe2s+xBu0J1IPW8J I3AAsi4P5y2GbVR0keiyWKvpBQtol8uIY3MIDNjN0nYYUv2flNqMXmuVOgwchPyiQ4z7 u6zUVF8+O54PgI/4UI2upzQoJ7DB0r5HpHW5ekSeAuk6eYpYqfnp01T9XB1Ks6hndEFe AYY8q7jMiVmaDbtCHoUUhw/M3Pzwn/xn513Fk0qrSVYVVNCroVv8JDIm3SJQnHmIZ5M+ p8lQ== X-Forwarded-Encrypted: i=1; AHgh+Rq7/t8C1eqooNisqzqS1pj5gUKlWCwv5P8urc+Uwtdz7F+qDjUQt4ulzIDUVK3x9o7qiFKeyEEr7mJfb2o=@vger.kernel.org X-Gm-Message-State: AOJu0YzSeCq5u4ane5I2oUPijEZPMx0yDhZzqp0F7eTAV6HlIy7zfsCY UISk4ZPCP0iD+SqJT0Mz53ReVoNVccxhvRtKqWQfvpDv1tbVmRcPxU8m X-Gm-Gg: AfdE7cn6iJ4USLt4N5mfeO96xENtg7tfAvb2bz61/5xxKlmNMWiEwLqI4izBtLPTXxW OhDW8LmAWvypQPtM9yvNPCOgUMRxgql9OVmPNsdykAmxnx9TeZURaja6B3z3048SrCETnGZCPU0 WSnEpqAod37XYGUxxMhJfzDaq41e0U3q+GpP3cF7wLTd3TLMCe9iR432d7jOPO7d9G9BN13LjJ6 JAVmduxciL2QpuB2pjSuIY3HTCLJ8M0vQqNPuGkRHLZ4fjma8hnC/KBAxyiCE7jT196CA7iHZ+h RwY0ZkqquvmCDrrE8Z2jSwA4upNX+KyCo2to9eWShiON77TW1OEbrmQKLVIwd7y9PYOWqM8C+gC vVEkfEPKOiq/+Pkn3/q9+1laJTAmkv86TKJlNoGeyoYVkudiG7qlfz0pcyOzu0ZPlZ2qrcsMT6o o4g8BaNHLLQqUxaSemmp0XGWWfvKLQTRHJOEvb0zzOKOEwbuOKW5VDHj2/YqByTGnv X-Received: by 2002:a17:90b:4f81:b0:38d:e397:9053 with SMTP id 98e67ed59e1d1-38de39790c8mr1551196a91.19.1783857457791; Sun, 12 Jul 2026 04:57:37 -0700 (PDT) Received: from nuvole ([2408:8456:3a01:5d1c:f8f6:b057:1d4c:1d59]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a57dc5820sm4833781a91.10.2026.07.12.04.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 04:57:37 -0700 (PDT) From: Pengyu Luo To: mitltlatltl@gmail.com, Frank.Li@nxp.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, hverkuil@kernel.org, imx@lists.linux.dev, kernel@pengutronix.de, krzk+dt@kernel.org, martink@posteo.de, mchehab@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, sakari.ailus@linux.intel.com, sebastian.krzyszkowiak@puri.sm Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v5 1/5] media: hi846: Fix hi846_write_reg_16 handling Date: Sun, 12 Jul 2026 19:55:53 +0800 Message-ID: <20260712115553.92564-1-mitltlatltl@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260712115012.91600-1-mitltlatltl@gmail.com> References: <20260712115012.91600-1-mitltlatltl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hi846_write_reg_16() does not clear a positive *err value on success. pm_runtime_get_if_in_use() returns a positive value when the device is already in use. When hi846_set_ctrl() passes &ret holding this positive value) to hi846_write_reg_16(), the function returns with ret as is, the positive value propagates back as a return code, which callers interpret as an error. Fix this by resetting *err to 0 only when it is positive. Fixes: 04fc06f6dc15 ("media: hi846: fix usage of pm_runtime_get_if_in_use()") Signed-off-by: Pengyu Luo --- drivers/media/i2c/hi846.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c index a3f77b8434ca..7f069aca0fce 100644 --- a/drivers/media/i2c/hi846.c +++ b/drivers/media/i2c/hi846.c @@ -1271,6 +1271,8 @@ static void hi846_write_reg_16(struct hi846 *hi846, u16 reg, u16 val, int *err) if (*err < 0) return; + *err = 0; + put_unaligned_be16(reg, buf); put_unaligned_be16(val, buf + 2); ret = i2c_master_send(client, buf, sizeof(buf)); -- 2.54.0