From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 670513ACA6A for ; Sun, 12 Jul 2026 13:55:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783864505; cv=none; b=CVqnHPpAbloPJxaPIfRB353W+4KCGAI5a8IYKZ8nW05lTU0X39VS3iWxfbVV/4EWn3T66CpWkEWst6mOnFnIwWPafbaySCQEkGQnPmVNtholRqV76XpKpPXftC/kTCAxZLJfhwVpDj7Ur40oqAkwn8IAbiZQCf2Y7jo6n+6gcY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783864505; c=relaxed/simple; bh=BHBRdDyZsgGf3EjWM4xIGTLZE0SyBofZQ7alSwO1G9Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LJsoVA7m68t4re2QAAa5f7Kpv+y7KjUZUk7zKHnlOGGIRMJ7Y0YwPxeCfRQNFOnMmsM/QBO1WVq29fYEH5mNC3VLyRfETY5TqIOukYnzJ5WVAm60YLDNUYgOmsuhEYbdWV+387guYzcyJVgDVPsC3/v2UxYynedX516HjaviYio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=Th/BurNM; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="Th/BurNM" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B8071688; Sun, 12 Jul 2026 06:54:58 -0700 (PDT) Received: from e120398-lin.trondheim.arm.com (e120398-lin.trondheim.arm.com [10.42.46.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E9E83F7D8; Sun, 12 Jul 2026 06:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1783864502; bh=BHBRdDyZsgGf3EjWM4xIGTLZE0SyBofZQ7alSwO1G9Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Th/BurNMFudU+nbSDtGLhH4Ontmh6OVDUBBUVQ9CS5YjRLNNvG9Jp7iMP+yypDGOF RYuhIVQXU8dL+QkWGYUHuO1IuUSUenoittb2XT5Sj8MWPEruuyB5izrI0K5gTYKqnK 9cu8lqVfdAHipl1KAsulcg6i9v8BrrGtRf0UAGCk= From: Ketil Johnsen To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ketil Johnsen Subject: [PATCH v2 5/7] drm/panthor: Don't allocate protm_suspend_buf Date: Sun, 12 Jul 2026 15:54:37 +0200 Message-ID: <20260712135439.1546950-6-ketil.johnsen@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260712135439.1546950-1-ketil.johnsen@arm.com> References: <20260712135439.1546950-1-ketil.johnsen@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The PROTM suspend buffer is only needed if the group is going to use PROTM in the first place, so let's not assume we need one until we're being asked to. Signed-off-by: Ketil Johnsen --- drivers/gpu/drm/panthor/panthor_sched.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c index dc77a174a3368..86c0f12b09e11 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -3642,9 +3642,11 @@ static void add_group_kbo_sizes(struct panthor_device *ptdev, if (drm_WARN_ON(&ptdev->base, ptdev != group->ptdev)) return; - group->fdinfo.kbo_sizes += group->suspend_buf->obj->size; - group->fdinfo.kbo_sizes += group->protm_suspend_buf->obj->size; group->fdinfo.kbo_sizes += group->syncobjs->obj->size; + group->fdinfo.kbo_sizes += group->suspend_buf->obj->size; + + if (group->protm_suspend_buf) + group->fdinfo.kbo_sizes += group->protm_suspend_buf->obj->size; for (i = 0; i < group->queue_count; i++) { queue = group->queues[i]; @@ -3724,14 +3726,6 @@ int panthor_group_create(struct drm_file *file, goto err_put_group; } - suspend_size = csg_iface->control->protm_suspend_size; - group->protm_suspend_buf = panthor_fw_alloc_suspend_buf_mem(ptdev, suspend_size); - if (IS_ERR(group->protm_suspend_buf)) { - ret = PTR_ERR(group->protm_suspend_buf); - group->protm_suspend_buf = NULL; - goto err_put_group; - } - group->syncobjs = panthor_kernel_bo_create(ptdev, group->vm, group_args->queues.count * sizeof(struct panthor_syncobj_64b), -- 2.43.0