From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A373B3BFA for ; Sun, 12 Jul 2026 20:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887906; cv=none; b=BsPk26ePIRqK+60aLd4r9fbSivWw6DuLjsOvsXJQj8ZazwDiBfyRwvRUjWzQ0/GvJZ0MGjBfkNXhxcGV/0S8fP0zR3u6+k6YKXz7XJdcvCcEwsfJawY8MpUQI4NeDzjqx7zDWDrP1Q1cH/j6Gqd3ApJ31Iq996n9LMEYpw17fPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887906; c=relaxed/simple; bh=9Uv79NmVh9eY/kXN536i2ek90M/WLPrQWFXW/X5gzzA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WlTD8Pp8sx7LxvEdzey1I+QgfBb1Q9ZKse3PDuQXkThjX/V1aWlJzJJRMcUlDD99EpXUnGN9vH1n3lhDHp0txw3s2tghqwGUNgmqyZeRg91B52soJTsLxymawfdR6qTT3FXyXpb+k+wp2q+mZ+HwZp1WKjIsaYiIkcAKXFf+aUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m2tCmRvG; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m2tCmRvG" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3825c406ffeso2346524a91.0 for ; Sun, 12 Jul 2026 13:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783887904; x=1784492704; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=t1Yo/I8ZgIt91EkcMTcsXR68fdAvToPUpH4oydF0Wx8=; b=m2tCmRvGNv/Vf1Ib3GElLmwymIZdr3ZbWWkPpT//p6H/jfHtRykzqq241ZKIWURP5m aqQEVe8nHVz0/GxwTYE9hMemgtvbzo4/YUCRNne9QG3kPihSu1WrZZJSC0rtfCarhliD +/b+hwu0Y5+DMG8bgWs/54obXYNQahmVD+/C9zJafH5Xw43ZM4Vit1784gdgtJjemdY3 jCM0jKwiODZr2W8jRWRegcjntnOSXVMa0FCiV4gDn+0f4/SCavqkOs03rgnHb0M1Jzod GKGZJb6/M9mC51BlqwRsJLzO+7FpTRq23D7jJhvmptmwxSFwlYEfIV6OQGzaA0Xcy+Sb mqAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783887904; x=1784492704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=t1Yo/I8ZgIt91EkcMTcsXR68fdAvToPUpH4oydF0Wx8=; b=ZOJl8gKybHYxQuCiIr0dY3aXN0QkTJEkeIn14TNaofpx4XWIhzGV/+wT/x55QGKjau pSruLta1EX37fKf1mwo6neY9AAkRFyMpLlWHKXVddoMYrcGkSuiDEPKCtnWSOnQjlcXw wb6xRl1wGaGv07mcvNAyNBCaX4TfGlaLvn2I5ZlQc0BBLHuHIF4PUI2cEDyzTgFkc8pw 3vl+QXXjXA+7F+fQhfffi/McalVA2ga/DwE3xvKXCPCIhvatBwFQwfXeOIt50bWEDC2u oOyxb0meZXuuWncd5IQmTSX0n2gmx9MNd9+GssePznTY4CTjgmfvjRrNCpiRBTsV0ASR 8jTw== X-Forwarded-Encrypted: i=1; AHgh+Rp7RhYOwHzWj31ISu8lBekv7KlAoD1K+mtsrG+XABU7o7fW5JXzbG81VewOnuJdAOLTv/1qLbn4jB1qqMo=@vger.kernel.org X-Gm-Message-State: AOJu0YyH0S2ZyO+6D9Ji9i5WZrfeSxiF0MXsfKx4Umln1PHQ2oZgQfca ztkd7/7b8qm0bDI+nm5YsI42M2RHBiUQVav6Y0nEqYHHj41f22uHLBTvNkPhx4w= X-Gm-Gg: AfdE7ck0X2Id7sdZ9S2zK3z/5IfTK7Ni0EiBlDERocz0piceRrHYgxYYGsmlS3H6iid E9DZ9u96+BnPSESnjNUcwsV5TVwRhVGCEwyAhk9MsC2MUU1ahWi4+wXAQy6KeBMvugYoyRZ4Xk5 NJ4/7tBMrb2OPyjxIcA7CnAOLt+KF1hAkxjHtCcyI8o9dNpGq1bWqIA0Ft/ylWg/NC1S3Mgb4Qp HleknWK5BQ5Tv/BcIMYB2rSdPYo+/5jBedXThXaJqojPETzxeZCQMHEa3ZSRXQ6ftCoLrSFeMuI V0miYxYsdYUR6sywSJPvP19gjp2UCvrAbgJZoo8D0y9GtNfdJh62xyUEC3gUvsrWsy/ta3VH81q 7VA9n5LcjbzFSe9VXFGBlnJiIF0V00wZXPduPBc5ZJgGE/TH6K3Ua8x9viBgryhjhCr8Di7yE8d TbxzXk9KaHn8U9X5PLZqYcnlmbro80+U5Y72qQShV54+znrF9Xkjpy X-Received: by 2002:a17:90b:5687:b0:36a:8240:2477 with SMTP id 98e67ed59e1d1-38dc7608a0fmr6218318a91.19.1783887904009; Sun, 12 Jul 2026 13:25:04 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.154]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f5975sm58833648eec.4.2026.07.12.13.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 13:25:03 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 1/4] iio: light: opt4001: Fix read-modify-write of wrong register in power down Date: Mon, 13 Jul 2026 01:54:48 +0530 Message-Id: <20260712202451.20822-2-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260712202451.20822-1-nikhilgtr@gmail.com> References: <20260712202451.20822-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit opt4001_power_down() intends to clear the operating mode bits in the CTRL register but reads OPT4001_DEVICE_ID instead of OPT4001_CTRL. The device ID value with the mode bits masked out is then written to CTRL, corrupting the conversion time and fault count configuration. Read the CTRL register instead so only the operating mode bits are cleared and the rest of the configuration is preserved. Signed-off-by: Nikhil Gautam --- drivers/iio/light/opt4001.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index ba4eb82d9bc2..f2cf496cc243 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -228,7 +228,7 @@ static int opt4001_power_down(struct opt4001_chip *chip) int ret; unsigned int reg; - ret = regmap_read(chip->regmap, OPT4001_DEVICE_ID, ®); + ret = regmap_read(chip->regmap, OPT4001_CTRL, ®); if (ret) { dev_err(dev, "Failed to read configuration\n"); return ret; -- 2.39.5