From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F8EC3B42C2 for ; Sun, 12 Jul 2026 20:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887917; cv=none; b=BLcXzVUv/EVWvrMHVWa05SuU7DOMH7N9Xh79JWg6+0Q1RDuGgHAMvn8HEOW27/D1qvPno21TDNAyrsA5T8V4Ipe5SbTR70ACZapFGK+ASKjGIq7EPRJxbonHgYlvnoTdguLw9Vm2BYBakeLrcwipwfNqJR+E5lvBPcrmrVmdj1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887917; c=relaxed/simple; bh=B9oykJbY1MY1CnaQH33h0JVuWS2mpWhoqz0M2Lji6Wo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=u48EMnjrBYF1dEIinUgDti6zIzyGwBrPHFN7X0U5/V+B91OqUJHLH+bnGqLCGOCg1d07wo4RShXij14Zx1t+tE5TfEexMMwEWncj5NNzuy2il6ECupVTnvRD89g43o4lZKkEUo1LSZnzZ2KrTHgUfpnNmb9/9RKQh6Fb4LKAjDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PG1HQp1K; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PG1HQp1K" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c9cf07d2df6so1618212a12.2 for ; Sun, 12 Jul 2026 13:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783887915; x=1784492715; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MhB40GX9r2MWq3eX2ITmrKlJx8RApsn1rpbCSOUkYAw=; b=PG1HQp1KL1Q1uUGdrfBrWZwa9F6ufBeIJNHOZ8LksIZ3jDK7OXn9PDtdXCuI+nq5FS 8NCyQZc4E+oClHh5mvwt9WkJC/iPRuCXuqLNcSpfW1N6S58W0BB6GdABZZdSq/JHGhkS poLhaqpNB8ctzz4Gs1a7K36HaGkZbEfUqtxyr+Wjt74n+gOqftaphkuFpqXqHo8eDEpB pFGuk9lkOmgS9aditzlviav3VCr59ybCB9vkhfGMUIOlYZGCv8DvMH7s8NPrGqTYwfW/ VOS75YCvAUg2e5PriLsaCfJlqsvPELI1ONhOLbX9FQqtN/vaF2Spbe9+//cE7lJxeTgT OKAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783887915; x=1784492715; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MhB40GX9r2MWq3eX2ITmrKlJx8RApsn1rpbCSOUkYAw=; b=f06+K8E0dwEPnWoLzOHiDULxUgiD59M5pbL7xonB58xQZmY2uuCHoysCq4VsSpImKb 7xejpcSUN6QbMUIDkOoC+DrssiMsDozQjZJ78qFTDKXW2Y+WAb7Dh4dm3zIyFZC8/GUx b2S3XELType4XasERJoErjb5EEXeN+sJBlBwUBx33CpMjFR5SMbPID8omUhm1C3PlMkC KQWcPATJgzt0RxYpk+YkcABIQDBhJnRofHuO29yi7txAA7NibPoz/RERYWPNmlFfpq27 oA3QEe50hYf/HvoHcHRBr3ti4CuaEDJ15FAu6KEB6fkxJdv1He49yvgvVDUGxpD7PXKT B0Yg== X-Forwarded-Encrypted: i=1; AHgh+RrzPdX39cpyXd7thEp/eYmquBadA16OcS3UuoAryIIIaqjzXtH3IyUzpYr14GFywuaPV3oV3Py4Nqw0ng0=@vger.kernel.org X-Gm-Message-State: AOJu0YxSTaUntH61iz34RsUopdli6LtY57XrTCOK1iF59BjYJiG0lUtD lLe/QtBNJo1/THmNgsu8Rzk+Ib02nlKyB9CIWxOmsCJkupPRlgkOHN1cRlJXZIk= X-Gm-Gg: AfdE7ckXwDWHBbApPRna16B/A5gX60gMf0lWzKihH7Z7CxwJAQ4RW4jamqS3+UwTmaq fGxYH1LRrMVyBPsPbP534F3ZtokyqZdUegnGMVAFehvPnahBU+AhgGbUwVovwIhN8+duETvzeOn 4rds59fqeL9VpI4n9GfbmfaJTYke5YEtrUMadHOOIyGz92EMHnR8pVq0nTkRUX32hYy67O3pM7b tTr+ffYTz47Bkh2knhQNkQFOeAdUGhbclvneKLLQ9St77hVwxJuNdXelGeBxsH/J+BGkeKMHbzG iyA+Z7C0cEwcuu2b6z0To23GltJPHPh/jigZRyJytaq7HKWeoQOiIUcdiKXgMc70A8XZyvTVv+p pzkWcepxWAg9kBIolGSDFyjYIhYoyhCwAQEm6xqKw4RT+CKP7pwqo2nGKi2ro0VJ7BPcE1hEI29 RbDlVGiZlWz9mL+pxgN94xlzHWRJpcrAta4UHM3G9nxbU+rWXmdT/d X-Received: by 2002:a05:6a20:c5a7:b0:3bc:5284:4859 with SMTP id adf61e73a8af0-3c1109e29d1mr6726693637.13.1783887915255; Sun, 12 Jul 2026 13:25:15 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.154]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f5975sm58833648eec.4.2026.07.12.13.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 13:25:14 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 4/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask Date: Mon, 13 Jul 2026 01:54:51 +0530 Message-Id: <20260712202451.20822-5-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260712202451.20822-1-nikhilgtr@gmail.com> References: <20260712202451.20822-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit GENMASK(h, l) requires h >= l, but OPT4001_CTRL_FAULT_COUNT is defined as GENMASK(0, 1). The define is currently unused so there is no functional impact, but fix it before anyone builds on it, and add the _MASK suffix for consistency with the neighbouring definitions. Signed-off-by: Nikhil Gautam --- drivers/iio/light/opt4001.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index 31a5397926eb..294532bcbc50 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -39,7 +39,7 @@ #define OPT4001_CTRL_OPER_MODE_MASK GENMASK(5, 4) #define OPT4001_CTRL_LATCH_MASK GENMASK(3, 3) #define OPT4001_CTRL_INT_POL_MASK GENMASK(2, 2) -#define OPT4001_CTRL_FAULT_COUNT GENMASK(0, 1) +#define OPT4001_CTRL_FAULT_COUNT_MASK GENMASK(1, 0) /* OPT4001 constants */ #define OPT4001_DEVICE_ID_VAL 0x121 -- 2.39.5