From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A138A379EE0 for ; Sun, 12 Jul 2026 21:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783892254; cv=none; b=KT786yuwWsasPROg5uI8IQholWB9Ep2helQ7F10hXx48Y4nvqDAljSKyuMEgT5qgYAJYa9+ibcUq35JZLYyw8U5q+dA0NflvAyAl+phqTctB/HZH6F68znHl95knXwNHzpyWHQcVRIxaqiUEa/a7C7G4Au/87N8etOkwFitP8o0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783892254; c=relaxed/simple; bh=keTxroWB1ulOIKLHrJ0vI3TRrY7IJd7VnUilIRrP4UY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xg8XqThXYKVtpLubvuSCpK3HoK3Ii2mhFom/S4P7Sd967pEgZZNKsBTHuSonrVmJfqbUH34shF6/E03C6NmTUWZelVSIJlwmnbAIBoCTph4I/cCWTyBZuUu8z36WaP/zfN/U4ao/SEcx2hJswElLzIeCe3evToKEEDfnPdQXdJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NUyVMzUj; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NUyVMzUj" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ce7d2adef4so33555435ad.3 for ; Sun, 12 Jul 2026 14:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783892253; x=1784497053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8ArRvRxqeT0i+T/S/4UgCHgV2A40U9Nyq7CnLb6H9r8=; b=NUyVMzUjmlpC3GtW3iMynLoVFKKLsouQfRuwnPMUWosYnS3oU6fsO4prldBnYxa/7b D/g5/ZPWS9rWi7cF1misqf+k7EzERATjqhKODKekecrBoUjlBLfIfbflyyBo6K+HmJ2d WZGWeIfvt7PCPt6O5Rtb4EQzth6iVgdrvimwZvzcGZYIdsR29mj1+2vaEzlmZ0wUYeyz D54sCIPEgoYGL6OT6RTpgzmhR6Cb0NbRZHbt9xcYB4SzpQx3owTexdB1e5pKa1Zqd1qP FblyiiKorPGIPIXfdY9hcEbVJ+a2gUDktnUKYDA8cplqm4TQYa0Hj5gOrlajFwGTkqKx ed4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783892253; x=1784497053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8ArRvRxqeT0i+T/S/4UgCHgV2A40U9Nyq7CnLb6H9r8=; b=UVhrsw190cyQ1ywJQPtC6rBZNs4hxybVtyz4BkAkqUqR0rhR/9LtQEt5aP8XfaLNqx RbIGkA4gvJVBIzMvQBDRRyj++NHASqY2xMcaBMt+kKI8t3DufZi65FGK2DMysYhu+30I c0WcSUjBH+JMbaKlxJNFtTjllO1jxfqYNtXcOpUiCfp3Vl3md9IL/Lwj5bNvUUlWy5X8 fjFWEEUt+0D3w6tXUwjV/AdA01xZwYsi5ljjp1mjo/fOMChoD9fcXl6GzVAhy8S9ddv0 DnUJeGeFxmomWC4eUS4J0VQjc2Oqgu7cZFbk34a0ZuyTGVO58dMCPjUcTb8IRG5TWuHN ngNw== X-Forwarded-Encrypted: i=1; AHgh+RqSy6kTAX7kbzWYeOCvmgWMU4HgWuNw7AENmf9GzwpkUgRn/obuVtv2PzhbXwvGZB4eAopKR94gMQ0fZj0=@vger.kernel.org X-Gm-Message-State: AOJu0YyKCVB8XTdknpJG26smaEK7lH+0ZdVPs5CRYTCb7qgtUtaaT+vb p6uIzi+3KOnHz/qO95HaVSuY2MI9//Bu6FvIlrL/UA/mqvAAyB7VKLmE X-Gm-Gg: AfdE7clYhZ6Nbmapn4tHZvJTOTiVM68rvXbZFI5IBMNQ3N76AG4919Iy/+sDjwOMUi1 8m7fDiExCkP4b5cvv6Ox3Bk40ACg3iwM2xq0C8mNOocykipnk/us9OMNJSExaSph8XEYIKu4IOg AueDCz0yfVzaf9xVpPZcPvIbX9eMCrfJRMyVtEXKp3oVzWOEAfybr2UjJpJ51Kb40+LqhhhPR9a tGUkCGxHFQPgSpMjuKup7py0r1eGIx7Yk6DtcBglGmE4UHVPDQf9kOIZ/9cPaOM9ohk/sLY5Md8 iwUoAqQvD7qBV3wbHliEub1Z7qKoy09BAQkV5sZuGZ5d8vyPeKTErERk09hKx/zK3/Q/Metd6Yt wdBuuPJBhAsXD7qlJ4yNAlZGSUx81hJZFsRk36JbMbYExJfttHj30WIXLprY4DwBNXHDoSdx5Fl PcLsptqoeKJq+knRUCPdgPAgdWXqlLVxWjQtr+EOSTJFd9uIsnoKQmx1Z3a2IqYL+3zD24zPkgS vDcAS5nONje4phTpr5QEB0f3AIail3+nzFwgdV5AE3JdgIGCFZwFW2TLt78xjaxEQ== X-Received: by 2002:a17:902:ecc2:b0:2ca:a03a:29b2 with SMTP id d9443c01a7336-2ce9e59e1e2mr67782255ad.8.1783892253062; Sun, 12 Jul 2026 14:37:33 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bfb7aesm89082605ad.29.2026.07.12.14.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 14:37:32 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Jeff Garzik , Mark Miesfeld , Rupjyoti Sarmah , Prodyut Hazarika , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv4 2/4] ata: sata_dwc_460ex: enable SATA interrupts only after IRQ handler is registered Date: Sun, 12 Jul 2026 14:37:26 -0700 Message-ID: <20260712213728.824420-3-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260712213728.824420-1-rosenp@gmail.com> References: <20260712213728.824420-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sata_dwc_enable_interrupts() is called before platform_get_irq() and ata_host_activate(), leaving the SATA controller's interrupt mask enabled without a registered handler. If a later step fails (irq request, phy init, etc.) or if the controller asserts an interrupt during probe, the irq line may fire with no handler, causing a spurious interrupt storm. Move sata_dwc_enable_interrupts() after ata_host_activate() so that interrupts are only unmasked once the handler is registered and the core is fully initialized. Fixes: 62936009f35a ("[libata] Add 460EX on-chip SATA driver, sata_dwc_460ex") Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 092272753749..85c5e67e9175 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -1164,9 +1164,6 @@ static int sata_dwc_probe(struct platform_device *ofdev) /* Save dev for later use in dev_xxx() routines */ hsdev->dev = dev; - /* Enable SATA Interrupts */ - sata_dwc_enable_interrupts(hsdev); - /* Get SATA interrupt number */ irq = platform_get_irq(ofdev, 0); if (irq < 0) @@ -1197,6 +1194,8 @@ static int sata_dwc_probe(struct platform_device *ofdev) if (err) dev_err(dev, "failed to activate host"); + /* Enable SATA Interrupts */ + sata_dwc_enable_interrupts(hsdev); return 0; error_out: -- 2.55.0