From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f99.google.com (mail-qv1-f99.google.com [209.85.219.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8952737A841 for ; Sun, 12 Jul 2026 21:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783893450; cv=none; b=UoXT7IMsFTLlyQJkTFsSXEo+Jv/ydQT65v4k2n60dt4NOFHAQ9sv4OfmNUpdElKxbXiF7jSx8KqRMrlbvofK6MrwQ09hDlAcO3eC4EBtA2hGb7sQQqraHH6kFTReZ0tV1Ir5bitmJRDbJZwhhcBDUgkHFprGuZ/rDgqg0kzxjf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783893450; c=relaxed/simple; bh=K4mSZwTp/u7hydGX0B9HMeu+jFvEsCWuLWVpwuqs11k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rn/5mOcLWjLs5EEW9fgxyJsfu1+suCU5cCfS1Wiyd5KuRYsYLxg7x8u6spPUyZFp21HmLy+PaeB5b2H/1JBOetnIoQgsi3obbJDOp1nB8iOSHHvJdYuITFtJ3PyBpUwKj8xXUBzQAvi0tiV+PcFSukmz0Tt/oBIkBA4YtMyfokk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=RZHLJiM+; arc=none smtp.client-ip=209.85.219.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="RZHLJiM+" Received: by mail-qv1-f99.google.com with SMTP id 6a1803df08f44-8f29ec73064so20147666d6.1 for ; Sun, 12 Jul 2026 14:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783893446; x=1784498246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zyr6YBFmBRz4cpGfkF4vKmM2rz6RRnkLotsCwCyQb3w=; b=L4TKXTCJzMqMZ+qwcU5TKESA63OzVlOgsbpqCp2m5KAdKa1f7zmCfCHABTz9kTB2Rz jABVZoem6BCxMuZy1TAsZSVDvUMumEaIeEh9EKfS5bsF24i2BC8KQDHJdBKBBGDiSPNR nYauBX+EPknFuD6VuAvVJXPVrJtgmHChCSyrDmUPew4EMM5Rgam+Uz96nB0pw0QiOiBy K3m2mJhqTSTOV5ffqF5v4bDjeI29TSqLGhrwPpqWdearlOBp4450H3GONdHeENhcDDTB U/+Mw5Qv4/0RwTdQyE1FHG9WLn5Va1a2jLg8+ZFEmF1x0FULsGoAX1/ngQhNrVPVV+2J pimg== X-Forwarded-Encrypted: i=1; AHgh+RrTAmS8HAWv++VdAmi86da4ffx3tSCuNyp/YVjJOi09UxcbuPHTUyjQQOlH72wyDriKEeBVOzE7zAzSid4=@vger.kernel.org X-Gm-Message-State: AOJu0YwzsLrD+guaMdhNkfXCB2jjtz4uATHjz86zlwANCxkaC0HyjI1K KeWPySXr20jG376kudhJK+MAWX3TXhllZut00pcO7wtcl0ESR6YWqW7lKTU4FuwqU51f20/rHjt mMJLxMN7xZa28Fs5hQZVDmWYCm8tzjLk6qfgbBBQgPHmgnE2Z9KKGoQclJH2jh8jlIN1nZgNCVq W/PZ2LPsyV8fGKtlapYssFapPaQjDU4OeeGYu3EUch+ZmkcDlwsoaRRrrEl8m3lYNguPjVAId5G 1U+I2ZIshjwcW9B3Bn75XfLCg== X-Gm-Gg: AfdE7ckMvqs0N4hK3Tm5/hsYqjudRDe4kPkkjszLdZtKXcBqpYyiJi/6+DP4kKmMedI SU12bb+OipBJ/vO2wyhZ09ZPhCvyQ6aWT0VAoM7r2MIHemQtp0fDI6kY5C0cFl/EP8Hw5zzDEwp NDGNXbEajXaRw5gK5C4DEapI+3tEWXr+Gqt/5/xnHkgKNlzkRhzBlcpcTmLWUWndQOYBfkp/jfu MstL2nM4JpmpWEGSc9c43j28Mo0heen754OoTc52RqQCHO+gsqd9Bh6GIM/PsZl0VQYXvFp+4ui BsdHumRNFn3Y/c35DfSvuDwMhR+gfhl6+/JaPpGovPrrn3Uo9bMY0po+Gje6H7+c1L6bbbUaR6B KwpHdOuoRl7/1yTzKpK7hjUGmhbpy/VyAy/77gkhNQsBzOwOxn7Mj964nYK69anV0HbgYcgTo0H KVi1fnk10EGJxV2dn+6FXNb2IDulu8yJLTrJOjcAEn1Q9UFS4= X-Received: by 2002:a05:6214:4d06:b0:8f1:adbc:5201 with SMTP id 6a1803df08f44-90403261101mr70362716d6.43.1783893446239; Sun, 12 Jul 2026 14:57:26 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-6.dlp.protect.broadcom.com. [144.49.247.6]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-90487d048f4sm1902756d6.0.2026.07.12.14.57.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Jul 2026 14:57:26 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-37d4f23eb37so4185082a91.0 for ; Sun, 12 Jul 2026 14:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1783893444; x=1784498244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zyr6YBFmBRz4cpGfkF4vKmM2rz6RRnkLotsCwCyQb3w=; b=RZHLJiM+z1ARcnvgMk2ZB+irb4SSQLgf/7cyDkG+r3gBG4FP3hMgEeFlKvYlrwb4Cr zdT1HNVLczw8yg2YU5/rTvpWFxf5P1IPslYZCZpdN2agIjBGh19awqHVI0Y7+kZM8Fg1 Y83Cqb1X5doxo3kv2JR8r6umCaYIU3mU8FNMY= X-Forwarded-Encrypted: i=1; AHgh+Rqh9Cuq1e8qN3pD7mEDbYB8RG1T/fpokYYg5wb66CwuP8BqQ+iMMhezdCpstemewV7u/puk8/cBZsE59Tk=@vger.kernel.org X-Received: by 2002:a17:90b:58ce:b0:37f:9ce3:ca96 with SMTP id 98e67ed59e1d1-38dc777c50emr6691022a91.31.1783893443837; Sun, 12 Jul 2026 14:57:23 -0700 (PDT) X-Received: by 2002:a17:90b:58ce:b0:37f:9ce3:ca96 with SMTP id 98e67ed59e1d1-38dc777c50emr6691003a91.31.1783893443371; Sun, 12 Jul 2026 14:57:23 -0700 (PDT) Received: from bld-bun-02.bun.broadcom.net ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b4b97661sm29930583eec.7.2026.07.12.14.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 14:57:22 -0700 (PDT) From: Arend van Spriel To: Fan Wu Cc: "David S . Miller" , Arend van Spriel , Chi-Hsien Lin , Chung-Hsien Hsu , Franky Lin , Hante Meuleman , Jakub Kicinski , Kalle Valo , SHA-cyfmac-dev-list@infineon.com, Wright Feng , brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] wifi: brcmfmac: drain bus_reset work on device removal Date: Sun, 12 Jul 2026 23:57:16 +0200 Message-ID: <20260712215716.2170806-1-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260709101635.103005-1-fanwu01@zju.edu.cn> References: <20260709101635.103005-1-fanwu01@zju.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On Thu, 9 Jul 2026 10:16:35 +0000, Fan Wu wrote: > brcmf_fw_crashed() and the debugfs "reset" entry both schedule > drvr->bus_reset, whose callback recovers drvr through container_of() > and dereferences it. [...] The patch does not apply cleanly on wl-next/main -- a rebase is needed. I looked more carefully at the cancel_work_sync-under-lock concern that was raised in the thread. brcmf_core_bus_reset() never acquires bus_reset_lock, so there is no deadlock. If the work has already started when brcmf_bus_cancel_reset_work() is called, cancel_work_sync() waits for it to finish; by then the reset op (brcmf_pcie_reset) has completed its own teardown and reinitialized the device, so the subsequent remove teardown acts on a clean device. The design is correct as submitted; only the rebase is needed. Regards, Arend