From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f227.google.com (mail-pg1-f227.google.com [209.85.215.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C77E381EBE for ; Sun, 12 Jul 2026 22:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783895604; cv=none; b=sjrHI8TBfWQmXiCzz4ShLswgUtAuiRNrsG65UsPxziL1gGwj0B7r5NZBAmAzP2jANhOasMWrUHPQfTrDiXuy6GeL9cCHS1JB+JNVqu82T+XdiuaHoPaxFx98+3hP1q8N1tnCoY+Ab/LzPnXB0apYoYppGYfw7CB+6ofinLYZG34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783895604; c=relaxed/simple; bh=9eV6FVRBj0+rcygV/638gCn4ARxyqwVGy0pBnruSIEI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GjTrNfjSPPip7h9mjtcAd5tnYZShAy8KbtRuUf8pA4jWkZG1Cb6Jl7gY7fqbCDfjcKO++iCVQLgSy12fHnvSWIb/QmezBqY5jph5aRAW7tKj02EH0d8vnklT/EEHldeABzJpNW3GwxaRqljeeZkw7sehDpp3mxeIvcqBDidsCAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=UcU6fRmc; arc=none smtp.client-ip=209.85.215.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="UcU6fRmc" Received: by mail-pg1-f227.google.com with SMTP id 41be03b00d2f7-c9aea40d799so1076860a12.0 for ; Sun, 12 Jul 2026 15:33:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783895603; x=1784500403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=as9uoNChv4bOT2fKEipNolL6IX5VF1WJ1fVqwJJ/Tbk=; b=EdXSJM/nyPU4kTO8+HMO4EXIdyKagxiMFR/e9zvjWXXXmVMsiyOJ/TcrZ09liW5aLV KHklzVs0DCkKPYVIBe5Rl7ghWIFKEcpeDxpZAraVBoTwlzW3C5uH8hOWp5HB1Z4PSLKn P85Vf+kvffzg0TXD+dXxPLehdAeHlwNi3Q5vKhKVDC4XKDaUK8n6wO4EgONuw0Zd5IpX y9l8A84L6ICL0CBnugs6BvPMWoHn/uZDTwQm53pqzT2bPP+MV+r5jp6a5Sc6N0CmvOwR DA7qw7nfZ282Nn/6QXbQ7mRi0mbyr3kySXrMzyOfjk9RRQ43ymot7UztB0VmX7jWyCGo n3pA== X-Forwarded-Encrypted: i=1; AHgh+RrNoUKGCF4fY328qH6WcJf4rin0pOfdgFqAcpOBRR69MFCWGNS7ijy956wev9VSAaEflomWvkJ9hgsignQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzNh6JteAX2KUt184qDw9cRN0Dev4uPuvvVgaOIAhkU7erXj8kM NCnAByl/Dk/a9l/dWXPZzAUgShjMSczSkkZZmIqzmwRq4JO+a9bJ6I+8U584jKLITbWt/4t026H g+8NRHW+G9UBC5pW0zVNWIVy/eMLNImFjQbA0GjmfHn6b+iFNa2tOD5KMI/gFAAkF2g4MHZrdGS dy6VAMgzGTh72lhFdoRx1JLu/+64V3W9AIaJ5fGTsRu/k6V70XFj5CK67pq1y914FjYiFNtx14K 5eEiuiM/c5nPIGS4+t1OmYfEA== X-Gm-Gg: AfdE7ckr+eDpcQ/LAGKkl8+Ypx92qVTsG2SYBYncIMQlTHPRpOXZYCo8C8ek7lnppTc UDk5Sw5OX2v6uJfZGMqt4B3hslvNEzEgfCaQY0Bywv/ZPINswNyFElAvI2GOkzO3P1LjzVP4yip AhGycO+wn+kDCuGguW/svg6THhoM2d96ARv/2kslDdCFgPvrjt0Y2eNiXdnfW9PWAhZTuO2NfWx JzD56t9PEVaDNYB81Xi/LK1+FXzigVPCI6XIODxaCFcAfgTz5BP18rBCejX9NbrB+9TFBG7ns3x QSwBC90KSZJUhAQdFD2efQrnFaAS5wjZV2+2IaqlGVOrNQPOQd/u4Z+j7V2jS5633/A/nT4Z9qY ohVojEudSeIIM9r0CtTLBtvMPww5By3/U9Zoi2KSzpJ4E0ieM6TBT3SD9DjgSYC5KEJbL+VqkUd +Jb+pP7daM9mDqxuR1yGbfbDFCmc49d9A6mFLmN/JjdALu1Ys= X-Received: by 2002:a05:6a00:13a6:b0:848:3e03:bfdf with SMTP id d2e1a72fcca58-848897d313fmr6517456b3a.46.1783895602602; Sun, 12 Jul 2026 15:33:22 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-6.dlp.protect.broadcom.com. [144.49.247.6]) by smtp-relay.gmail.com with ESMTPS id d2e1a72fcca58-847f6cf555csm2050081b3a.5.2026.07.12.15.33.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Jul 2026 15:33:22 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-381250979d5so2805745a91.0 for ; Sun, 12 Jul 2026 15:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1783895599; x=1784500399; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=as9uoNChv4bOT2fKEipNolL6IX5VF1WJ1fVqwJJ/Tbk=; b=UcU6fRmcDwP1BOIrJmXL+A6qaGJTwC5rPvbWnEUbJT7Dt0clJ354cZ2qzBK8UTZC+o a5Hk6epiCXqK9H6ujsupj0gPcQvg9rMBhBDzBsr92wuN1TNKXlZdv+YoZzRgrurwKjFA VtnVP/FjHqSlJKMNFQR2GHgk9DBQAqM0XxtvA= X-Forwarded-Encrypted: i=1; AHgh+RoQun25lEfacEfnY6+lVBpDS4kxoEoYRwnfGoIFUZNXK3cJszfpaELx+pFlvSTTx/Tb4eOV/Q1GV3vofiU=@vger.kernel.org X-Received: by 2002:a17:90b:2b43:b0:380:21b7:e727 with SMTP id 98e67ed59e1d1-38dc7a494a6mr7053679a91.14.1783895599474; Sun, 12 Jul 2026 15:33:19 -0700 (PDT) X-Received: by 2002:a17:90b:2b43:b0:380:21b7:e727 with SMTP id 98e67ed59e1d1-38dc7a494a6mr7053673a91.14.1783895599053; Sun, 12 Jul 2026 15:33:19 -0700 (PDT) Received: from bld-bun-02.bun.broadcom.net ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3120c8e41fcsm30681627eec.15.2026.07.12.15.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 15:33:18 -0700 (PDT) From: Arend van Spriel To: Jason Huang Cc: arend.vanspriel@broadcom.com, brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, Kurt Lee Subject: Re: [PATCH v4] wifi: brcmfmac: add DPP support Date: Mon, 13 Jul 2026 00:33:14 +0200 Message-ID: <20260712223314.2182929-1-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260708071230.312836-1-Jason.Huang2@infineon.com> References: <20260708071230.312836-1-Jason.Huang2@infineon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On Wed, 8 Jul 2026 15:12:30 +0800, Jason Huang wrote: > Add DPP AKM handling and RSN parsing support. Map DPP to the > firmware wpa_auth value and recognize DPP public action frames in the > P2P action-frame TX path. [...] > + p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif && > p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif->saved_ie.probe_req_ie_len) { [...] > --- > .../broadcom/brcm80211/brcmfmac/cfg80211.c | 151 ++++++++++-------- > .../broadcom/brcm80211/brcmfmac/p2p.c | 59 +++++-- > .../broadcom/brcm80211/include/brcmu_wifi.h | 2 + In the v2 review I asked to split the P2P device vif bug fix into a separate patch with a Fixes: tag for stable backport. The null guard and the fallback vif in brcmf_p2p_abort_action_frame() are both pre-existing P2P bugs that should be split out and submitted as a standalone patch so they can be backported to stable independently of the DPP feature. Please also add a changelog below the --- line describing what changed since v3. Note that the P2P device vif fixes are pre-existing bugs that need to go to the wireless tree for stable backport, separate from the DPP feature which targets wireless-next. Regards, Arend