From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35F1C385D6C for ; Sun, 12 Jul 2026 22:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783895857; cv=none; b=We0ZkNOKivI4gw/kizVp7giVy1fdtdjm2PGcZKreqsbyYoUrWH6iw+b+D+5GsKqGAlxVMDKjJ0womSraotBpwGBiXuuJbHMMNhL+ECFakzaI+t+LuUAJzRoUWYhpxhcEeuFx1fbspSTDkWn/L64OxlvUoAdS426yF5IpMQ+OeZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783895857; c=relaxed/simple; bh=08oSprP+WwMmz0m9FBUy9RlZxGSVrMAPZ0iqQCT2AYA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XELiK1JRm7klsRlzkamgIlxjtZdcbqzypA0WboZ6iN+wRzjHRcvPymKnQqtCT2f9hAATW3NQZnylcP6ccduhEra0Zk9sa1U0aMcGp2DGcPr1iKD+Wt64FMw9iworqpU7VASWEZxiCFgO3jDGmXNVFiVtjUDDKWW/brmoSyxMhW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i6oheFM3; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i6oheFM3" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so1002754a91.0 for ; Sun, 12 Jul 2026 15:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783895855; x=1784500655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YWATwDIutTx1ltHXfU6mx7SFptf2vWEErjZvLZxT9JI=; b=i6oheFM3Jljkgt+O0MgzUGTdtxyYEHpREKStRO4vbQ1UTMyRrb+S7njXfangv9ghg/ j/C6Txk5gN7X3glbroOz1xvH8ycHTrEfCc6aZ4KkpSdMVhImoavLFl6GEMBGl2bBYr4e uKqDEA/8MDpx/Qto6vcXtXQZ+gd+AI8A0Jbdzg2XyTDdkXBUqfGWQ4jyYz5MsEUU0M6L 4acJRPrU15n0qW/Zhpq3jXKJ35zjT+LjVnzXCtAEaOMp/L3WkOrT/Cui9irJLUmpx1h1 Al1EOQR38uCg9gXyK8KvWxwO0G7+qavJjU3R4hxTEBjyOsHMVlYD3WWVi8xUmcGFglWd PQiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783895855; x=1784500655; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YWATwDIutTx1ltHXfU6mx7SFptf2vWEErjZvLZxT9JI=; b=MN0ugMdhDkbhJnyOOj9SMe+Oy1xQ24MyK3+IWvRaF8CMA9bP3t2g6pKGT1HqqctN4H a8ArscLzkPNRPEVTyIHN4TsdRMeDLr8JcdHkxdyMKXmgUmlyNoi6OH4LU6RJE3cT3cpJ kPBZocYEnoy+IV65af7Sw8w7WbZoURvt3Xi8duyS7o+/T6ZL6OTRrQ9ggCxXVMw/cNyJ 8JSqLkxq+TJtMZHYwxVeJ6iz4U6z6xhJTCukGgRdgU1iJg9RaOSARTVPaqHdmxEFF70B 1vozx0BOT+O5OGkemfqlHTPeXS47x9U6AOSzG8kwcQqLdCNe1p0Y84OSQm3+1bMkHkTs +9EA== X-Forwarded-Encrypted: i=1; AHgh+RorJ690oTglz9OmYqS/q/YMwgeadN1FmoxKkOvwb4zZSm+Eeqv4gQjDbvT1LDIhZUX+kbsnT93CkL0wJ2U=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3XjhDcL5hYLOO2qlM7xwmjlpVl7+sPRCW2UMpXAkD95DuEAU/ xIz3Vt0UmsBfWGrHwq4JGwVzot6dcJmVoyyFV37LH1dAHjl7illfoqPb X-Gm-Gg: AfdE7cnWdQIykHzIrUaVQAOYeBtAxuLgp//dC+SUna84RLD7NocIVObA82+JLv4Av53 M95yvWSjxyDxshUnRdF7kxTBJ4TnT+z/8qYQcrHlYMlJuysIlO3wrFCBhxCIOR6Lr7I4vhWaQVK 9qb1rUgKWYBJOgC7BSa4hgoSFbNOAsV1khNodevzAo2cNldgMO2rjt/1mr6kpZiMnV2aJX3LVTo aQEAy7piNUdLXJXrZuNip9PTIKhSUY3y0y4T/wGOUxOyXdYXOV32xxl5OsXKrv15t2/uPvootmd kQod6IEL6vfAR/4PzFm9IF03iAY79v6sH5cXjlI6sPlhxVtwmjVpH9AkN+NNGY57t4NjuZOIE1J bV52jaAuTU6FRZMlDJpmH4UxDlPaQuMXLoeVCDun7w+jTvNqJ0zrUiSkIQGgScq6UatpyOMRs+6 J8JlDTSLpQijNEVJ/N7JjRKqRW2B+VvgqvdL0pSwa7VFTkR7FzCm8G3LM5n38Q+bs20cB+vpmZL xVkWdsmYVT4l1HBr39jaXEa5Nl5nhwXsqFYVI8KYXI/Dtj1fHvoe3r+uXoZFhFAI0NV8+OUnaS3 X-Received: by 2002:a17:90b:3c8d:b0:36d:7b62:4767 with SMTP id 98e67ed59e1d1-38dc78229ffmr6302452a91.5.1783895855294; Sun, 12 Jul 2026 15:37:35 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5506b48bsm5517278a91.1.2026.07.12.15.37.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 15:37:34 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2] ata: sata_mv: use devm clock helpers Date: Sun, 12 Jul 2026 15:37:33 -0700 Message-ID: <20260712223733.1084077-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace clk_get/clk_prepare_enable/clk_put with devm_clk_get_optional_enabled for both the main clock and per-port clocks. This eliminates the need for manual clock cleanup in probe error and remove paths. The err label is retained for phy_power_off cleanup, since devm_phy_optional_get does not manage phy power state. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- v2: sashiko: use goto instead of return. drivers/ata/sata_mv.c | 46 ++++++++++++------------------------------- 1 file changed, 13 insertions(+), 33 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index 145ba6880c82..d260f04e6384 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -4088,21 +4088,19 @@ static int mv_platform_probe(struct platform_device *pdev) hpriv->base -= SATAHC0_REG_BASE; - hpriv->clk = clk_get(&pdev->dev, NULL); - if (IS_ERR(hpriv->clk)) { - dev_notice(&pdev->dev, "cannot get optional clkdev\n"); - } else { - rc = clk_prepare_enable(hpriv->clk); - if (rc) - goto err; - } + hpriv->clk = devm_clk_get_optional_enabled(&pdev->dev, NULL); + if (IS_ERR(hpriv->clk)) + return PTR_ERR(hpriv->clk); for (port = 0; port < n_ports; port++) { char port_number[16]; sprintf(port_number, "%d", port); - hpriv->port_clks[port] = clk_get(&pdev->dev, port_number); - if (!IS_ERR(hpriv->port_clks[port])) - clk_prepare_enable(hpriv->port_clks[port]); + hpriv->port_clks[port] = devm_clk_get_optional_enabled(&pdev->dev, port_number); + if (IS_ERR(hpriv->port_clks[port])) { + rc = PTR_ERR(hpriv->port_clks[port]); + hpriv->n_ports = port; + goto err; + } sprintf(port_number, "port%d", port); hpriv->port_phys[port] = devm_phy_optional_get(&pdev->dev, @@ -4116,8 +4114,8 @@ static int mv_platform_probe(struct platform_device *pdev) /* Cleanup only the initialized ports */ hpriv->n_ports = port; goto err; - } else - phy_power_on(hpriv->port_phys[port]); + } + phy_power_on(hpriv->port_phys[port]); } /* All the ports have been initialized */ @@ -4156,17 +4154,8 @@ static int mv_platform_probe(struct platform_device *pdev) return 0; err: - if (!IS_ERR(hpriv->clk)) { - clk_disable_unprepare(hpriv->clk); - clk_put(hpriv->clk); - } - for (port = 0; port < hpriv->n_ports; port++) { - if (!IS_ERR(hpriv->port_clks[port])) { - clk_disable_unprepare(hpriv->port_clks[port]); - clk_put(hpriv->port_clks[port]); - } + for (port = 0; port < hpriv->n_ports; port++) phy_power_off(hpriv->port_phys[port]); - } return rc; } @@ -4186,17 +4175,8 @@ static void mv_platform_remove(struct platform_device *pdev) int port; ata_host_detach(host); - if (!IS_ERR(hpriv->clk)) { - clk_disable_unprepare(hpriv->clk); - clk_put(hpriv->clk); - } - for (port = 0; port < host->n_ports; port++) { - if (!IS_ERR(hpriv->port_clks[port])) { - clk_disable_unprepare(hpriv->port_clks[port]); - clk_put(hpriv->port_clks[port]); - } + for (port = 0; port < host->n_ports; port++) phy_power_off(hpriv->port_phys[port]); - } } #ifdef CONFIG_PM_SLEEP -- 2.55.0