From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C46613FC5AB for ; Mon, 13 Jul 2026 12:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944077; cv=none; b=Gr0ALmOTtioyAUaZDF0BAuqO4s90kDWco1lBe7ZYwI80hf54czGr1E3QOpZRHtiGszs74rD5LN5XzyR46xcObE+psc+7o3rPN+ZTsYq7PDBXxp/FjkLS6ylRD0nsYQkKKNeRTqrZCqCKcMQcgkk1SUQnkxL0I2cuwjyX/wwi+9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944077; c=relaxed/simple; bh=53ICJc8qJnkq2uR6QNbHG4MizR5aQngiFWAplX8e7ZQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KsDsqgMGCN0xyjxrRnA458Y0Py+N3x4DCh8fOuqiDxdcczkAbbHnRBtSatYCKkSfJNCJpIlUZF8bSX4JZ8yfS7Woha9y6tAEM+4J7kt0CFe3OByZi+Edkcp/MhLFshEqG7wg2/8liQwKxN7BxWlfiXnsQEJ28+t1v6BOzbhXiCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iBr/2yOW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fVGWbQiz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iBr/2yOW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fVGWbQiz" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D77Td9810602 for ; Mon, 13 Jul 2026 12:01:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= G3bvnkiaRpsv8wjgu6CwsTey95Lq+Ru74ZSc4ZFHu60=; b=iBr/2yOWmtUKRsyQ CXnrufnFBDgBPaYx+EhbD6iUI6/qPZlalf6SluaSCioo+12Jp0ibfnEBIG3N0sdn 0NNavxwM0xl4v2MRrT34XFo3EvcDN8NUEo+hxsiea/dP09OQX2+GHB7D/WdeFlC4 C8OZOfawhXZwd1VQY1YstR9miR8mr3l68CktV7Kc0Xr6/FvZPoBSyRhy+1mYRhNg dFATIsVB/2YaaFjHjUdBn4qQ0+wmR6HIl12SnHirs46w6/FfengAWfhA+GR2YLhc aoIZ0GcdFqbg3ik4UwqSaCeqKRIRBHd5+ZXnOvinbP86LfyI28dZySih8FN07PWq FTzKNg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcubss2ex-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 12:01:14 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c9e5aba3d80so302156a12.2 for ; Mon, 13 Jul 2026 05:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783944074; x=1784548874; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G3bvnkiaRpsv8wjgu6CwsTey95Lq+Ru74ZSc4ZFHu60=; b=fVGWbQizldaadDUgQY8aARYdRDsUELbzEZutDAiJnSccc6K+M/kewjBQSuyZFpdBeY cBeVL53tJwvniMgnBYgXQ0PBeMukR3izqIE6qWauJGlvHpPrMkjIZEOHYQXxaZAYFpPx tsG8Y5wbcd9mtN3PwFDewBV8wAVqE27NZRzeWximSP95dMu+i/SGl53tXuT5q8OfkGH9 q0h7yFCrrI/YnEDRC8bdN6ZSyBy8nmTiDkaBvnvij/PekZY+21mr6dVt3wmLrPRoJ/Yh yLQPTnDlb1tfvxzK9nfpECfCkprpGHYRLZreFA27Hvwkydsh7KI7rfDUnDbikhRQmMjm 85BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783944074; x=1784548874; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=G3bvnkiaRpsv8wjgu6CwsTey95Lq+Ru74ZSc4ZFHu60=; b=i1YyhCk96G+yapF2XJvZ1oFwnJkr36oCW3JMUJ6gB7VttY/UvN/sQ1PSal4MURWE3/ +1OiBBrILg0xE9gE78uuSQLLcf4tWUr4TB/Etg5KzPKUyfjJjPru8GbUrSYXKsyhn+cQ LByX7VcuetBUUaIvPZF+QspUfKsUUfbE8+cqBUF+8lUf4FWE+G1kHN7ssIf2wuI436F2 sXmiLMeDW4rG6/liuFv7Dn1lH1KGi1PvNOyVph691ITYqfQKHda4mFWf5i3GFTu71Y+j CP7pufafjh9lFCYyww3rBiSJG1Xbiqsrk55AXPs3PUkmr3q0S/oP04jpfLO0oqhi853A lgTA== X-Forwarded-Encrypted: i=1; AHgh+RoFAya3Tz8urWP952EQUclrKDEHBsJuQyZ2xRQ0pHjQuKX1YQRRv1tcxVVuxZJZRd3p47kor4PKBZL7svM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywb+12soKmvU/uX88h2r5DfJegiFuhqcZkJbZtvluz+CiLIac3F eMaWdtCH2GTaMaAbcWSZTLtUjrxvpLfQMPcFeX3+ZUfzLVEGTf2St/dpfRStg041QcO0jhvyL2B itWGQjvVHo1WJszk2vICGgSiEZDO9Ou1a9kGto/5HAlaCMxybg/Affx/ubf4Cz5f58bc= X-Gm-Gg: AfdE7cmFySNBLu9fVlPrhTTdWaxsAePvTXpKe2BYVIRZZjMjr/PhUeichklEg2Kv9Vx 2lRL3uMJ3qIIUH95sSKLI2AV6vSmffw6KZiAUSEBlKiJgjxwvE6fDgcHf9KFUI1yKy3fLCYoLvI eQvIXO8QHl4d7hYHviwStPDUL+zzwG1mF50DVW9PgTHSDf2NLLtOBk52GyCEc2M+J5TXWTBeGtx eNrbg7Jm6Cgk4rdF9oaemmcMaFVBDA/5du9znOuHvnnMcDG/8F0FK+DaAOeRY9rA+Xvtq8JrSB8 PV5C3xzwt1ORoJvzV2UKHyPC6rZnCHJNM2Xntr7vm/NmRmIOod79UPCsO8eIWsvyULZA9q4lCbN OtQxVhsHTjPG7cL3R2epDbQeRB+tH8l9inSsx/AsPvOVnMFhtpaZ6Yjc2QQ== X-Received: by 2002:a17:90b:5867:b0:381:cef1:11b2 with SMTP id 98e67ed59e1d1-38dc77c79b5mr6893213a91.7.1783944073690; Mon, 13 Jul 2026 05:01:13 -0700 (PDT) X-Received: by 2002:a17:90b:5867:b0:381:cef1:11b2 with SMTP id 98e67ed59e1d1-38dc77c79b5mr6893183a91.7.1783944073214; Mon, 13 Jul 2026 05:01:13 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174ae6cd9sm74577772eec.31.2026.07.13.05.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 05:01:12 -0700 (PDT) From: Zijun Hu Date: Mon, 13 Jul 2026 05:01:11 -0700 Subject: [PATCH v2 1/5] Bluetooth: coredump: Introduce and apply hci_devcd_state_name() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260713-btusb_prep_qcc2072-v2-1-bbcb651285f2@oss.qualcomm.com> References: <20260713-btusb_prep_qcc2072-v2-0-bbcb651285f2@oss.qualcomm.com> In-Reply-To: <20260713-btusb_prep_qcc2072-v2-0-bbcb651285f2@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz Cc: Zijun Hu , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.14.3 X-Authority-Analysis: v=2.4 cv=Oq9/DS/t c=1 sm=1 tr=0 ts=6a54d38a cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=-o8gAGCozA265rLodYYA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: 52RnBgqE4hF63sp7tG6uv-6Ni4x8EWI0 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDEyNSBTYWx0ZWRfX+wC84H4RXh8s KLYyd/mDhOkI0wEdvCW2Ni2wKyLIsVm916NRwTFgVgAi7W0YZ0zTmGN5tkX6L9U0IXyE97klRSE xq480JcTxSzgLgAGx4EWPwYwKJqHgVs= X-Proofpoint-GUID: 52RnBgqE4hF63sp7tG6uv-6Ni4x8EWI0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDEyNSBTYWx0ZWRfX78eBHb1m1/BB QKzQuZbiTiU6C4l4rhVMjGWEANo56Asc+UFlrwI6w8zsNLl6yXJ132CN0UdsPzkYk4DFwwnaK/m riGIRLl1BEfxUt4LSpu5iR4GQKUQZk80xFk94umk2YQ0vUMUWFUuHqv1u6rv/UxeRQx8l80RLwW SpsmOCJaIJ8w40M4V21G/ZEOj5NVALcpw9E3hCtKy4PckIaavsmfyCxoMddP9gt4VW8eRrEJORk 8Yb3gC2BaAwl70fu3tebw9+0ws1TQUVhXkXax8u23a8ZYGKM6kHcd7WnsLwkzQ+3y9WoKxLL2Dt GKMVXoel19ZBav4WweDKVpOdtkwj98g5tMwkvqVN3nKF6oBKODXAkDHbfi1A5uUv72FsXZDgMqM p3VjtfnbuuPgZkrJFGUOqYeQZ01IqtZYDfjqZIsvJOyAoh46XGqs8+ZeyGf5+6njOiggG7xb1Pj kLNvrBVQksg4BOhfT7w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130125 Introduce hci_devcd_state_name() to make devcoredump state more readable, and apply it in coredump.c. Also remove a trailing space in two bt_dev_dbg() format strings while applying it. Signed-off-by: Zijun Hu --- include/net/bluetooth/coredump.h | 7 +++++++ net/bluetooth/coredump.c | 45 +++++++++++++++++++++++++++++++++------- 2 files changed, 45 insertions(+), 7 deletions(-) diff --git a/include/net/bluetooth/coredump.h b/include/net/bluetooth/coredump.h index 72f51b587a04..ab85a6adfffd 100644 --- a/include/net/bluetooth/coredump.h +++ b/include/net/bluetooth/coredump.h @@ -60,6 +60,8 @@ struct hci_devcoredump { #ifdef CONFIG_DEV_COREDUMP +const char *hci_devcd_state_name(enum devcoredump_state state); + void hci_devcd_reset(struct hci_dev *hdev); void hci_devcd_rx(struct work_struct *work); void hci_devcd_timeout(struct work_struct *work); @@ -74,6 +76,11 @@ int hci_devcd_abort(struct hci_dev *hdev); #else +static inline const char *hci_devcd_state_name(enum devcoredump_state state) +{ + return ""; +} + static inline void hci_devcd_reset(struct hci_dev *hdev) {} static inline void hci_devcd_rx(struct work_struct *work) {} static inline void hci_devcd_timeout(struct work_struct *work) {} diff --git a/net/bluetooth/coredump.c b/net/bluetooth/coredump.c index c0f027fab583..913bbba559f8 100644 --- a/net/bluetooth/coredump.c +++ b/net/bluetooth/coredump.c @@ -30,8 +30,9 @@ struct hci_devcoredump_skb_pattern { #define DBG_UNEXPECTED_STATE() \ bt_dev_dbg(hdev, \ - "Unexpected packet (%d) for state (%d). ", \ - hci_dmp_cb(skb)->pkt_type, hdev->dump.state) + "Unexpected packet (%d) for state %s.", \ + hci_dmp_cb(skb)->pkt_type, \ + hci_devcd_state_name(hdev->dump.state)) #define MAX_DEVCOREDUMP_HDR_SIZE 512 /* bytes */ @@ -50,8 +51,9 @@ static int hci_devcd_update_hdr_state(char *buf, size_t size, int state) /* Call with hci_dev_lock only. */ static int hci_devcd_update_state(struct hci_dev *hdev, int state) { - bt_dev_dbg(hdev, "Updating devcoredump state from %d to %d.", - hdev->dump.state, state); + bt_dev_dbg(hdev, "Updating devcoredump state from %s to %s.", + hci_devcd_state_name(hdev->dump.state), + hci_devcd_state_name(state)); hdev->dump.state = state; @@ -245,7 +247,7 @@ static void hci_devcd_dump(struct hci_dev *hdev) struct sk_buff *skb; u32 size; - bt_dev_dbg(hdev, "state %d", hdev->dump.state); + bt_dev_dbg(hdev, "state %s", hci_devcd_state_name(hdev->dump.state)); size = hdev->dump.tail - hdev->dump.head; @@ -368,8 +370,9 @@ void hci_devcd_rx(struct work_struct *work) break; default: - bt_dev_dbg(hdev, "Unknown packet (%d) for state (%d). ", - hci_dmp_cb(skb)->pkt_type, hdev->dump.state); + bt_dev_dbg(hdev, "Unknown packet (%d) for state %s.", + hci_dmp_cb(skb)->pkt_type, + hci_devcd_state_name(hdev->dump.state)); break; } @@ -549,3 +552,31 @@ int hci_devcd_abort(struct hci_dev *hdev) return 0; } EXPORT_SYMBOL(hci_devcd_abort); + +const char *hci_devcd_state_name(enum devcoredump_state state) +{ + const char *state_name = "Unknown"; + + switch (state) { + case HCI_DEVCOREDUMP_IDLE: + state_name = "IDLE"; + break; + case HCI_DEVCOREDUMP_ACTIVE: + state_name = "ACTIVE"; + break; + case HCI_DEVCOREDUMP_DONE: + state_name = "DONE"; + break; + case HCI_DEVCOREDUMP_ABORT: + state_name = "ABORT"; + break; + case HCI_DEVCOREDUMP_TIMEOUT: + state_name = "TIMEOUT"; + break; + default: + break; + } + + return state_name; +} +EXPORT_SYMBOL(hci_devcd_state_name); -- 2.34.1