From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78BB542252C for ; Mon, 13 Jul 2026 13:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783947724; cv=none; b=qgpec/QxpDXCqZBpGqfsqRFHEogSngKgEZG4HKVqIG3cSu3xCqjERsJFjmpuKJiBlVze3LQo59GhFm+I2Ou+B3AI+VEyYfclbtS+AhvwWmIIaWfcV/cWX45l4/D7nsJDZW28Od7VvB/+xNkO33+edYxzBJ/nQi0wsn0eQxp6R1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783947724; c=relaxed/simple; bh=vpDVf/b6zHPEUgtVCAl2sRJELM4MLJc6gtP24/up104=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V+1UBJ5lVAWHK2VSJZje6ovNSWoDj4vC3hYura0ER1HSwJAL+4y99catnEkkn06ALbikRV6LLw2dmOJBtggbHHmtZ9CtwcL9GLmSsQ+6B3E9RqxWZlLFvg/gs915pHmCWgTpnXuGwz9ZxWgXaEEpEi5LVuOOQ9JxBYrVtz08huk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mtKQ6aQh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gMucHhW5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mtKQ6aQh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gMucHhW5" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DCDdVv1480702 for ; Mon, 13 Jul 2026 13:02:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= twry+rQD67k4KXlgASz4DIRuOCwVvltNp8BQTuA56nA=; b=mtKQ6aQhFyuDQE93 vLS0PLFWn+3ssts+aKobAO4Z3qGaqUVXI5gjuS1xu91JAaK0kAk/MFI1n9gRiUXK VZzGPSNz7Bp8q1PLeYXrHFP1zBkaHghZt20UDZxw9SVbih6HTBrYynh9ebRMxzq4 x7idrnW8SkVIPMMgND2OOJ9L5ZatDG6f1i0qL5BlTCGbRBX68aqkgW7qgO0zmXe1 exmg4REXsTFM0RWl+20r6ygIGPNOxnnFnAj7bIJimxGs7typmqwCVsb4VRF8/iPS 4TOkXNTH8GpUVAUlnxv++fl7mtAbYY+u2zDjZ7DLmFdVMOxrhx523pVll9J1dIRf 6wTqRg== Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcwavrsr4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 13:02:01 +0000 (GMT) Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7e9fec69475so4469488a34.0 for ; Mon, 13 Jul 2026 06:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783947721; x=1784552521; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=twry+rQD67k4KXlgASz4DIRuOCwVvltNp8BQTuA56nA=; b=gMucHhW5BoPBwUwLCckmIDCpK9XTzFlSaeTKRwMaaObwObocfyrPgxjD9kFBfOCzUa VJ22R91f9t8JzE2Yj/eMCgjNDlkKVbud/NHTL2opSdEzYvlTaUIjTpeTHWx/ZEE92WXN BKCY9xqV2AHJ7DfqUO5Jovh2cci5xXZeaVuhmyjRXYG841aYGnTnjZ64reI34rFsHpVa Ls6EcYoq+fefvBmSg9+kkeIJTPkRj3g+zG1TwMKqJm02HQOM1k81hZGbyQzNylLCekNs /khNOx9bVg08oZsMW1R8cm6iS3JLUZA9WQrH0heKncB4BFOroa+bWVUrlPlceJzOFLzW ePBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783947721; x=1784552521; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=twry+rQD67k4KXlgASz4DIRuOCwVvltNp8BQTuA56nA=; b=Smj4JXJtL7ydCkUPW+xhdYFjBXsxmBqoA3YUNo9dOxSW/DCFITOH8BmpXv9X2y/GpM mPS6Ceu+NCFbRmpyPVMeomYYWp0933rO/U0268xGuQJSwCxOTr2BqNiLGzDxpjOtYaZl jQJFytghwDm9V9J4AQrDUkEu8W5RWxS9Ndj8Rkfb/u8PPXSUfyMkBtA8MtZ0dC6S8/c2 pr69PtU6IwJKV52J4TlkGDJHsMYEmblUrF47VkWq7LSkxRv/FXV09CNYc2Zm+tusqo0s rELX/VqWPBcmT9rGnmTsDLks2sTu1aDN9hYHAupJzt1ForGl4lroq/HKgYiz7r5yeoVD NtCA== X-Forwarded-Encrypted: i=1; AFNElJ8N+B4GNm+VzNuRn30FDpr5rox+txu8IbNUj/utL8jAzvf62g9iR86zuKfZk6T2b0slhQlWGEeD4iTZmY8=@vger.kernel.org X-Gm-Message-State: AOJu0Yywab/w3m3PQfIxqC0efJdrheUgluKdug5JhX6vFzxCjLba/arf oc7cNhZACckug8Pb7X3uu1WFo5seA85Noq0fT/IEWgAul7tC3U+Ls71nlNIuTaOmdeQabFzaf+N RoU4cYdVbDCAPP5eMqxrwTQKBeTYmm2f/w4cHnk07kh4I/j/ozTnA6ZolGSntGWhvI50= X-Gm-Gg: AfdE7clIIN+y8OplKpJ75+UcaLiR7k/qQPBpTomgkTFdG7fMM2V0DsSiYhP1KgWLex5 N7wHaQ+6IExSXqTjuJA204Fdki+dqPrGl6fo50JgWJjApKaHMDZL/l4qZXI+iTza6b65MFpgiWt sCu73MNPnSTdVjdQS/Lp2nrgUitVKAGy2BQi1SIMEVvXEhe+QHez4vPTIEkf+/067+UR+tk2/14 4W2awD+W5XWOexZO+kj/MczpCPhM56HPr8aSOy7IqB1b5nG0dCS2UlCj+mPyVLBrmjI0nMDYPDI 7hhIfYHHZaJGv0yEPt5qAi2CSga5ziF6MTG4dHdRi7VqXdDG6F+BB4EbE5XcaE7rJpjq9smqe2c w4U4rzUp1kJGVDJirT/Ju0lS/Lz2r7kODsbbjKGmR X-Received: by 2002:a05:6820:4cc1:b0:6a3:916a:1d26 with SMTP id 006d021491bc7-6a39a8561bemr5856219eaf.61.1783947720494; Mon, 13 Jul 2026 06:02:00 -0700 (PDT) X-Received: by 2002:a05:6820:4cc1:b0:6a3:916a:1d26 with SMTP id 006d021491bc7-6a39a8561bemr5855857eaf.61.1783947715189; Mon, 13 Jul 2026 06:01:55 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:8881:83b8:89fa:1a2a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f2d97527sm306129725e9.2.2026.07.13.06.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 06:01:52 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 13 Jul 2026 15:01:10 +0200 Subject: [PATCH v21 09/14] crypto: qce - Remove unused ignore_buf Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260713-qcom-qce-cmd-descr-v21-9-bc2583e18475@oss.qualcomm.com> References: <20260713-qcom-qce-cmd-descr-v21-0-bc2583e18475@oss.qualcomm.com> In-Reply-To: <20260713-qcom-qce-cmd-descr-v21-0-bc2583e18475@oss.qualcomm.com> To: Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Md Sadre Alam , Dmitry Baryshkov , Manivannan Sadhasivam , Stephan Gerhold , Bjorn Andersson , Peter Ujfalusi , Michal Simek , Frank Li , Andy Gross , Neil Armstrong Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2066; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=j6XY4tGbVrzzivRLNBnBuYRESnCKLFI7yXVP5haQkuk=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqVOGeHIeb8ttU8NMHmfvZe/dnHD8TlSqP+D4CC DKyl2r0VFyJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCalThngAKCRAFnS7L/zaE w3GID/9wtsZ7eG9siySdL9ECGYbUZMDbkEeFrIkn7nhWh+imlHfzg+aps1ekYXqrnnKoNpMAcYj s5S+a7t13UfMF0H4ezCA4SmKeySbw4Xza4+KOINoRrCvitkyhrOhRnOFTGtL5OYdsxUi8vBYxfA bhOYwwMqCw7xtvs39WG+W+ugZyCQMBrvMOVao1ZTs/QOVw5JdfTK7Enjn6CPI047t7+XtVbdcnR AO8b52ajf+00/8XS9y2hWNMhT5hPJq1QjkwjaCBTObA23ROM4Z7cGEXjrn0TNSwFOGdiBaI7voe FCJ9VyAiQ3yRc5198Eni4HMzXj5sqx9F5X+ZYs+sd8lJrvAld3W7gZMIZ3TJ9SZ8cpTzqmMqUqv pwheSNQn9xKZ2M+opu+1hy7/26q5i+Wk/hNPr8w/gYP29uPGH2/ZCBTwH3mHbK4Auw/w8oHI+aA q2aXjx9NPwmqdFBvo7EHkgNDmckjNdXVmbg+pmujnI8AeKsKpVqartHSq2sVSrE4NnFPbjGNlfJ GYyJNVtENy8vNNqtCs2rbm1CX4Cp2nNLnd4GPm257Yy/HS1E8BhMfwaVKgbqszK9Zx/smc3DJvT pOtMoWNgul11dbGF21pBRIe4dSyZoJ22b64Quq16v7iBe6XsVrKSjj3xPBP9JsDPEYNkrtYJ8vf 9BPGsifSF6T4yow== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-GUID: BgAveSB9RqYY_DNOC-sviQFauyeGX7AD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDEzNSBTYWx0ZWRfX/eVRB2sAL0LH 6zquztRKNpqCsq2N+gc1ZKGU4ZS4orWYlHwz+BUVJ2ZgLmQszzFxB7a8GrfrkiEcVFx8/h5pD6R NRBjQLIaXmN/P+JyVVwL1oHvTNrsUl6it/tg9eye1l3zzWCi3yY/07jDdv1pfQhAeJC/Plvybd1 m58MFUVXg2CXA3oOMyP4HCRPIq2GJB/9PeeYFvV2ZcHogoq3U/qyPrNRmzKBQELYY9iSkiB/X/p qt4mmNQjl/yyua9h3P8uKf4qMrLebj4aVorODblnTHE9UXr0HI73crXMxIHFVj4sosjKZuJkRIY Ucxb3dvNnFADkEJ8c5QEuV8LxzMbyAG7L9lDS661I7i6wNWuU3shAeJqVkO9gdEKxVKHoKy4mx4 GsIZUpslAQr+5BSlz+jyMQPoWVo9dy+F2FrLZbr6zW8sbOYH/D5QF/NpmMLxJmWJT+wax2kpXiz jtEsiU2F0XGYRUJJ0lw== X-Proofpoint-ORIG-GUID: BgAveSB9RqYY_DNOC-sviQFauyeGX7AD X-Authority-Analysis: v=2.4 cv=dZSwG3Xe c=1 sm=1 tr=0 ts=6a54e1c9 cx=c_pps a=7uPEO8VhqeOX8vTJ3z8K6Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=tWRRbWwrKX-5tUpmLDIA:9 a=QEXdDO2ut3YA:10 a=EXS-LbY8YePsIyqnH6vw:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDEzNSBTYWx0ZWRfX28VydIErcyY4 lk66uizklf6emSujeXU3N7LnQgu4SMSdTPSPGR4NAh52P7t7m+GV5a0pQxAsNmea03xFFcITfpa 3R/WFAUX2rWJSXD3BOWtJjsznuIfOtc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130135 From: Bartosz Golaszewski It's unclear what the purpose of this field is. It has been here since the initial commit but without any explanation. The driver works fine without it. We still keep allocating more space in the result buffer, we just don't need to store its address. While at it: move the QCE_IGNORE_BUF_SZ definition into dma.c as it's not used outside of this compilation unit. Signed-off-by: Bartosz Golaszewski Reviewed-by: Manivannan Sadhasivam Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/dma.c | 4 ++-- drivers/crypto/qce/dma.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/qce/dma.c b/drivers/crypto/qce/dma.c index 7ec9d72fd690fb17e03ade7efe3cc522fb47e1ac..d1daa229361aa74da5d3d7bfe1bc8ab189761e38 100644 --- a/drivers/crypto/qce/dma.c +++ b/drivers/crypto/qce/dma.c @@ -9,6 +9,8 @@ #include "dma.h" +#define QCE_IGNORE_BUF_SZ (2 * QCE_BAM_BURST_SIZE) + static void qce_dma_release(void *data) { struct qce_dma_data *dma = data; @@ -43,8 +45,6 @@ int devm_qce_dma_request(struct device *dev, struct qce_dma_data *dma) goto error_nomem; } - dma->ignore_buf = dma->result_buf + QCE_RESULT_BUF_SZ; - return devm_add_action_or_reset(dev, qce_dma_release, dma); error_nomem: diff --git a/drivers/crypto/qce/dma.h b/drivers/crypto/qce/dma.h index 31629185000e12242fa07c2cc08b95fcbd5d4b8c..fc337c435cd14917bdfb99febcf9119275afdeba 100644 --- a/drivers/crypto/qce/dma.h +++ b/drivers/crypto/qce/dma.h @@ -23,7 +23,6 @@ struct qce_result_dump { u32 status2; }; -#define QCE_IGNORE_BUF_SZ (2 * QCE_BAM_BURST_SIZE) #define QCE_RESULT_BUF_SZ \ ALIGN(sizeof(struct qce_result_dump), QCE_BAM_BURST_SIZE) @@ -31,7 +30,6 @@ struct qce_dma_data { struct dma_chan *txchan; struct dma_chan *rxchan; struct qce_result_dump *result_buf; - void *ignore_buf; }; int devm_qce_dma_request(struct device *dev, struct qce_dma_data *dma); -- 2.47.3